From: Steven Rostedt <rostedt@goodmis.org>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Jiri Kosina <jikos@kernel.org>,
live-patching@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Miroslav Benes <mbenes@suse.cz>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] tracing: define needed config DYNAMIC_FTRACE_WITH_ARGS
Date: Fri, 6 Aug 2021 21:18:08 -0400 [thread overview]
Message-ID: <20210806211808.6d927880@oasis.local.home> (raw)
In-Reply-To: <20210806195027.16808-1-lukas.bulwahn@gmail.com>
On Fri, 6 Aug 2021 21:50:27 +0200
Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> Commit 2860cd8a2353 ("livepatch: Use the default ftrace_ops instead of
> REGS when ARGS is available") intends to enable config LIVEPATCH when
> ftrace with ARGS is available. However, the chain of configs to enable
> LIVEPATCH is incomplete, as HAVE_DYNAMIC_FTRACE_WITH_ARGS is available,
> but the definition of DYNAMIC_FTRACE_WITH_ARGS, combining DYNAMIC_FTRACE
> and HAVE_DYNAMIC_FTRACE_WITH_ARGS, needed to enable LIVEPATCH, is missing
> in the commit.
>
> Fortunately, ./scripts/checkkconfigsymbols.py detects this and warns:
>
> DYNAMIC_FTRACE_WITH_ARGS
> Referencing files: kernel/livepatch/Kconfig
>
> So, define the config DYNAMIC_FTRACE_WITH_ARGS analogously to the already
> existing similar configs, DYNAMIC_FTRACE_WITH_REGS and
> DYNAMIC_FTRACE_WITH_DIRECT_CALLS, in ./kernel/trace/Kconfig to connect the
> chain of configs.
>
> Fixes: 2860cd8a2353 ("livepatch: Use the default ftrace_ops instead of REGS when ARGS is available")
> Cc: <stable@vger.kernel.org> # 5.10.x
FYI, we don't add # 5.10.x anymore. The Fixes tag above is what
determines where it gets backported to.
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
>
> Steven, thanks for the quick response; please pick this quick config fix.
I placed it in my queue to go into the 5.14-rc cycle.
Since this affects live kernel patching, can I get a Tested-by from one
of the live kernel patching folks?
Thanks!
-- Steve
next prev parent reply other threads:[~2021-08-07 1:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 19:50 [PATCH] tracing: define needed config DYNAMIC_FTRACE_WITH_ARGS Lukas Bulwahn
2021-08-07 1:18 ` Steven Rostedt [this message]
2021-08-17 9:28 ` Miroslav Benes
2021-08-17 13:37 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210806211808.6d927880@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=mbenes@suse.cz \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.