From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Cc: Peter Seiderer <ps.report@gmx.net>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] package/kmsxx: update to latest
Date: Sun, 8 Aug 2021 11:29:35 +0200 [thread overview]
Message-ID: <20210808092935.GK27036@scaer> (raw)
In-Reply-To: <20210806125047.1832422-2-tomi.valkeinen@ideasonboard.com>
Tomi, All,
On 2021-08-06 15:50 +0300, Tomi Valkeinen spake thusly:
> We can drop all the patches as they have been sorted out in upstream.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> ---
[--SNIP--]
> diff --git a/package/kmsxx/kmsxx.mk b/package/kmsxx/kmsxx.mk
> index 871ecaf85c..ab0158d1ed 100644
> --- a/package/kmsxx/kmsxx.mk
> +++ b/package/kmsxx/kmsxx.mk
> @@ -4,7 +4,7 @@
> #
> ################################################################################
>
> -KMSXX_VERSION = 548905611c130ea9d31929a0caf7a198d8bac462
> +KMSXX_VERSION = 824bbb1f4cd062d66b457faca50f904b34dfd96c
> KMSXX_SITE = $(call github,tomba,kmsxx,$(KMSXX_VERSION))
> KMSXX_LICENSE = MPL-2.0
> KMSXX_LICENSE_FILES = LICENSE
> @@ -13,9 +13,7 @@ KMSXX_DEPENDENCIES = fmt libdrm host-pkgconf
> KMSXX_CONF_OPTS = \
> -Dkmscube=false \
> -Dpykms=disabled \
> - -Domap=disabled \
> - -Duse-system-fmt=true \
> - -Duse-system-pybind11=true
Those options have been dropped upstream. Does that mean that they now
always use a system-provided fmt and pybind11, or that they always use
their bundled versions?
The answer is mixed.
For fmt, the option was dropped entirely, and upstream dropped their
bundled version in fdffbcdc0b0e (Use system libfmt). So we can indeed
drop -Duse-system-fmt=true.
But for pybind11, the option we added in our patch, was added with a
different name upstream. We had 'use-system-pybind11' as a boolean, they
added 'system-pybind11' as a feature.
Applied to next, with the above changes. Thanks.
Regards,
Yann E. MORIN.
> + -Domap=disabled
>
> ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
> KMSXX_CXXFLAGS += $(TARGET_CXXFLAGS) -O0
> --
> 2.25.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-08-08 9:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 12:50 [Buildroot] [PATCH 1/2] package/kmsxx: remove erroneous use of static-libc option Tomi Valkeinen
2021-08-06 12:50 ` [Buildroot] [PATCH 2/2] package/kmsxx: update to latest Tomi Valkeinen
2021-08-08 9:29 ` Yann E. MORIN [this message]
2021-08-08 18:12 ` Tomi Valkeinen
2021-08-08 20:33 ` Yann E. MORIN
2021-08-09 6:23 ` Tomi Valkeinen
2021-08-10 19:39 ` Yann E. MORIN
2021-08-11 7:42 ` Tomi Valkeinen
2021-08-08 8:50 ` [Buildroot] [PATCH 1/2] package/kmsxx: remove erroneous use of static-libc option Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210808092935.GK27036@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=ps.report@gmx.net \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.