From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86509C4338F for ; Sun, 8 Aug 2021 13:49:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D8D36101D for ; Sun, 8 Aug 2021 13:49:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230155AbhHHNuQ (ORCPT ); Sun, 8 Aug 2021 09:50:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229923AbhHHNuP (ORCPT ); Sun, 8 Aug 2021 09:50:15 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6868C0613CF for ; Sun, 8 Aug 2021 06:49:56 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id pj14-20020a17090b4f4eb029017786cf98f9so25627912pjb.2 for ; Sun, 08 Aug 2021 06:49:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=0Vlv4O+CiiGfTw/zofpUFed/v1n2oDY9+Y7Uzfj16wM=; b=KYiVC2VHaB71+mhgVAfQCeIDzoIcjQDknjKITc4iiH5+k9Gm88kp8ZtojDjeBlGOUj mQKOcFpLEOiU7ietPDo9fXihVtjcUzZSHmosSIc5fzV5dPpx9FMLwlzxusrkT3dwZBLw dY5OuHrGxD9YfHbtq73Ps9FcS/XDFG5CRGWJxvkPiBrNn5iCe5Z0DFoSMBkPdLWwvrnD FtCkZ0jhnZxQHR2IX0hM8Ph4Qf9EuSWKb30dBa1YIThdKyfzWlhVL8MCxNpiewEqYW8a 5F+aQomnJnbAweXPkas5lUL5vrDJmuOvrQ2kP40TofmnSXRxzoEvYuUko3QJmHmtNXr9 rc3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0Vlv4O+CiiGfTw/zofpUFed/v1n2oDY9+Y7Uzfj16wM=; b=oORGMexzmq6n/QN7V6jm6MbaW6AWGyW3aHbyhB8CyoUw0jrULdbJ7ng3HqgDz3STjh pQDWujTVwigTnCq854EAVxjGH2/7wDy9Uqj8suNI+rcBbkUxXxSkZstxLI+XG7M0BR2a M4sWOPutsXY/bHUHO2jB4DZD0yJbBn31kj9I3Sq8RM+o5HYBa3Hb/wND/bXElTWcQCHd EXnBGXOCS8kODhJGY+BD0gbhdHkXRZ9I5KBUh54MqurxJXwHHjGismHUNACTvZp9Rov7 TNFIng58a8GxUOGxJ2FXGAL2ABbTWhQ1XW4nSd//dwVSOpYcmBtdzBpTOw4hFaD5itML dRWQ== X-Gm-Message-State: AOAM531g9VyL+rg7pAUMy7bTt/37EORHkRex7pdtFGDwZ/93HgzpMrrN +NXcbHLQ+Zv+bC2xCibxGplABg== X-Google-Smtp-Source: ABdhPJzgiNdBxlMSy7McgB8x2BvYMF00cwvkEtpi2GPLT1TEg8DH/SM0TQ9ph+jndb0I53Nrmn3pYg== X-Received: by 2002:a63:5119:: with SMTP id f25mr190692pgb.271.1628430596514; Sun, 08 Aug 2021 06:49:56 -0700 (PDT) Received: from dragon (80.251.214.228.16clouds.com. [80.251.214.228]) by smtp.gmail.com with ESMTPSA id r10sm16554406pff.7.2021.08.08.06.49.54 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 08 Aug 2021 06:49:56 -0700 (PDT) Date: Sun, 8 Aug 2021 21:49:51 +0800 From: Shawn Guo To: Sam Ravnborg Cc: Thierry Reding , Daniel Vetter , Rob Herring , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 2/2] drm/panel: Add Truly NT35521 panel driver Message-ID: <20210808134950.GC6795@dragon> References: <20210804081352.30595-1-shawn.guo@linaro.org> <20210804081352.30595-3-shawn.guo@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Sam, On Wed, Aug 04, 2021 at 06:24:12PM +0200, Sam Ravnborg wrote: > Hi Shawn, > > see a few comments in the following. Thanks for the review comments! All of them will be addressed in v2. Shawn > On Wed, Aug 04, 2021 at 04:13:52PM +0800, Shawn Guo wrote: > > It adds a drm driver for Truly NT35521 5.24" 1280x720 DSI panel, which > > can be found on Sony Xperia M4 Aqua phone. The panel backlight is > > managed through DSI link. > > > > Signed-off-by: Shawn Guo > > --- > > drivers/gpu/drm/panel/Kconfig | 9 + > > drivers/gpu/drm/panel/Makefile | 1 + > > drivers/gpu/drm/panel/panel-truly-nt35521.c | 491 ++++++++++++++++++++ > > 3 files changed, 501 insertions(+) > > create mode 100644 drivers/gpu/drm/panel/panel-truly-nt35521.c