All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin =?unknown-8bit?q?Hundeb=C3=B8ll?= <martin@geanix.com>
To: ofono@ofono.org
Subject: Re: Bug/Oversight in gatchat/gatresult.c with negative numbers
Date: Mon, 09 Aug 2021 08:40:53 +0200	[thread overview]
Message-ID: <20210809064053.hrz6b5l26mm4kgww@xps.localdomain> (raw)
In-Reply-To: <6d2dd964-db29-b092-a0e5-b4060854fae5@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 752 bytes --]

On Fri, Aug 06, 2021 at 10:02:18AM -0500, Denis Kenzior wrote:
> > Yeah ok - what name do you suggest?
> 
> So there's a few things you can do actually:
> - We do have g_at_result_next_unquoted_string.  You could try using that to
> obtain the negative <rsrp> and then just sscanf/strtol or whatever to
> convert it.
> - We also have g_at_result_iter_raw_line() which can give you the raw result
> line.  It should be trivial to come up with some sscanf magic to parse the
> result.
> - Just add a new g_at_result_iter_next_negative_number.  Or if you come up
> with a more descriptive word than negative, feel free.

I would go with g_at_result_iter_next_signed_number() to reflect that
the value isn't necessarily negative.

// Martin

      reply	other threads:[~2021-08-09  6:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-20 16:11 Bug/Oversight in gatchat/gatresult.c with negative numbers Alex J Lennon
2021-07-27 14:38 ` Denis Kenzior
2021-07-27 15:02   ` Alex J Lennon
2021-08-03  9:48   ` Alex J Lennon
2021-08-03 14:28     ` Denis Kenzior
2021-08-03 14:45       ` Alex J Lennon
2021-08-06  9:31       ` Alex J Lennon
2021-08-06 14:06       ` Alex J Lennon
2021-08-06 14:20         ` Denis Kenzior
2021-08-06 14:28           ` Alex J Lennon
2021-08-06 14:44             ` Denis Kenzior
2021-08-06 14:49               ` Alex J Lennon
2021-08-06 15:02                 ` Denis Kenzior
2021-08-09  6:40                   ` Martin =?unknown-8bit?q?Hundeb=C3=B8ll?= [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210809064053.hrz6b5l26mm4kgww@xps.localdomain \
    --to=martin@geanix.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.