All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Alexander Bulekov <alxndr@bu.edu>
Cc: Laurent Vivier <lvivier@redhat.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	Thomas Huth <thuth@redhat.com>, Qiang Liu <cyruscyliu@gmail.com>,
	Alistair Francis <alistair@alistair23.me>,
	"open list:All patches CC here" <qemu-devel@nongnu.org>,
	Bandan Das <bsd@redhat.com>,
	"open list:Xilinx ZynqMP and..." <qemu-arm@nongnu.org>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2] hw/display/xlnx_dp: fix an out-of-bounds read in xlnx_dp_read
Date: Mon, 9 Aug 2021 11:13:31 +0200	[thread overview]
Message-ID: <20210809091331.s2hy6qc566zhgg2a@sirius.home.kraxel.org> (raw)
In-Reply-To: <20210806144209.nbx4vlm6ofkza5pl@mozz.bu.edu>

  Hi,

> As a side note(not strictly related to this fix) should we continue
> joining reproducer patches with the fixes? In order to test the
> reproducer, you need to cleave the fix off the patch. At the same time
> we don't want to mess up bisection, so does it make sense to have the
> reproducer patch be separate but come last in the series?

Yes, I think it makes sense to send the testcase as separate patch, and
the ordering (fix first, testcase second) makes sense too.  If they are
separated it is easy enough to create a local test branch with a
different order, or to just temporarily revert the fix to test the
testcase.

take care,
  Gerd



  reply	other threads:[~2021-08-09  9:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-04  6:51 [PATCH v2] hw/display/xlnx_dp: fix an out-of-bounds read in xlnx_dp_read Qiang Liu
2021-08-04  7:43 ` Thomas Huth
2021-08-06  7:00   ` Qiang Liu
2021-08-06  7:09     ` Thomas Huth
2021-08-06 14:42 ` Alexander Bulekov
2021-08-09  9:13   ` Gerd Hoffmann [this message]
2021-08-09  9:24   ` Peter Maydell
2021-08-09  9:33     ` Qiang Liu
2021-08-09  9:42       ` Philippe Mathieu-Daudé
2021-08-09  9:31   ` Philippe Mathieu-Daudé
2021-08-09  9:37     ` Alexander Bulekov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210809091331.s2hy6qc566zhgg2a@sirius.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=alistair@alistair23.me \
    --cc=alxndr@bu.edu \
    --cc=bsd@redhat.com \
    --cc=cyruscyliu@gmail.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.