From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D58DC4338F for ; Mon, 9 Aug 2021 10:13:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5FB456108C for ; Mon, 9 Aug 2021 10:13:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234865AbhHIKNW (ORCPT ); Mon, 9 Aug 2021 06:13:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:54922 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234859AbhHIKNV (ORCPT ); Mon, 9 Aug 2021 06:13:21 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 633A661076; Mon, 9 Aug 2021 10:12:59 +0000 (UTC) Date: Mon, 9 Aug 2021 12:12:56 +0200 From: Christian Brauner To: David Sterba Cc: Christoph Hellwig , Chris Mason , Josef Bacik , Al Viro , linux-btrfs@vger.kernel.org, Christian Brauner Subject: Re: [PATCH v4 00/21] btrfs: support idmapped mounts Message-ID: <20210809101256.cthg6pfcvovhmjei@wittgenstein> References: <20210727104900.829215-1-brauner@kernel.org> <20210802122827.aomsh5i3rljgm2r3@wittgenstein> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210802122827.aomsh5i3rljgm2r3@wittgenstein> Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Mon, Aug 02, 2021 at 02:28:27PM +0200, Christian Brauner wrote: > On Tue, Jul 27, 2021 at 12:48:39PM +0200, Christian Brauner wrote: > > From: Christian Brauner > > > > Hey everyone, > > > > /* v4 */ > > Rename new helper to lookup_one() and add new Reviewed-bys. > > > > This series enables the creation of idmapped mounts on btrfs. On the list of > > filesystems btrfs was pretty high-up and requested quite often from userspace > > (cf. [1]). This series requires just a few changes to the vfs for specific > > lookup helpers that btrfs relies on to perform permission checking when looking > > up an inode. The changes are required to port some other filesystem as well. > > > > The conversion of the necessary btrfs internals was fairly straightforward. No > > invasive changes were needed. I've decided to split up the patchset into very > > small individual patches. This hopefully makes the series more readable and > > fairly easy to review. The overall changeset is quite small. > > > > All non-filesystem wide ioctls that peform permission checking based on inodes > > can be supported on idmapped mounts. There are really just a few restrictions. > > This should really only affect the deletion of subvolumes by subvolume id which > > can be used to delete any subvolume in the filesystem even though the caller > > might not even be able to see the subvolume under their mount. Other than that > > behavior on idmapped and non-idmapped mounts is identical for all enabled > > ioctls. People interested in idmappings on idmapped mounts should read [2]. > > > > The changeset has an associated new testsuite specific to btrfs. The > > core vfs operations that btrfs implements are covered by the generic > > idmapped mount testsuite. For the ioctls a new testsuite was added. It > > is sent alongside this patchset for ease of review but will very likely > > be merged independent of it. > > > > All patches are based on v5.14-rc3. > > > > The series can be pulled from: > > https://git.kernel.org/brauner/h/fs.idmapped.btrfs > > https://github.com/brauner/linux/tree/fs.idmapped.btrfs > > > > The xfstests can be pulled from: > > https://git.kernel.org/brauner/xfstests-dev/h/fs.idmapped.btrfs > > https://github.com/brauner/xfstests/tree/fs.idmapped.btrfs > > > > Note, the new btrfs xfstests patch is on top of a branch of mine > > containing a few more preliminary patches. So if you want to run the > > tests, please simply pull the branch and build from there. > > > > The series has been tested with xfstests including the newly added btrfs > > specific test. All tests pass. > > There were three unrelated failures that I observed: btrfs/219, > > btrfs/2020 and btrfs/235. All three also fail on earlier kernels > > without the patch series applied. > > Hey David, > > Sorry to ping, could I answer the outstanding questions you had and are > you okay with this series? I stuffed the lookup helper (and nothing else) this btrfs conversion series needs into my tree and provided it under the tag fs.idmapped.v5.15 at git://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git and merged it into my for-next. Christian