From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95D0BC432BE for ; Mon, 9 Aug 2021 11:27:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7763560F8F for ; Mon, 9 Aug 2021 11:27:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235277AbhHIL2O (ORCPT ); Mon, 9 Aug 2021 07:28:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235256AbhHIL2D (ORCPT ); Mon, 9 Aug 2021 07:28:03 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFF24C06179B for ; Mon, 9 Aug 2021 04:27:43 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id cp15-20020a17090afb8fb029017891959dcbso6123753pjb.2 for ; Mon, 09 Aug 2021 04:27:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ffo+BFghYOyiUfwtRs9Z93LC8RfNRNR6YWnTHcFyWA4=; b=HtzCFgTbZujxHFgCpuT6lhx9Xq35xX0vxduY4GYyyL9tuctz+TnYquFIa5mifGnUhY O/C7H5CU9Ssl03Vnh+XmSPGod2KGKgfz0ebYwXQjxCmIepFStIJCpbqSwb8yT51N9p41 YKFgufs0olY+BFMHDGm5M1Pk4am40Tbno9y4rmChxhaJ+rQF2oVhuub44BYfOmW2IriB aP0nkhsT4wsFR8iJDMDaN1ekfcze9ZA/EGYSNH7XOWpx5KdULmWAkhvx0TSGC0900zxH VcmeASB8ipPDqqo+pIKXPF6e++vP/7dDDE6wgtb3+yQOga67qNDi7uyV2TJzGV16PupE EL6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ffo+BFghYOyiUfwtRs9Z93LC8RfNRNR6YWnTHcFyWA4=; b=BT/rAYuhPxPyvm4A8Irhm+AnObFZjCxpH99m/lTjxg3paOiFadUB9wQ6rQLxC+udwO cUpnkQNSL/6x1SLKlPgTvfoEKRtCH3ftjqfGFzQmbSIibOg8h2Ii6wFs6/briQgdibPu DZaxkIZ6MH2lo3kv5WvDmZ/VpTaVowHoboDMnzVG8pLmixow+TWwV/iISvwP/vj4Wsim R+e6/f5ap7vVfhfqDCmuU9MWoIkI65VBqZmNon+SMKq4jpYfokblSTclFntBYtGsD/Sk k1zeO09zNl9KAg2OKoWQkv9xdNdfmGRqo9mxzQyXIuatt+DykKjUbNtioTk1Cv4ioB43 K6+A== X-Gm-Message-State: AOAM532+MN7wxnWeud6qVO/kqNccELp4+ZIig1Zxc+sdDOiPOHgzo+Z3 jt4ioNKfMmComclXhJngYV0A/g== X-Google-Smtp-Source: ABdhPJyZKOEWkzuWrpbCfIaSlK/cFovYTDHtSnY0Zu2owhEQ5lf+WOHFqQxw8aoKiDD1Y3HLoJueBw== X-Received: by 2002:a17:90a:f696:: with SMTP id cl22mr8519679pjb.124.1628508463334; Mon, 09 Aug 2021 04:27:43 -0700 (PDT) Received: from localhost ([210.0.159.74]) by smtp.gmail.com with ESMTPSA id 8sm9000578pfo.153.2021.08.09.04.27.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Aug 2021 04:27:42 -0700 (PDT) From: Leo Yan To: Arnaldo Carvalho de Melo , Peter Zijlstra , Adrian Hunter , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Will Deacon , Russell King , Catalin Marinas , Mathieu Poirier , Suzuki K Poulose , Mike Leach , John Garry , Andi Kleen , Riccardo Mancini , Jin Yao , Li Huafei , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Leo Yan Subject: [PATCH v1 3/3] perf auxtrace arm: Support compat_auxtrace_mmap__{read_head|write_tail} Date: Mon, 9 Aug 2021 19:27:27 +0800 Message-Id: <20210809112727.596876-4-leo.yan@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210809112727.596876-1-leo.yan@linaro.org> References: <20210809112727.596876-1-leo.yan@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When the tool runs with compat mode on Arm platform, the kernel is in 64-bit mode and user space is in 32-bit mode; the user space can use instructions "ldrd" and "strd" for 64-bit value atomicity. This patch adds compat_auxtrace_mmap__{read_head|write_tail} for arm building, it uses "ldrd" and "strd" instructions to ensure accessing atomicity for aux head and tail. The file arch/arm/util/auxtrace.c is built for arm and arm64 building, these two functions are not needed for arm64, so check the compiler macro "__arm__" to only include them for arm building. Signed-off-by: Leo Yan --- tools/perf/arch/arm/util/auxtrace.c | 32 +++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/tools/perf/arch/arm/util/auxtrace.c b/tools/perf/arch/arm/util/auxtrace.c index b187bddbd01a..c7c7ec0812d5 100644 --- a/tools/perf/arch/arm/util/auxtrace.c +++ b/tools/perf/arch/arm/util/auxtrace.c @@ -107,3 +107,35 @@ struct auxtrace_record *err = 0; return NULL; } + +#if defined(__arm__) +u64 compat_auxtrace_mmap__read_head(struct auxtrace_mmap *mm) +{ + struct perf_event_mmap_page *pc = mm->userpg; + u64 result; + + __asm__ __volatile__( +" ldrd %0, %H0, [%1]" + : "=&r" (result) + : "r" (&pc->aux_head), "Qo" (pc->aux_head) + ); + + return result; +} + +int compat_auxtrace_mmap__write_tail(struct auxtrace_mmap *mm, u64 tail) +{ + struct perf_event_mmap_page *pc = mm->userpg; + + /* Ensure all reads are done before we write the tail out */ + smp_mb(); + + __asm__ __volatile__( +" strd %2, %H2, [%1]" + : "=Qo" (pc->aux_tail) + : "r" (&pc->aux_tail), "r" (tail) + ); + + return 0; +} +#endif -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85F23C432BE for ; Mon, 9 Aug 2021 11:30:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 292EA6101E for ; Mon, 9 Aug 2021 11:30:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 292EA6101E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=l75yCT4x0qc49GMG45+jyT16lwCyImhYe34Mnc3EN9I=; b=Ttx8uAymp52SDR aYgX5QriXXCtdTfB7WFkBa9c/JRz3v/UfVfZuugMb90ylpmTG/vQ35fZrX2nkBHUiffSDdQoHcPnY xAe2019PMjBnGlPOOdeRcNcWQq7LKo4OeusM9nAcQKc0/hPk6HvZD7L2S4lfR7n+FAU9XA7L1XS3a nUf3vaeslndhomOKCbgP/tEbfAr5GILUWlh0gjW4jwzz9ApdEl4ewEq47y92IZc7dqPzb9cdyWMN9 vPeDI9NGSG0FErz4MrMMSsWxa4w0hOJdZnr2BXPD2iji+9kNdL0pgFLIfZkyp2hpcQ378n5zphxZE bvlqI0krvnZDQ73b9gag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mD3S3-000MOU-Jl; Mon, 09 Aug 2021 11:28:15 +0000 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mD3RX-000MIb-Qf for linux-arm-kernel@lists.infradead.org; Mon, 09 Aug 2021 11:27:45 +0000 Received: by mail-pj1-x102e.google.com with SMTP id mq2-20020a17090b3802b0290178911d298bso6665662pjb.1 for ; Mon, 09 Aug 2021 04:27:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ffo+BFghYOyiUfwtRs9Z93LC8RfNRNR6YWnTHcFyWA4=; b=HtzCFgTbZujxHFgCpuT6lhx9Xq35xX0vxduY4GYyyL9tuctz+TnYquFIa5mifGnUhY O/C7H5CU9Ssl03Vnh+XmSPGod2KGKgfz0ebYwXQjxCmIepFStIJCpbqSwb8yT51N9p41 YKFgufs0olY+BFMHDGm5M1Pk4am40Tbno9y4rmChxhaJ+rQF2oVhuub44BYfOmW2IriB aP0nkhsT4wsFR8iJDMDaN1ekfcze9ZA/EGYSNH7XOWpx5KdULmWAkhvx0TSGC0900zxH VcmeASB8ipPDqqo+pIKXPF6e++vP/7dDDE6wgtb3+yQOga67qNDi7uyV2TJzGV16PupE EL6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ffo+BFghYOyiUfwtRs9Z93LC8RfNRNR6YWnTHcFyWA4=; b=G15HdIp26K7cR6jmnUZ8LA4oeklvDUWFprevjzaychPCuBS0AY4aV95gs7wX9GcpvH HWQnSGLZVfor4vyUfv27FfmLLQ6UxDtOVB0MaNIR7UwcpVTu3XZFPCnuArB8n+46V4Fo 847W9sQrnjOpLLE5c2IvAYJ+Mtf/6FW1nSAK7zcJKH5uMk8yLJ14qskEQYR1tKP+ghgV iUVAEgRVEc0tXIGsI6x6jI5D96AWdvK+d5OFrpJVfIm9j2jKRyqkbjBWIKZWBZ5Hpkne gJvioVu8nK+5ly5vcQ84nMI8Z6nt27O/fFdeTFDPIApMYq22eznViPiPkaTs6mR6S90T g9eg== X-Gm-Message-State: AOAM530RtfkcJtH+hEp8KqWeWazT5UPPd5jBC93fXxj4jcbnAXUcNCRb KAECMKpQa+sYIQeijAt2jS10Xg== X-Google-Smtp-Source: ABdhPJyZKOEWkzuWrpbCfIaSlK/cFovYTDHtSnY0Zu2owhEQ5lf+WOHFqQxw8aoKiDD1Y3HLoJueBw== X-Received: by 2002:a17:90a:f696:: with SMTP id cl22mr8519679pjb.124.1628508463334; Mon, 09 Aug 2021 04:27:43 -0700 (PDT) Received: from localhost ([210.0.159.74]) by smtp.gmail.com with ESMTPSA id 8sm9000578pfo.153.2021.08.09.04.27.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Aug 2021 04:27:42 -0700 (PDT) From: Leo Yan To: Arnaldo Carvalho de Melo , Peter Zijlstra , Adrian Hunter , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Will Deacon , Russell King , Catalin Marinas , Mathieu Poirier , Suzuki K Poulose , Mike Leach , John Garry , Andi Kleen , Riccardo Mancini , Jin Yao , Li Huafei , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Leo Yan Subject: [PATCH v1 3/3] perf auxtrace arm: Support compat_auxtrace_mmap__{read_head|write_tail} Date: Mon, 9 Aug 2021 19:27:27 +0800 Message-Id: <20210809112727.596876-4-leo.yan@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210809112727.596876-1-leo.yan@linaro.org> References: <20210809112727.596876-1-leo.yan@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210809_042743_936989_75F4FFA2 X-CRM114-Status: GOOD ( 16.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When the tool runs with compat mode on Arm platform, the kernel is in 64-bit mode and user space is in 32-bit mode; the user space can use instructions "ldrd" and "strd" for 64-bit value atomicity. This patch adds compat_auxtrace_mmap__{read_head|write_tail} for arm building, it uses "ldrd" and "strd" instructions to ensure accessing atomicity for aux head and tail. The file arch/arm/util/auxtrace.c is built for arm and arm64 building, these two functions are not needed for arm64, so check the compiler macro "__arm__" to only include them for arm building. Signed-off-by: Leo Yan --- tools/perf/arch/arm/util/auxtrace.c | 32 +++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/tools/perf/arch/arm/util/auxtrace.c b/tools/perf/arch/arm/util/auxtrace.c index b187bddbd01a..c7c7ec0812d5 100644 --- a/tools/perf/arch/arm/util/auxtrace.c +++ b/tools/perf/arch/arm/util/auxtrace.c @@ -107,3 +107,35 @@ struct auxtrace_record *err = 0; return NULL; } + +#if defined(__arm__) +u64 compat_auxtrace_mmap__read_head(struct auxtrace_mmap *mm) +{ + struct perf_event_mmap_page *pc = mm->userpg; + u64 result; + + __asm__ __volatile__( +" ldrd %0, %H0, [%1]" + : "=&r" (result) + : "r" (&pc->aux_head), "Qo" (pc->aux_head) + ); + + return result; +} + +int compat_auxtrace_mmap__write_tail(struct auxtrace_mmap *mm, u64 tail) +{ + struct perf_event_mmap_page *pc = mm->userpg; + + /* Ensure all reads are done before we write the tail out */ + smp_mb(); + + __asm__ __volatile__( +" strd %2, %H2, [%1]" + : "=Qo" (pc->aux_tail) + : "r" (&pc->aux_tail), "r" (tail) + ); + + return 0; +} +#endif -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel