All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shreyansh Chouhan <chouhan.shreyansh630@gmail.com>
To: herbert@gondor.apana.org.au, davem@davemloft.net,
	tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	x86@kernel.org, hpa@zytor.com, ardb@kernel.org
Cc: Shreyansh Chouhan <chouhan.shreyansh630@gmail.com>,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	syzbot+20191dc583eff8602d2d@syzkaller.appspotmail.com
Subject: [PATCH] crypto: xts_crypt() return if walk.nbytes is 0
Date: Mon,  9 Aug 2021 19:40:27 +0530	[thread overview]
Message-ID: <20210809141027.860850-1-chouhan.shreyansh630@gmail.com> (raw)
In-Reply-To: <YQ0Qm+Xs1g/7Eant@fedora>

xts_crypt() code doesn't call kernel_fpu_end() after calling
kernel_fpu_begin() if walk.nbytes is 0. The correct behavior should be
not calling kernel_fpu_begin() if walk.nbytes is 0.

Reported-by: syzbot+20191dc583eff8602d2d@syzkaller.appspotmail.com
Signed-off-by: Shreyansh Chouhan <chouhan.shreyansh630@gmail.com>
---
 arch/x86/crypto/aesni-intel_glue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/crypto/aesni-intel_glue.c b/arch/x86/crypto/aesni-intel_glue.c
index 388643ca2177..ec6eac57c493 100644
--- a/arch/x86/crypto/aesni-intel_glue.c
+++ b/arch/x86/crypto/aesni-intel_glue.c
@@ -849,7 +849,7 @@ static int xts_crypt(struct skcipher_request *req, bool encrypt)
 		return -EINVAL;
 
 	err = skcipher_walk_virt(&walk, req, false);
-	if (err)
+	if (err || !walk.nbytes)
 		return err;
 
 	if (unlikely(tail > 0 && walk.nbytes < walk.total)) {
-- 
2.31.1


  reply	other threads:[~2021-08-09 14:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-30 13:41 [PATCH] crypto: add missing kernel_fpu_end() call Shreyansh Chouhan
2021-08-06  8:23 ` Herbert Xu
2021-08-06  9:05   ` Ard Biesheuvel
2021-08-06  9:07     ` Ard Biesheuvel
2021-08-06 10:36       ` Shreyansh Chouhan
2021-08-09 14:10         ` Shreyansh Chouhan [this message]
2021-08-17 14:18           ` [PATCH] crypto: xts_crypt() return if walk.nbytes is 0 Ard Biesheuvel
2021-08-20  8:31           ` Herbert Xu
2021-08-20 11:14             ` Ard Biesheuvel
2021-08-20 12:53               ` Herbert Xu
2021-08-22  3:45                 ` [PATCH v2] " Shreyansh Chouhan
2021-08-27  8:38                   ` Herbert Xu
2021-08-22  3:48                 ` [PATCH] " Shreyansh Chouhan
2021-08-22 13:23                 ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210809141027.860850-1-chouhan.shreyansh630@gmail.com \
    --to=chouhan.shreyansh630@gmail.com \
    --cc=ardb@kernel.org \
    --cc=bp@alien8.de \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=hpa@zytor.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=syzbot+20191dc583eff8602d2d@syzkaller.appspotmail.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.