All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Straube <straube.linux@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Michael Straube <straube.linux@gmail.com>
Subject: [PATCH v2 08/17] staging: r8188eu: clean up comparsions to true/false
Date: Mon,  9 Aug 2021 18:49:58 +0200	[thread overview]
Message-ID: <20210809165007.23204-9-straube.linux@gmail.com> (raw)
In-Reply-To: <20210809165007.23204-1-straube.linux@gmail.com>

Clean up some comparsions to true/false to clear chackpatch warnings.

WARNING: Unnecessary parentheses - maybe == should be = ?

Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
 drivers/staging/r8188eu/core/rtw_ioctl_set.c | 4 ++--
 drivers/staging/r8188eu/core/rtw_mlme.c      | 2 +-
 drivers/staging/r8188eu/core/rtw_xmit.c      | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/r8188eu/core/rtw_ioctl_set.c b/drivers/staging/r8188eu/core/rtw_ioctl_set.c
index 1a4227729e0d..41c14a4cff1f 100644
--- a/drivers/staging/r8188eu/core/rtw_ioctl_set.c
+++ b/drivers/staging/r8188eu/core/rtw_ioctl_set.c
@@ -166,7 +166,7 @@ u8 rtw_set_802_11_bssid(struct adapter *padapter, u8 *bssid)
 
 			rtw_free_assoc_resources(padapter, 1);
 
-			if ((check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) == true)) {
+			if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE)) {
 				_clr_fwstate_(pmlmepriv, WIFI_ADHOC_MASTER_STATE);
 				set_fwstate(pmlmepriv, WIFI_ADHOC_STATE);
 			}
@@ -231,7 +231,7 @@ u8 rtw_set_802_11_ssid(struct adapter *padapter, struct ndis_802_11_ssid *ssid)
 	if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE)) {
 		if ((pmlmepriv->assoc_ssid.SsidLength == ssid->SsidLength) &&
 		    (!memcmp(&pmlmepriv->assoc_ssid.Ssid, ssid->Ssid, ssid->SsidLength))) {
-			if ((check_fwstate(pmlmepriv, WIFI_STATION_STATE) == false)) {
+			if (!check_fwstate(pmlmepriv, WIFI_STATION_STATE)) {
 				if (!rtw_is_same_ibss(padapter, pnetwork)) {
 					/* if in WIFI_ADHOC_MASTER_STATE | WIFI_ADHOC_STATE, create bss or rejoin again */
 					rtw_disassoc_cmd(padapter, 0, true);
diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r8188eu/core/rtw_mlme.c
index 4768d3ef350e..f28c30a6efb0 100644
--- a/drivers/staging/r8188eu/core/rtw_mlme.c
+++ b/drivers/staging/r8188eu/core/rtw_mlme.c
@@ -748,7 +748,7 @@ void rtw_surveydone_event_callback(struct adapter	*adapter, u8 *pbuf)
 	rtw_set_signal_stat_timer(&adapter->recvpriv);
 
 	if (pmlmepriv->to_join) {
-		if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) == true)) {
+		if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) {
 			if (check_fwstate(pmlmepriv, _FW_LINKED) == false) {
 				set_fwstate(pmlmepriv, _FW_UNDER_LINKING);
 
diff --git a/drivers/staging/r8188eu/core/rtw_xmit.c b/drivers/staging/r8188eu/core/rtw_xmit.c
index 0a755d7b8f19..018ee20553dd 100644
--- a/drivers/staging/r8188eu/core/rtw_xmit.c
+++ b/drivers/staging/r8188eu/core/rtw_xmit.c
@@ -740,7 +740,7 @@ s32 rtw_make_wlanhdr (struct adapter *padapter, u8 *hdr, struct pkt_attrib *patt
 	SetFrameSubType(fctrl, pattrib->subtype);
 
 	if (pattrib->subtype & WIFI_DATA_TYPE) {
-		if ((check_fwstate(pmlmepriv,  WIFI_STATION_STATE) == true)) {
+		if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) {
 			/* to_ds = 1, fr_ds = 0; */
 			/* Data transfer to AP */
 			SetToDs(fctrl);
-- 
2.32.0


  parent reply	other threads:[~2021-08-09 16:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-09 16:49 [PATCH v2 00/17] staging: r8188eu: remove unnecessary parentheses Michael Straube
2021-08-09 16:49 ` [PATCH v2 01/17] staging: r8188eu: remove unnecessary parentheses in os_dep dir Michael Straube
2021-08-09 16:49 ` [PATCH v2 02/17] staging: r8188eu: remove unnecessary parentheses in hal dir Michael Straube
2021-08-09 16:49 ` [PATCH v2 03/17] staging: r8188eu: remove unnecessary parentheses in core/rtw_mlme_ext.c Michael Straube
2021-08-09 16:49 ` [PATCH v2 04/17] staging: r8188eu: remove unnecessary parentheses in core/rtw_ap.c Michael Straube
2021-08-09 16:49 ` [PATCH v2 05/17] staging: r8188eu: remove unnecessary parentheses in core/rtw_wlan_util.c Michael Straube
2021-08-09 16:49 ` [PATCH v2 06/17] staging: r8188eu: remove unnecessary parentheses in core/rtw_led.c Michael Straube
2021-08-09 16:49 ` [PATCH v2 07/17] staging: r8188eu: remove unnecessary parentheses in core/rtw_p2p.c Michael Straube
2021-08-09 16:49 ` Michael Straube [this message]
2021-08-09 16:49 ` [PATCH v2 09/17] staging: r8188eu: remove unnecessary parentheses in core/rtw_mlme.c Michael Straube
2021-08-09 16:50 ` [PATCH v2 10/17] staging: r8188eu: remove unnecessary parentheses in core/rtw_xmit.c Michael Straube
2021-08-09 16:50 ` [PATCH v2 11/17] staging: r8188eu: remove unnecessary parentheses in core/rtw_sta_mgt.c Michael Straube
2021-08-09 16:50 ` [PATCH v2 12/17] staging: r8188eu: remove unnecessary parentheses in core/rtw_recv.c Michael Straube
2021-08-09 16:50 ` [PATCH v2 13/17] staging: r8188eu: remove unnecessary parentheses in core/rtw_pwrctrl.c Michael Straube
2021-08-09 16:50 ` [PATCH v2 14/17] staging: r8188eu: remove unnecessary parentheses in core/rtw_io.c Michael Straube
2021-08-09 16:50 ` [PATCH v2 15/17] staging: r8188eu: remove unnecessary parentheses in core/rtw_ioctl_set.c Michael Straube
2021-08-09 16:50 ` [PATCH v2 16/17] staging: r8188eu: remove unnecessary parentheses in core/rtw_cmd.c Michael Straube
2021-08-09 16:50 ` [PATCH v2 17/17] staging: r8188eu: remove remaining unnecessary parentheses in core dir Michael Straube

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210809165007.23204-9-straube.linux@gmail.com \
    --to=straube.linux@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=phil@philpotter.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.