From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-leds-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 70E47C4338F
	for <linux-leds@archiver.kernel.org>; Mon,  9 Aug 2021 19:07:29 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 4D49961052
	for <linux-leds@archiver.kernel.org>; Mon,  9 Aug 2021 19:07:29 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S235742AbhHITHt (ORCPT <rfc822;linux-leds@archiver.kernel.org>);
        Mon, 9 Aug 2021 15:07:49 -0400
Received: from mail.kernel.org ([198.145.29.99]:41904 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S235246AbhHITHt (ORCPT <rfc822;linux-leds@vger.kernel.org>);
        Mon, 9 Aug 2021 15:07:49 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id E5EC361040;
        Mon,  9 Aug 2021 19:07:27 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1628536048;
        bh=dQLZBpWmjY9hF80ib8i/Bo1GvGxr7yInqT/ZPREo94U=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=gJGBxEID1am/fcjOi5RGO5uFDE15kZBlWJ5shTR3yNpJIinQU/t7TshNpc/56g7q8
         7AWpkG8R4MMyNz3PtrMfzlclrD0PHuOVv6pXdztpk33xYPBfCUDbV8MYNMxLfeU3ov
         SOTq0is9yl9aAOb3+xq6m4lR4W1LVc9QDUPBmTJ6rT6GW+126+KDCuNvxnJlHK7g4c
         rRJKN2WR8wb3xbOMMkGn3+NkWmWStHzigAriRJXTFq6YczUcOIGPMNWapF9ftRsR8+
         Syvkzs98bFThjc7oqef5wpKh9pLLZLsAGexKHn6QG/QFgMy3cpehsU3yayKgUYX/TA
         7THDrUkH7Zrtw==
Received: by pali.im (Postfix)
        id 5C6C8C7C; Mon,  9 Aug 2021 21:07:25 +0200 (CEST)
Date:   Mon, 9 Aug 2021 21:07:25 +0200
From:   Pali =?utf-8?B?Um9ow6Fy?= <pali@kernel.org>
To:     Marek =?utf-8?B?QmVow7pu?= <kabel@kernel.org>
Cc:     Ian Pilcher <arequipeno@gmail.com>, linux-block@vger.kernel.org,
        linux-leds@vger.kernel.org, axboe@kernel.dk, pavel@ucw.cz,
        linux-kernel@vger.kernel.org, kernelnewbies@kernelnewbies.org
Subject: Re: [RFC PATCH v2 00/10] Add configurable block device LED triggers
Message-ID: <20210809190725.6jq2npa5kmruf6n7@pali>
References: <20210809033217.1113444-1-arequipeno@gmail.com>
 <20210809205633.4300bbea@thinkpad>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20210809205633.4300bbea@thinkpad>
User-Agent: NeoMutt/20180716
Precedence: bulk
List-ID: <linux-leds.vger.kernel.org>
X-Mailing-List: linux-leds@vger.kernel.org

On Monday 09 August 2021 20:56:33 Marek Behún wrote:
> Hello Ian,
> 
> thank you for your proposal. Some comments below:
> 
> On Sun,  8 Aug 2021 22:32:07 -0500
> Ian Pilcher <arequipeno@gmail.com> wrote:
> 
> > One thing that has not changed is that associations between block
> > devices and LEDs are still set via an attribute on the device, rather
> > than the LED.  This is much simpler, as the device attribute only has
> > to handle a single value (the name of the associated LED), rather than
> > potentially handling multiple device names.
> 
> It may be simpler, but it is in contrast to how the netdev trigger
> works, which already is in upstream for many years. I really think we
> should try to have similar sysfs ABIs here. (I understand that the
> netdev trigger is currently unable to handle multiple network
> interfaces - but it is possible to extend it so.)
> 
> > I have modeled the interface for the /sys/block/<DEVICE>/led
> > attribute on the sysfs interface used for selecting a trigger.  All
> > available LEDs (all LEDs associated with the blkdev trigger) are
> > shown when the attribute is read, with the currently selected LED
> > enclosed in square brackets ([]).
> 
> I think it is reasonable to be able to set something like this:
>   led0 : blink on activity on any of [sda, sdb, sdc]
>   led1 : blink on activity on sda
>   led2 : blink on activity on sdb
>   led3 : blink on activity on sdc
> 
> If I am reading your code correctly, it looks that only one LED can be
> configured for a block device. Is this true? If so, then the above
> configuration cannot be set.
> 
> Also you are blinking the LED on any request to the block device. I
> would rather expect to be able to set the LED to blink on read and on
> write. (And possibly on other functions, like discard, or critical
> temperature, or error, ...) I would like to know what other people
> think about this.

Hello!

HP EliteBook laptops had dedicated LED for some kind of error and
encryption indication. And there is kernel acpi/wmi driver which can
control this LED. I do not know if recent HP laptops still have these
LEDs, but I would suggest to design API in a way that would allow to use
these dedicated LEDs for their original "vendor" purpose.

I'm mentioning it just because this functionality and design is already
on existing production mainstream laptops, and not something imaginary.

If Linux distributions are still cooperating with laptop vendors and
doing "official" Linux preloads then they may be interested in having
"native" LED functionality support in kernel.

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=2Cvj=ND=kernelnewbies.org=kernelnewbies-bounces@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID,
	DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,
	USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 92546C4338F
	for <kernelnewbies@archiver.kernel.org>; Thu, 12 Aug 2021 16:28:09 +0000 (UTC)
Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mail.kernel.org (Postfix) with ESMTPS id D6CC56104F
	for <kernelnewbies@archiver.kernel.org>; Thu, 12 Aug 2021 16:28:08 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D6CC56104F
Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org
Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernelnewbies.org
Received: from localhost ([::1] helo=shelob.surriel.com)
	by shelob.surriel.com with esmtp (Exim 4.94.2)
	(envelope-from <kernelnewbies-bounces@kernelnewbies.org>)
	id 1mEDYa-00048R-NO; Thu, 12 Aug 2021 12:27:48 -0400
Received: from mail.kernel.org ([198.145.29.99])
 by shelob.surriel.com with esmtps (TLS1.2) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2)
 (envelope-from <pali@kernel.org>) id 1mDAcV-0002G5-9i
 for kernelnewbies@kernelnewbies.org; Mon, 09 Aug 2021 15:07:31 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id E5EC361040;
 Mon,  9 Aug 2021 19:07:27 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
 s=k20201202; t=1628536048;
 bh=dQLZBpWmjY9hF80ib8i/Bo1GvGxr7yInqT/ZPREo94U=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=gJGBxEID1am/fcjOi5RGO5uFDE15kZBlWJ5shTR3yNpJIinQU/t7TshNpc/56g7q8
 7AWpkG8R4MMyNz3PtrMfzlclrD0PHuOVv6pXdztpk33xYPBfCUDbV8MYNMxLfeU3ov
 SOTq0is9yl9aAOb3+xq6m4lR4W1LVc9QDUPBmTJ6rT6GW+126+KDCuNvxnJlHK7g4c
 rRJKN2WR8wb3xbOMMkGn3+NkWmWStHzigAriRJXTFq6YczUcOIGPMNWapF9ftRsR8+
 Syvkzs98bFThjc7oqef5wpKh9pLLZLsAGexKHn6QG/QFgMy3cpehsU3yayKgUYX/TA
 7THDrUkH7Zrtw==
Received: by pali.im (Postfix)
 id 5C6C8C7C; Mon,  9 Aug 2021 21:07:25 +0200 (CEST)
Date: Mon, 9 Aug 2021 21:07:25 +0200
From: Pali =?utf-8?B?Um9ow6Fy?= <pali@kernel.org>
To: Marek =?utf-8?B?QmVow7pu?= <kabel@kernel.org>
Subject: Re: [RFC PATCH v2 00/10] Add configurable block device LED triggers
Message-ID: <20210809190725.6jq2npa5kmruf6n7@pali>
References: <20210809033217.1113444-1-arequipeno@gmail.com>
 <20210809205633.4300bbea@thinkpad>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20210809205633.4300bbea@thinkpad>
User-Agent: NeoMutt/20180716
X-Mailman-Approved-At: Thu, 12 Aug 2021 12:27:42 -0400
Cc: axboe@kernel.dk, kernelnewbies@kernelnewbies.org,
 Ian Pilcher <arequipeno@gmail.com>, linux-kernel@vger.kernel.org,
 linux-block@vger.kernel.org, pavel@ucw.cz, linux-leds@vger.kernel.org
X-BeenThere: kernelnewbies@kernelnewbies.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Learn about the Linux kernel <kernelnewbies.kernelnewbies.org>
List-Unsubscribe: <https://lists.kernelnewbies.org/mailman/options/kernelnewbies>, 
 <mailto:kernelnewbies-request@kernelnewbies.org?subject=unsubscribe>
List-Archive: <http://lists.kernelnewbies.org/pipermail/kernelnewbies/>
List-Post: <mailto:kernelnewbies@kernelnewbies.org>
List-Help: <mailto:kernelnewbies-request@kernelnewbies.org?subject=help>
List-Subscribe: <https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies>, 
 <mailto:kernelnewbies-request@kernelnewbies.org?subject=subscribe>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Errors-To: kernelnewbies-bounces@kernelnewbies.org

T24gTW9uZGF5IDA5IEF1Z3VzdCAyMDIxIDIwOjU2OjMzIE1hcmVrIEJlaMO6biB3cm90ZToKPiBI
ZWxsbyBJYW4sCj4gCj4gdGhhbmsgeW91IGZvciB5b3VyIHByb3Bvc2FsLiBTb21lIGNvbW1lbnRz
IGJlbG93Ogo+IAo+IE9uIFN1biwgIDggQXVnIDIwMjEgMjI6MzI6MDcgLTA1MDAKPiBJYW4gUGls
Y2hlciA8YXJlcXVpcGVub0BnbWFpbC5jb20+IHdyb3RlOgo+IAo+ID4gT25lIHRoaW5nIHRoYXQg
aGFzIG5vdCBjaGFuZ2VkIGlzIHRoYXQgYXNzb2NpYXRpb25zIGJldHdlZW4gYmxvY2sKPiA+IGRl
dmljZXMgYW5kIExFRHMgYXJlIHN0aWxsIHNldCB2aWEgYW4gYXR0cmlidXRlIG9uIHRoZSBkZXZp
Y2UsIHJhdGhlcgo+ID4gdGhhbiB0aGUgTEVELiAgVGhpcyBpcyBtdWNoIHNpbXBsZXIsIGFzIHRo
ZSBkZXZpY2UgYXR0cmlidXRlIG9ubHkgaGFzCj4gPiB0byBoYW5kbGUgYSBzaW5nbGUgdmFsdWUg
KHRoZSBuYW1lIG9mIHRoZSBhc3NvY2lhdGVkIExFRCksIHJhdGhlciB0aGFuCj4gPiBwb3RlbnRp
YWxseSBoYW5kbGluZyBtdWx0aXBsZSBkZXZpY2UgbmFtZXMuCj4gCj4gSXQgbWF5IGJlIHNpbXBs
ZXIsIGJ1dCBpdCBpcyBpbiBjb250cmFzdCB0byBob3cgdGhlIG5ldGRldiB0cmlnZ2VyCj4gd29y
a3MsIHdoaWNoIGFscmVhZHkgaXMgaW4gdXBzdHJlYW0gZm9yIG1hbnkgeWVhcnMuIEkgcmVhbGx5
IHRoaW5rIHdlCj4gc2hvdWxkIHRyeSB0byBoYXZlIHNpbWlsYXIgc3lzZnMgQUJJcyBoZXJlLiAo
SSB1bmRlcnN0YW5kIHRoYXQgdGhlCj4gbmV0ZGV2IHRyaWdnZXIgaXMgY3VycmVudGx5IHVuYWJs
ZSB0byBoYW5kbGUgbXVsdGlwbGUgbmV0d29yawo+IGludGVyZmFjZXMgLSBidXQgaXQgaXMgcG9z
c2libGUgdG8gZXh0ZW5kIGl0IHNvLikKPiAKPiA+IEkgaGF2ZSBtb2RlbGVkIHRoZSBpbnRlcmZh
Y2UgZm9yIHRoZSAvc3lzL2Jsb2NrLzxERVZJQ0U+L2xlZAo+ID4gYXR0cmlidXRlIG9uIHRoZSBz
eXNmcyBpbnRlcmZhY2UgdXNlZCBmb3Igc2VsZWN0aW5nIGEgdHJpZ2dlci4gIEFsbAo+ID4gYXZh
aWxhYmxlIExFRHMgKGFsbCBMRURzIGFzc29jaWF0ZWQgd2l0aCB0aGUgYmxrZGV2IHRyaWdnZXIp
IGFyZQo+ID4gc2hvd24gd2hlbiB0aGUgYXR0cmlidXRlIGlzIHJlYWQsIHdpdGggdGhlIGN1cnJl
bnRseSBzZWxlY3RlZCBMRUQKPiA+IGVuY2xvc2VkIGluIHNxdWFyZSBicmFja2V0cyAoW10pLgo+
IAo+IEkgdGhpbmsgaXQgaXMgcmVhc29uYWJsZSB0byBiZSBhYmxlIHRvIHNldCBzb21ldGhpbmcg
bGlrZSB0aGlzOgo+ICAgbGVkMCA6IGJsaW5rIG9uIGFjdGl2aXR5IG9uIGFueSBvZiBbc2RhLCBz
ZGIsIHNkY10KPiAgIGxlZDEgOiBibGluayBvbiBhY3Rpdml0eSBvbiBzZGEKPiAgIGxlZDIgOiBi
bGluayBvbiBhY3Rpdml0eSBvbiBzZGIKPiAgIGxlZDMgOiBibGluayBvbiBhY3Rpdml0eSBvbiBz
ZGMKPiAKPiBJZiBJIGFtIHJlYWRpbmcgeW91ciBjb2RlIGNvcnJlY3RseSwgaXQgbG9va3MgdGhh
dCBvbmx5IG9uZSBMRUQgY2FuIGJlCj4gY29uZmlndXJlZCBmb3IgYSBibG9jayBkZXZpY2UuIElz
IHRoaXMgdHJ1ZT8gSWYgc28sIHRoZW4gdGhlIGFib3ZlCj4gY29uZmlndXJhdGlvbiBjYW5ub3Qg
YmUgc2V0Lgo+IAo+IEFsc28geW91IGFyZSBibGlua2luZyB0aGUgTEVEIG9uIGFueSByZXF1ZXN0
IHRvIHRoZSBibG9jayBkZXZpY2UuIEkKPiB3b3VsZCByYXRoZXIgZXhwZWN0IHRvIGJlIGFibGUg
dG8gc2V0IHRoZSBMRUQgdG8gYmxpbmsgb24gcmVhZCBhbmQgb24KPiB3cml0ZS4gKEFuZCBwb3Nz
aWJseSBvbiBvdGhlciBmdW5jdGlvbnMsIGxpa2UgZGlzY2FyZCwgb3IgY3JpdGljYWwKPiB0ZW1w
ZXJhdHVyZSwgb3IgZXJyb3IsIC4uLikgSSB3b3VsZCBsaWtlIHRvIGtub3cgd2hhdCBvdGhlciBw
ZW9wbGUKPiB0aGluayBhYm91dCB0aGlzLgoKSGVsbG8hCgpIUCBFbGl0ZUJvb2sgbGFwdG9wcyBo
YWQgZGVkaWNhdGVkIExFRCBmb3Igc29tZSBraW5kIG9mIGVycm9yIGFuZAplbmNyeXB0aW9uIGlu
ZGljYXRpb24uIEFuZCB0aGVyZSBpcyBrZXJuZWwgYWNwaS93bWkgZHJpdmVyIHdoaWNoIGNhbgpj
b250cm9sIHRoaXMgTEVELiBJIGRvIG5vdCBrbm93IGlmIHJlY2VudCBIUCBsYXB0b3BzIHN0aWxs
IGhhdmUgdGhlc2UKTEVEcywgYnV0IEkgd291bGQgc3VnZ2VzdCB0byBkZXNpZ24gQVBJIGluIGEg
d2F5IHRoYXQgd291bGQgYWxsb3cgdG8gdXNlCnRoZXNlIGRlZGljYXRlZCBMRURzIGZvciB0aGVp
ciBvcmlnaW5hbCAidmVuZG9yIiBwdXJwb3NlLgoKSSdtIG1lbnRpb25pbmcgaXQganVzdCBiZWNh
dXNlIHRoaXMgZnVuY3Rpb25hbGl0eSBhbmQgZGVzaWduIGlzIGFscmVhZHkKb24gZXhpc3Rpbmcg
cHJvZHVjdGlvbiBtYWluc3RyZWFtIGxhcHRvcHMsIGFuZCBub3Qgc29tZXRoaW5nIGltYWdpbmFy
eS4KCklmIExpbnV4IGRpc3RyaWJ1dGlvbnMgYXJlIHN0aWxsIGNvb3BlcmF0aW5nIHdpdGggbGFw
dG9wIHZlbmRvcnMgYW5kCmRvaW5nICJvZmZpY2lhbCIgTGludXggcHJlbG9hZHMgdGhlbiB0aGV5
IG1heSBiZSBpbnRlcmVzdGVkIGluIGhhdmluZwoibmF0aXZlIiBMRUQgZnVuY3Rpb25hbGl0eSBz
dXBwb3J0IGluIGtlcm5lbC4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fCktlcm5lbG5ld2JpZXMgbWFpbGluZyBsaXN0Cktlcm5lbG5ld2JpZXNAa2VybmVs
bmV3Ymllcy5vcmcKaHR0cHM6Ly9saXN0cy5rZXJuZWxuZXdiaWVzLm9yZy9tYWlsbWFuL2xpc3Rp
bmZvL2tlcm5lbG5ld2JpZXMK