All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Stern <stern@rowland.harvard.edu>
To: Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: linux-usb@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Felipe Balbi <balbi@kernel.org>
Subject: Re: [PATCH v2 5/9] usb: host: ohci-tmio: add IRQ check
Date: Mon, 9 Aug 2021 16:54:38 -0400	[thread overview]
Message-ID: <20210809205438.GA560062@rowland.harvard.edu> (raw)
In-Reply-To: <9bfa4edb-6852-d948-3f57-9c486e79a208@omp.ru>

On Mon, Aug 09, 2021 at 11:41:59PM +0300, Sergey Shtylyov wrote:
> The driver neglects to check the  result of platform_get_irq()'s call and
> blithely passes the negative error codes to usb_add_hcd() (which takes
> *unsigned* IRQ #), causing request_irq() that it calls to fail with
> -EINVAL, overriding an original error code. Stop calling usb_add_hcd()
> with the invalid IRQ #s.
> 
> Fixes: 78c73414f4f6 ("USB: ohci: add support for tmio-ohci cell")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> 
> ---
>  drivers/usb/host/ohci-tmio.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> Index: usb/drivers/usb/host/ohci-tmio.c
> ===================================================================
> --- usb.orig/drivers/usb/host/ohci-tmio.c
> +++ usb/drivers/usb/host/ohci-tmio.c
> @@ -242,6 +242,8 @@ static int ohci_hcd_tmio_drv_probe(struc
>  	if (ret < 0)
>  		goto err_enable;
>  
> +	if (irq < 0)
> +		goto err_enable;
>  	ret = usb_add_hcd(hcd, irq, 0);
>  	if (ret)
>  		goto err_add_hcd;

Surely this test should be placed near the start of the function, before 
the call to usb_create_hcd().  There's no point in doing all the extra 
work if the irq value is already invalid.

Alan Stern

  reply	other threads:[~2021-08-09 20:54 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-09 20:16 [PATCH v2 0/9] Stop calling request_irq(), etc. with invalid IRQs in the USB drivers Sergey Shtylyov
2021-08-09 20:21 ` [PATCH v2 1/9] usb: dwc3: meson-g12a: add IRQ check Sergey Shtylyov
2021-08-09 20:21   ` Sergey Shtylyov
2021-08-09 20:21   ` Sergey Shtylyov
2021-08-09 20:23 ` [PATCH v2 2/9] usb: dwc3: qcom: " Sergey Shtylyov
2021-08-09 20:27 ` [PATCH v2 3/6] usb: gadget: udc: at91: " Sergey Shtylyov
2021-08-09 20:27   ` Sergey Shtylyov
2021-08-09 20:35 ` [PATCH v2 4/9] usb: gadget: udc: s3c2410: " Sergey Shtylyov
2021-08-09 20:35   ` Sergey Shtylyov
2021-08-10  6:53   ` Krzysztof Kozlowski
2021-08-10  6:53     ` Krzysztof Kozlowski
2021-08-12  5:40   ` Felipe Balbi
2021-08-12  5:40     ` Felipe Balbi
2021-08-09 20:41 ` [PATCH v2 5/9] usb: host: ohci-tmio: " Sergey Shtylyov
2021-08-09 20:54   ` Alan Stern [this message]
2021-08-09 20:45 ` [PATCH v2 6/9] usb: misc: brcmstb-usb-pinmap: " Sergey Shtylyov
2021-08-09 20:45   ` Sergey Shtylyov
2021-08-10  9:51   ` Florian Fainelli
2021-08-10  9:51     ` Florian Fainelli
2021-08-09 20:50 ` [PATCH v2 7/9] usb: phy: fsl-usb: " Sergey Shtylyov
2021-08-09 20:50   ` Sergey Shtylyov
2021-08-12  5:38   ` Felipe Balbi
2021-08-12  5:38     ` Felipe Balbi
2021-08-09 20:52 ` [PATCH v2 8/9] usb: phy: tahvo: " Sergey Shtylyov
2021-08-12  5:39   ` Felipe Balbi
2021-08-13  7:02   ` Greg Kroah-Hartman
2021-08-13 10:33     ` Sergey Shtylyov
2021-08-09 20:53 ` [PATCH v2 9/9] usb: phy: twl6030: add IRQ checks Sergey Shtylyov
2021-08-12  5:39   ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210809205438.GA560062@rowland.harvard.edu \
    --to=stern@rowland.harvard.edu \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=s.shtylyov@omp.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.