From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 546C7C4338F for ; Mon, 9 Aug 2021 23:35:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 376C060FE3 for ; Mon, 9 Aug 2021 23:35:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235609AbhHIXfq (ORCPT ); Mon, 9 Aug 2021 19:35:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:44884 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235510AbhHIXfq (ORCPT ); Mon, 9 Aug 2021 19:35:46 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 39E3D60295; Mon, 9 Aug 2021 23:35:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628552124; bh=2IMhXDdQyftUpOsw+euuyuYULmBMSsJF35i5Ux8hEIA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FmwEpOjSwgmyLYJ9PA5nqsuxpiHvCQrIcH3Z/esEnMdUpSo6782NNb50nZwacsoLM RuoJFeXSKn0pOp0ElFHEepd/8lCZ/CvH57cemLuv8r2WPLyzKaxCtbJjG3/Qq/Qpgg Xw6nID1TOWmjHzkW72y+tHrWdhJdxmj2x+ghNrCrad88IzIOOegcjD1iMeWq+mB2qn JbP5i47687ONbpwx4YsBeSTcZ6p32gaxS/ic0XZsw392zpbVMJtVwc6R/yc4s5Pek2 HeMWX3wi9BIq5HWfJ4ABFfhmytWE2CvYPGbQMZ745Cvd21Vk4aRjQGbAiqLSxOjjUu jQv5PPY9x7PuA== Date: Mon, 9 Aug 2021 16:35:23 -0700 From: "Darrick J. Wong" To: Matthew Wilcox Cc: linux-fsdevel , Christoph Hellwig Subject: Re: [PATCH] iomap: pass writeback errors to the mapping Message-ID: <20210809233523.GQ3601466@magnolia> References: <20210805213154.GZ3601443@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Aug 05, 2021 at 11:12:39PM +0100, Matthew Wilcox wrote: > On Thu, Aug 05, 2021 at 02:31:54PM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong > > > > Modern-day mapping_set_error has the ability to squash the usual > > negative error code into something appropriate for long-term storage in > > a struct address_space -- ENOSPC becomes AS_ENOSPC, and everything else > > becomes EIO. iomap squashes /everything/ to EIO, just as XFS did before > > that, but this doesn't make sense. > > > > Fix this by making it so that we can pass ENOSPC to userspace when > > writeback fails due to space problems. > > > > Signed-off-by: Darrick J. Wong > > I could have sworn I sent this patch in earlier. Anyway, > > Reviewed-by: Matthew Wilcox (Oracle) It was an RFC that I then forgot about for a while. I'll stuff this in the iomap for-next branch the next time I do an update, which ... let's see where the iomap iter series goes, review-wise. --D