[linux-next:master 2910/6223] drivers/scsi/qla2xxx/qla_edif.c:213:25-29: Unneeded variable: "rval". Return "0" on line 264

[linux-next:master 2910/6223] drivers/scsi/qla2xxx/qla_edif.c:213:25-29: Unneeded variable: "rval". Return "0" on line 264

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 753 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   da454ebf578f6c542ba9f5b3ddb98db3ede109c1
commit: 7ebb336e45ef1ce23462c3bbd03779929008901f [2910/6223] scsi: qla2xxx: edif: Add start + stop bsgs
config: i386-randconfig-c021-20210809 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


cocci warnings: (new ones prefixed by >>)
>> drivers/scsi/qla2xxx/qla_edif.c:213:25-29: Unneeded variable: "rval". Return "0" on line 264

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32773 bytes --]

[linux-next:master 2910/6223] drivers/scsi/qla2xxx/qla_edif.c:213:25-29: Unneeded variable: "rval". Return "0" on line 264

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 773 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   da454ebf578f6c542ba9f5b3ddb98db3ede109c1
commit: 7ebb336e45ef1ce23462c3bbd03779929008901f [2910/6223] scsi: qla2xxx: edif: Add start + stop bsgs
config: i386-randconfig-c021-20210809 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


cocci warnings: (new ones prefixed by >>)
>> drivers/scsi/qla2xxx/qla_edif.c:213:25-29: Unneeded variable: "rval". Return "0" on line 264

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32773 bytes --]

[PATCH] scsi: qla2xxx: edif: fix returnvar.cocci warnings

[kernel test robot]

From: kernel test robot <lkp@intel.com>

drivers/scsi/qla2xxx/qla_edif.c:213:25-29: Unneeded variable: "rval". Return "0" on line 264


 Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

Fixes: 7ebb336e45ef ("scsi: qla2xxx: edif: Add start + stop bsgs")
CC: Quinn Tran <qutran@marvell.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   da454ebf578f6c542ba9f5b3ddb98db3ede109c1
commit: 7ebb336e45ef1ce23462c3bbd03779929008901f [2910/6223] scsi: qla2xxx: edif: Add start + stop bsgs
:::::: branch date: 14 hours ago
:::::: commit date: 2 weeks ago

 qla_edif.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/scsi/qla2xxx/qla_edif.c
+++ b/drivers/scsi/qla2xxx/qla_edif.c
@@ -210,7 +210,6 @@ qla_edif_app_start(scsi_qla_host_t *vha,
 static int
 qla_edif_app_stop(scsi_qla_host_t *vha, struct bsg_job *bsg_job)
 {
-	int32_t                 rval = 0;
 	struct app_stop         appstop;
 	struct fc_bsg_reply     *bsg_reply = bsg_job->reply;
 	struct fc_port  *fcport, *tf;
@@ -261,7 +260,7 @@ qla_edif_app_stop(scsi_qla_host_t *vha,
 
 	/* no return interface to app - it assumes we cleaned up ok */
 
-	return rval;
+	return 0;
 }
 
 int32_t

[PATCH] scsi: qla2xxx: edif: fix returnvar.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1411 bytes --]

From: kernel test robot <lkp@intel.com>

drivers/scsi/qla2xxx/qla_edif.c:213:25-29: Unneeded variable: "rval". Return "0" on line 264


 Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

Fixes: 7ebb336e45ef ("scsi: qla2xxx: edif: Add start + stop bsgs")
CC: Quinn Tran <qutran@marvell.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   da454ebf578f6c542ba9f5b3ddb98db3ede109c1
commit: 7ebb336e45ef1ce23462c3bbd03779929008901f [2910/6223] scsi: qla2xxx: edif: Add start + stop bsgs
:::::: branch date: 14 hours ago
:::::: commit date: 2 weeks ago

 qla_edif.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/scsi/qla2xxx/qla_edif.c
+++ b/drivers/scsi/qla2xxx/qla_edif.c
@@ -210,7 +210,6 @@ qla_edif_app_start(scsi_qla_host_t *vha,
 static int
 qla_edif_app_stop(scsi_qla_host_t *vha, struct bsg_job *bsg_job)
 {
-	int32_t                 rval = 0;
 	struct app_stop         appstop;
 	struct fc_bsg_reply     *bsg_reply = bsg_job->reply;
 	struct fc_port  *fcport, *tf;
@@ -261,7 +260,7 @@ qla_edif_app_stop(scsi_qla_host_t *vha,
 
 	/* no return interface to app - it assumes we cleaned up ok */
 
-	return rval;
+	return 0;
 }
 
 int32_t