Re: [PATCH 2/3] pktgen: Add imix distribution bins

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2646 bytes --]

Hi Nicholas,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]
[also build test WARNING on net/master linus/master sparc-next/master v5.14-rc5 next-20210809]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Nicholas-Richardson/Add-IMIX-mode/20210810-012443
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 2a2b6e3640c43a808dcb5226963e2cc0669294b1
config: mips-gpr_defconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/67c74be329532a95c7203e4124788c36841e0517
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Nicholas-Richardson/Add-IMIX-mode/20210810-012443
        git checkout 67c74be329532a95c7203e4124788c36841e0517
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross O=build_dir ARCH=mips SHELL=/bin/bash net/core/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> net/core/pktgen.c:489:13: warning: 'fill_imix_distribution' used but never defined
     489 | static void fill_imix_distribution(struct pktgen_dev *pkt_dev);
         |             ^~~~~~~~~~~~~~~~~~~~~~
   net/core/pktgen.c:211:38: warning: 'F_IPSEC' defined but not used [-Wunused-const-variable=]
     211 | #define pf(flag)  static const __u32 F_##flag = (1<<flag##_SHIFT);
         |                                      ^~
   net/core/pktgen.c:197:2: note: in expansion of macro 'pf'
     197 |  pf(IPSEC)  /* ipsec on for flows */  \
         |  ^~
   net/core/pktgen.c:212:1: note: in expansion of macro 'PKT_FLAGS'
     212 | PKT_FLAGS
         | ^~~~~~~~~


vim +/fill_imix_distribution +489 net/core/pktgen.c

   486	
   487	static void pktgen_stop(struct pktgen_thread *t);
   488	static void pktgen_clear_counters(struct pktgen_dev *pkt_dev);
 > 489	static void fill_imix_distribution(struct pktgen_dev *pkt_dev);
   490	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 21764 bytes --]