All of lore.kernel.org
 help / color / mirror / Atom feed
From: jilei <jilei8@huawei.com>
To: <dev@dpdk.org>
Cc: <chas3@att.com>, <humin29@huawei.com>, <zhaohui8@huawei.com>,
	<yu.yutao@huawei.com>, <hejiajun@huawei.com>,
	<liucheng11@huawei.com>, <yinpeijun@huawei.com>,
	jilei <jilei8@huawei.com>, <stable@dpdk.org>
Subject: [dpdk-dev] [PATCH] net/bonding:fix balance-xor link down stack overflow
Date: Tue, 10 Aug 2021 14:43:23 +0800	[thread overview]
Message-ID: <20210810064323.4161835-1-jilei8@huawei.com> (raw)

When slave link down, deactivate_slave will internals->active_slaves
and internals->active_slave_count.Active_slave in bond_ethdev_rx_burst
may out of range in internals->active_slaves.It will get bond's port_id
cause stack overflow

Cc: stable@dpdk.org
Signed-off-by: jilei <jilei8@huawei.com>
---
 drivers/net/bonding/rte_eth_bond_pmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index a6755661c4..46f2c42d60 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -82,7 +82,7 @@ bond_ethdev_rx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
 					 bufs + num_rx_total, nb_pkts);
 		num_rx_total += num_rx_slave;
 		nb_pkts -= num_rx_slave;
-		if (++active_slave == slave_count)
+		if (++active_slave >= slave_count)
 			active_slave = 0;
 	}
 
-- 
2.23.0


             reply	other threads:[~2021-08-10  8:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-10  6:43 jilei [this message]
2021-08-10  7:50 ` [dpdk-dev] [PATCH] net/bonding:fix balance-xor link down stack overflow Min Hu (Connor)
2022-05-20 15:33   ` Ferruh Yigit
2022-07-18 13:08 ` [dpdk-dev] [PATCH] net/bonding: fix array overflow in Rx burst Yunjian Wang
2022-07-20  1:28   ` 答复: " humin (Q)
2022-08-25 16:39     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210810064323.4161835-1-jilei8@huawei.com \
    --to=jilei8@huawei.com \
    --cc=chas3@att.com \
    --cc=dev@dpdk.org \
    --cc=hejiajun@huawei.com \
    --cc=humin29@huawei.com \
    --cc=liucheng11@huawei.com \
    --cc=stable@dpdk.org \
    --cc=yinpeijun@huawei.com \
    --cc=yu.yutao@huawei.com \
    --cc=zhaohui8@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.