From: Dan Carpenter <dan.carpenter@oracle.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: gregkh@linuxfoundation.org, phil@philpotter.co.uk,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: Replace BITn with BIT(n)
Date: Tue, 10 Aug 2021 09:59:39 +0300 [thread overview]
Message-ID: <20210810065939.GU1931@kadam> (raw)
In-Reply-To: <20210809182006.29452-1-Larry.Finger@lwfinger.net>
On Mon, Aug 09, 2021 at 01:20:06PM -0500, Larry Finger wrote:
> -#define IMR_TSF_BIT32_TOGGLE_88E BIT24 /* TSF Timer BIT32 toggle indication interrupt */
> +#define IMR_TSF_BIT32_TOGGLE_88E BIT(24) /* TSF Timer BIT(3)2 toggle indication interrupt */
^^^^^^^
Typo here. You can clean it up in a follow on patch.
regards,
dan carpenter
next prev parent reply other threads:[~2021-08-10 7:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 18:20 [PATCH] staging: r8188eu: Replace BITn with BIT(n) Larry Finger
2021-08-10 6:59 ` Dan Carpenter [this message]
2021-08-10 10:21 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210810065939.GU1931@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.