[PATCH 0/7] MAINTAINERS: review kraxel's entries.

[PATCH 0/7] MAINTAINERS: review kraxel's entries.

[Gerd Hoffmann]

You probably have noticed that Laszlo stepped down from edk2
maintenance (see commit 2669350db2c3 ("MAINTAINERS: remove Laszlo
Ersek's entries")).  This applies not only to qemu, but also the edk2
project.

I'll go try fill the hole he left and shift my priorities towards edk2.
This naturally comes with the bad news that I'll have less time to work
on qemu.  The good news is I'm not going to disappear in a poof of smoke
and will be available for questions even when coding and maintaining
less than I did before.  I'll also try to finish up my work in progress
things (mostly modules stuff).

So, a good opportunity to review all my entries in the MAINTAINERS files
and adjust them.  Switched most entries over to "Odd Fixes" status.
I'll probably review again in a few months, possibly orphaning things if
needed, but lets see how it goes this way first.

If someone wants take over as maintainer for something I'll happily stay
as Reviewer for a while to help with the transition.

take care,
  Gerd

Gerd Hoffmann (7):
  MAINTAINERS: update edk2 entry.
  MAINTAINERS: update sockets entry.
  MAINTAINERS: update audio entry.
  MAINTAINERS: update spice entry.
  MAINTAINERS: update usb entries.
  MAINTAINERS: update virtio-input entry.
  MAINTAINERS: update virtio-gpu entry.

 MAINTAINERS | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

-- 
2.31.1

[PATCH 1/7] MAINTAINERS: update edk2 entry.

[Gerd Hoffmann]

I want keep an eye on the edk2 things happening in qemu.

Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 37b1a8e4428c..9d31e42786b5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2947,6 +2947,7 @@ F: docs/interop/firmware.json
 
 EDK2 Firmware
 M: Philippe Mathieu-Daudé <philmd@redhat.com>
+R: Gerd Hoffmann <kraxel@redhat.com>
 S: Supported
 F: hw/i386/*ovmf*
 F: pc-bios/descriptors/??-edk2-*.json
-- 
2.31.1

[PATCH 2/7] MAINTAINERS: update sockets entry.

[Gerd Hoffmann]

I have not touched the code for years.
Make the entry match reality and drop my name.

Cc: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 MAINTAINERS | 1 -
 1 file changed, 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 9d31e42786b5..9b1b3f6599b5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2843,7 +2843,6 @@ F: tests/unit/test-authz-*
 
 Sockets
 M: Daniel P. Berrange <berrange@redhat.com>
-M: Gerd Hoffmann <kraxel@redhat.com>
 S: Maintained
 F: include/qemu/sockets.h
 F: util/qemu-sockets.c
-- 
2.31.1

[PATCH 3/7] MAINTAINERS: update audio entry.

[Gerd Hoffmann]

New maintainer wanted. Downgrade status to "Odd Fixes" for now.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 9b1b3f6599b5..90dfe93d7246 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2258,7 +2258,7 @@ Subsystems
 ----------
 Audio
 M: Gerd Hoffmann <kraxel@redhat.com>
-S: Maintained
+S: Odd Fixes
 F: audio/
 F: hw/audio/
 F: include/hw/audio/
-- 
2.31.1

[PATCH 4/7] MAINTAINERS: update spice entry.

[Gerd Hoffmann]

New maintainer wanted. Downgrade status to "Odd Fixes" for now.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 90dfe93d7246..ef916c993472 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2470,7 +2470,7 @@ F: scripts/coccinelle/memory-region-housekeeping.cocci
 
 SPICE
 M: Gerd Hoffmann <kraxel@redhat.com>
-S: Supported
+S: Odd Fixes
 F: include/ui/qemu-spice.h
 F: include/ui/spice-display.h
 F: ui/spice-*.c
-- 
2.31.1

[PATCH 5/7] MAINTAINERS: update usb entries.

[Gerd Hoffmann]

New maintainer wanted.  Switch role to "Reviewer" for usb-serial,
downgrade status to "Odd Fixes" for everything else.

Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 MAINTAINERS | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index ef916c993472..fda79d2449ad 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1832,7 +1832,7 @@ F: tests/qtest/sdhci-test.c
 
 USB
 M: Gerd Hoffmann <kraxel@redhat.com>
-S: Maintained
+S: Odd Fixes
 F: hw/usb/*
 F: stubs/usb-dev-stub.c
 F: tests/qtest/usb-*-test.c
@@ -1841,7 +1841,7 @@ F: include/hw/usb.h
 F: include/hw/usb/
 
 USB (serial adapter)
-M: Gerd Hoffmann <kraxel@redhat.com>
+R: Gerd Hoffmann <kraxel@redhat.com>
 M: Samuel Thibault <samuel.thibault@ens-lyon.org>
 S: Maintained
 F: hw/usb/dev-serial.c
-- 
2.31.1

[PATCH 6/7] MAINTAINERS: update virtio-input entry.

[Gerd Hoffmann]

New maintainer wanted. Downgrade status to "Odd Fixes" for now.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index fda79d2449ad..5d24ac453bb6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1951,7 +1951,7 @@ L: virtio-fs@redhat.com
 
 virtio-input
 M: Gerd Hoffmann <kraxel@redhat.com>
-S: Maintained
+S: Odd Fixes
 F: hw/input/vhost-user-input.c
 F: hw/input/virtio-input*.c
 F: include/hw/virtio/virtio-input.h
-- 
2.31.1

[PATCH 7/7] MAINTAINERS: update virtio-gpu entry.

[Gerd Hoffmann]

New maintainer wanted. Downgrade status to "Odd Fixes" for now.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 MAINTAINERS | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 5d24ac453bb6..7d3e0ca43676 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2157,7 +2157,7 @@ F: include/hw/display/ramfb.h
 
 virtio-gpu
 M: Gerd Hoffmann <kraxel@redhat.com>
-S: Maintained
+S: Odd Fixes
 F: hw/display/virtio-gpu*
 F: hw/display/virtio-vga.*
 F: include/hw/virtio/virtio-gpu.h
@@ -2176,7 +2176,7 @@ F: include/hw/virtio/vhost-user-scsi.h
 
 vhost-user-gpu
 M: Marc-André Lureau <marcandre.lureau@redhat.com>
-M: Gerd Hoffmann <kraxel@redhat.com>
+R: Gerd Hoffmann <kraxel@redhat.com>
 S: Maintained
 F: docs/interop/vhost-user-gpu.rst
 F: contrib/vhost-user-gpu
-- 
2.31.1

Re: [PATCH 3/7] MAINTAINERS: update audio entry.

[clamky]

Gerd Hoffmann <kraxel@redhat.com> writes:

> On Tue, Aug 10, 2021 at 03:17:43PM +0300, clamky@hotmail.com wrote:
>> Gerd Hoffmann <kraxel@redhat.com> writes:
>> 
>> Hell Gerd.
>> 
>> > New maintainer wanted. Downgrade status to "Odd Fixes" for now.
>> 
>> I can try to retake it.
>
> qemu development happens in public on the qemu-devel mailing list,
> not behind closed doors.  Same goes for maintenance, updates to the
> MAINTAINERS file and related discussions are happening on the mailing
> list too.
>
> So, of you want seriously step up you should start by saying so in
> public, on the mailing list, not to me privately.
>
> take care,
>   Gerd

Re: [PATCH 1/7] MAINTAINERS: update edk2 entry.

[Philippe Mathieu-Daudé]

On 8/10/21 10:34 AM, Gerd Hoffmann wrote:
> I want keep an eye on the edk2 things happening in qemu.
> 
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 37b1a8e4428c..9d31e42786b5 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2947,6 +2947,7 @@ F: docs/interop/firmware.json
>  
>  EDK2 Firmware
>  M: Philippe Mathieu-Daudé <philmd@redhat.com>
> +R: Gerd Hoffmann <kraxel@redhat.com>

Let's be honest and add you a M: tag here ;)

Whichever you prefer:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

>  S: Supported
>  F: hw/i386/*ovmf*
>  F: pc-bios/descriptors/??-edk2-*.json
> 

Re: [PATCH 3/7] MAINTAINERS: update audio entry.

[Gerd Hoffmann]

  Hi,

> > On Tue, Aug 10, 2021 at 03:17:43PM +0300, clamky@hotmail.com wrote:
> >> Gerd Hoffmann <kraxel@redhat.com> writes:
> >> 
> >> Hell Gerd.
> >> 
> >> > New maintainer wanted. Downgrade status to "Odd Fixes" for now.
> >> 
> >> I can try to retake it.

Given your track record is zero contributions to qemu in recent years
I suggest you start getting involved in the development process as
reviewer.  Just send a patch adding a "R: Name <email>" line for
yourself to the MAINTAINERS file (best based on my pending pull
request to avoid conflicts).  scripts/get_maintainer.pl will Cc: you
on any audio-related patches then.

I'd recommend to open an gitlab.com account (unless you already have
one of course) so you can help triage bugs + issues.  You can also
easily run qemu CI then (just push a branch to a qemu repo fork).

HTH & take care,
  Gerd

Re: [PATCH 3/7] MAINTAINERS: update audio entry.

[Christian Schoenebeck]

On Donnerstag, 12. August 2021 10:42:10 CEST Gerd Hoffmann wrote:
>   Hi,
> 
> > > On Tue, Aug 10, 2021 at 03:17:43PM +0300, clamky@hotmail.com wrote:
> > >> Gerd Hoffmann <kraxel@redhat.com> writes:
> > >> 
> > >> Hell Gerd.
> > >> 
> > >> > New maintainer wanted. Downgrade status to "Odd Fixes" for now.
> > >> 
> > >> I can try to retake it.
> 
> Given your track record is zero contributions to qemu in recent years
> I suggest you start getting involved in the development process as
> reviewer.  Just send a patch adding a "R: Name <email>" line for
> yourself to the MAINTAINERS file (best based on my pending pull
> request to avoid conflicts).  scripts/get_maintainer.pl will Cc: you
> on any audio-related patches then.
> 
> I'd recommend to open an gitlab.com account (unless you already have
> one of course) so you can help triage bugs + issues.  You can also
> easily run qemu CI then (just push a branch to a qemu repo fork).
> 
> HTH & take care,
>   Gerd

I will add myself as reviewer for audio to help out a bit at least. I won't be 
able to take over maintainership at this point though.

I wait for your PR to be merged by Peter before sending my MAINTAINERS patch.

Best regards,
Christian Schoenebeck

Re: [PATCH 3/7] MAINTAINERS: update audio entry.

[Philippe Mathieu-Daudé]

Hi all,

On 8/12/21 2:24 PM, Christian Schoenebeck wrote:
> On Donnerstag, 12. August 2021 10:42:10 CEST Gerd Hoffmann wrote:
>>   Hi,
>>
>>>> On Tue, Aug 10, 2021 at 03:17:43PM +0300, clamky@hotmail.com wrote:
>>>>> Gerd Hoffmann <kraxel@redhat.com> writes:
>>>>>
>>>>> Hell Gerd.
>>>>>
>>>>>> New maintainer wanted. Downgrade status to "Odd Fixes" for now.
>>>>>
>>>>> I can try to retake it.
>>
>> Given your track record is zero contributions to qemu in recent years
>> I suggest you start getting involved in the development process as
>> reviewer.  Just send a patch adding a "R: Name <email>" line for
>> yourself to the MAINTAINERS file (best based on my pending pull
>> request to avoid conflicts).  scripts/get_maintainer.pl will Cc: you
>> on any audio-related patches then.
>>
>> I'd recommend to open an gitlab.com account (unless you already have
>> one of course) so you can help triage bugs + issues.  You can also
>> easily run qemu CI then (just push a branch to a qemu repo fork).
>>
>> HTH & take care,
>>   Gerd
> 
> I will add myself as reviewer for audio to help out a bit at least. I won't be 
> able to take over maintainership at this point though.

Thanks for volunteering :)

Following the overall thread, since I have been wondering about
this subsystem during the night.

As of v6.1.0-rc3:

$ find {,include/}audio -type f | xargs cat | wc -l
11412

$ find {,include/}hw/audio -type f | xargs cat | wc -l
14265

So the backends / frontends have almost the same size.

First idea, split the current entry in too, allowing developers
with different interests to add their contact to the relevant entries.

Then looking at the contribution over the last 10 years:

$ git shortlog -n -s --since=10years -- {,include/}audio | head -10
    70  Kővágó, Zoltán
    62  Volker Rümelin
    24  Gerd Hoffmann
    13  Markus Armbruster
    13  Paolo Bonzini
    10  Peter Maydell
     8  Geoffrey McRae
     8  Philippe Mathieu-Daudé
     8  Stefan Weil
     7  Marc-André Lureau

$ git shortlog -n -s --since=10years -- {,include/}hw/audio | head -10
    30  Gerd Hoffmann
    29  Juan Quintela
    29  Paolo Bonzini
    26  Markus Armbruster
    14  Andreas Färber
    13  Eduardo Habkost
    12  Philippe Mathieu-Daudé
     8  Peter Maydell
     6  Hervé Poussineau
     6  Xiaoqiang Zhao

The backend part is clearly where the activity is (almost no new sound
devices added), with Zoltán Kővágó and Volker Rümelin the most active
contributors. IMHO they certainly deserve an R: tag (but up to them).
Cc'ing them, reminding a R: tag is not about responsibility but more
to not forgot to Cc contributors with both knowledge and interests:

  Descriptions of section entries:

    M: Mail patches to: FullName <address@domain>
       Maintainers are looking after a certain area and must be CCed
       on patches. They are considered the main contact point.
    R: Designated reviewer: FullName <address@domain>
       These reviewers should be CCed on patches.
       Reviewers are familiar with the subject matter and provide
       feedback even though they are not maintainers.

Regards,

Phil.

Re: [PATCH 3/7] MAINTAINERS: update audio entry.

[Christian Schoenebeck]

On Donnerstag, 12. August 2021 15:13:24 CEST Philippe Mathieu-Daudé wrote:
> Hi all,
> 
> On 8/12/21 2:24 PM, Christian Schoenebeck wrote:
> > On Donnerstag, 12. August 2021 10:42:10 CEST Gerd Hoffmann wrote:
> >>   Hi,
> >>   
> >>>> On Tue, Aug 10, 2021 at 03:17:43PM +0300, clamky@hotmail.com wrote:
> >>>>> Gerd Hoffmann <kraxel@redhat.com> writes:
> >>>>> 
> >>>>> Hell Gerd.
> >>>>> 
> >>>>>> New maintainer wanted. Downgrade status to "Odd Fixes" for now.
> >>>>> 
> >>>>> I can try to retake it.
> >> 
> >> Given your track record is zero contributions to qemu in recent years
> >> I suggest you start getting involved in the development process as
> >> reviewer.  Just send a patch adding a "R: Name <email>" line for
> >> yourself to the MAINTAINERS file (best based on my pending pull
> >> request to avoid conflicts).  scripts/get_maintainer.pl will Cc: you
> >> on any audio-related patches then.
> >> 
> >> I'd recommend to open an gitlab.com account (unless you already have
> >> one of course) so you can help triage bugs + issues.  You can also
> >> easily run qemu CI then (just push a branch to a qemu repo fork).
> >> 
> >> HTH & take care,
> >> 
> >>   Gerd
> > 
> > I will add myself as reviewer for audio to help out a bit at least. I
> > won't be able to take over maintainership at this point though.
> 
> Thanks for volunteering :)
> 
> Following the overall thread, since I have been wondering about
> this subsystem during the night.
> 
> As of v6.1.0-rc3:
> 
> $ find {,include/}audio -type f | xargs cat | wc -l
> 11412
> 
> $ find {,include/}hw/audio -type f | xargs cat | wc -l
> 14265
> 
> So the backends / frontends have almost the same size.
> 
> First idea, split the current entry in too, allowing developers
> with different interests to add their contact to the relevant entries.

Splitting the audio section sounds like a good idea to me.

It might also be worth a try asking the individual authors whether they were 
fine being added as reviewer for their specific audio sources. If yes, then 
the audio section could be further subdivided accordingly so that reviewers 
would only get CCed for their specific code.

Best regards,
Christian Schoenebeck

Re: [PATCH 3/7] MAINTAINERS: update audio entry.

[Gerd Hoffmann]

  Hi,

> First idea, split the current entry in too, allowing developers
> with different interests to add their contact to the relevant entries.

This makes sense indeed.  Maybe split the backends into even more
entries, specifically the os-specific ones (coreaudio for macos, ...),
similar to the separate ui/cocoa entry we already have.

take care,
  Gerd