All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-oe][PATCH] opus-tools: update to 0.2 and fix license
@ 2021-08-10 13:18 Michael Opdenacker
  2021-08-11 17:23 ` [oe] " Khem Raj
  0 siblings, 1 reply; 6+ messages in thread
From: Michael Opdenacker @ 2021-08-10 13:18 UTC (permalink / raw)
  To: openembedded-devel; +Cc: Michael Opdenacker

The license in version 0.1.8 was already BSD-2-Clause and GPLv2
(for the "opusinfo" command).

The license checksum change is due to trivial changes on the license
text ("https" instead of "http" and whitespace changes).

This new version now DEPENDs on "libopusenc" and "opusfile" too.

Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
---
 .../opus-tools/opus-tools_0.1.8.bb                | 15 ---------------
 .../opus-tools/opus-tools_0.2.bb                  | 15 +++++++++++++++
 2 files changed, 15 insertions(+), 15 deletions(-)
 delete mode 100644 meta-oe/recipes-multimedia/opus-tools/opus-tools_0.1.8.bb
 create mode 100644 meta-oe/recipes-multimedia/opus-tools/opus-tools_0.2.bb

diff --git a/meta-oe/recipes-multimedia/opus-tools/opus-tools_0.1.8.bb b/meta-oe/recipes-multimedia/opus-tools/opus-tools_0.1.8.bb
deleted file mode 100644
index a84f2bf07..000000000
--- a/meta-oe/recipes-multimedia/opus-tools/opus-tools_0.1.8.bb
+++ /dev/null
@@ -1,15 +0,0 @@
-SUMMARY = "Opus Audio Tools"
-HOMEPAGE = "http://www.opus-codec.org/"
-
-LICENSE = "BSD-2-Clause"
-LIC_FILES_CHKSUM = "file://COPYING;md5=843a066da9f1facfcc6ea6f616ffecb1"
-
-SRC_URI = "http://downloads.xiph.org/releases/opus/opus-tools-${PV}.tar.gz"
-SRC_URI[md5sum] = "b424790eda9357a4df394e2d7ca19eac"
-SRC_URI[sha256sum] = "e4e188579ea1c4e4d5066460d4a7214a7eafe3539e9a4466fdc98af41ba4a2f6"
-
-S = "${WORKDIR}/opus-tools-${PV}"
-
-DEPENDS = "libopus flac"
-
-inherit autotools pkgconfig
diff --git a/meta-oe/recipes-multimedia/opus-tools/opus-tools_0.2.bb b/meta-oe/recipes-multimedia/opus-tools/opus-tools_0.2.bb
new file mode 100644
index 000000000..b5e6ed947
--- /dev/null
+++ b/meta-oe/recipes-multimedia/opus-tools/opus-tools_0.2.bb
@@ -0,0 +1,15 @@
+SUMMARY = "Opus Audio Tools"
+HOMEPAGE = "http://www.opus-codec.org/"
+
+LICENSE = "BSD-2-Clause & GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=79f6fc2a6239fbe5f6e52f20ac76698c"
+
+SRC_URI = "http://downloads.xiph.org/releases/opus/opus-tools-${PV}.tar.gz"
+SRC_URI[md5sum] = "ff2d0536e960cabbfb8ca7c8c1759b6c"
+SRC_URI[sha256sum] = "b4e56cb00d3e509acfba9a9b627ffd8273b876b4e2408642259f6da28fa0ff86"
+
+S = "${WORKDIR}/opus-tools-${PV}"
+
+DEPENDS = "libopus libopusenc flac opusfile"
+
+inherit autotools pkgconfig
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [oe] [meta-oe][PATCH] opus-tools: update to 0.2 and fix license
  2021-08-10 13:18 [meta-oe][PATCH] opus-tools: update to 0.2 and fix license Michael Opdenacker
@ 2021-08-11 17:23 ` Khem Raj
  2021-08-11 18:12   ` Michael Opdenacker
  2021-08-12 17:04   ` [meta-oe][PATCH v2] opus-tools: update to 0.2, move to meta-multimedia " Michael Opdenacker
  0 siblings, 2 replies; 6+ messages in thread
From: Khem Raj @ 2021-08-11 17:23 UTC (permalink / raw)
  To: Michael Opdenacker; +Cc: openembeded-devel

On Tue, Aug 10, 2021 at 6:18 AM Michael Opdenacker
<michael.opdenacker@bootlin.com> wrote:
>
> The license in version 0.1.8 was already BSD-2-Clause and GPLv2
> (for the "opusinfo" command).
>
> The license checksum change is due to trivial changes on the license
> text ("https" instead of "http" and whitespace changes).
>
> This new version now DEPENDs on "libopusenc" and "opusfile" too.
>

Thanks for this patch, it brings up a YP compatibility issue to front see
https://autobuilder.yoctoproject.org/typhoon/#/builders/88/builds/1455

I think it would be better to move this recipe to meta-multimedia
which should fix it.

> Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
> ---
>  .../opus-tools/opus-tools_0.1.8.bb                | 15 ---------------
>  .../opus-tools/opus-tools_0.2.bb                  | 15 +++++++++++++++
>  2 files changed, 15 insertions(+), 15 deletions(-)
>  delete mode 100644 meta-oe/recipes-multimedia/opus-tools/opus-tools_0.1.8.bb
>  create mode 100644 meta-oe/recipes-multimedia/opus-tools/opus-tools_0.2.bb
>
> diff --git a/meta-oe/recipes-multimedia/opus-tools/opus-tools_0.1.8.bb b/meta-oe/recipes-multimedia/opus-tools/opus-tools_0.1.8.bb
> deleted file mode 100644
> index a84f2bf07..000000000
> --- a/meta-oe/recipes-multimedia/opus-tools/opus-tools_0.1.8.bb
> +++ /dev/null
> @@ -1,15 +0,0 @@
> -SUMMARY = "Opus Audio Tools"
> -HOMEPAGE = "http://www.opus-codec.org/"
> -
> -LICENSE = "BSD-2-Clause"
> -LIC_FILES_CHKSUM = "file://COPYING;md5=843a066da9f1facfcc6ea6f616ffecb1"
> -
> -SRC_URI = "http://downloads.xiph.org/releases/opus/opus-tools-${PV}.tar.gz"
> -SRC_URI[md5sum] = "b424790eda9357a4df394e2d7ca19eac"
> -SRC_URI[sha256sum] = "e4e188579ea1c4e4d5066460d4a7214a7eafe3539e9a4466fdc98af41ba4a2f6"
> -
> -S = "${WORKDIR}/opus-tools-${PV}"
> -
> -DEPENDS = "libopus flac"
> -
> -inherit autotools pkgconfig
> diff --git a/meta-oe/recipes-multimedia/opus-tools/opus-tools_0.2.bb b/meta-oe/recipes-multimedia/opus-tools/opus-tools_0.2.bb
> new file mode 100644
> index 000000000..b5e6ed947
> --- /dev/null
> +++ b/meta-oe/recipes-multimedia/opus-tools/opus-tools_0.2.bb
> @@ -0,0 +1,15 @@
> +SUMMARY = "Opus Audio Tools"
> +HOMEPAGE = "http://www.opus-codec.org/"
> +
> +LICENSE = "BSD-2-Clause & GPLv2"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=79f6fc2a6239fbe5f6e52f20ac76698c"
> +
> +SRC_URI = "http://downloads.xiph.org/releases/opus/opus-tools-${PV}.tar.gz"
> +SRC_URI[md5sum] = "ff2d0536e960cabbfb8ca7c8c1759b6c"
> +SRC_URI[sha256sum] = "b4e56cb00d3e509acfba9a9b627ffd8273b876b4e2408642259f6da28fa0ff86"
> +
> +S = "${WORKDIR}/opus-tools-${PV}"
> +
> +DEPENDS = "libopus libopusenc flac opusfile"
> +
> +inherit autotools pkgconfig
> --
> 2.25.1
>
>
> 
>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [oe] [meta-oe][PATCH] opus-tools: update to 0.2 and fix license
  2021-08-11 17:23 ` [oe] " Khem Raj
@ 2021-08-11 18:12   ` Michael Opdenacker
  2021-08-11 18:15     ` Khem Raj
  2021-08-12 17:04   ` [meta-oe][PATCH v2] opus-tools: update to 0.2, move to meta-multimedia " Michael Opdenacker
  1 sibling, 1 reply; 6+ messages in thread
From: Michael Opdenacker @ 2021-08-11 18:12 UTC (permalink / raw)
  To: Khem Raj; +Cc: openembeded-devel

Hi Khem,

Thanks for the review and checking the test report!

On 8/11/21 7:23 PM, Khem Raj wrote:
> On Tue, Aug 10, 2021 at 6:18 AM Michael Opdenacker
> <michael.opdenacker@bootlin.com> wrote:
>> The license in version 0.1.8 was already BSD-2-Clause and GPLv2
>> (for the "opusinfo" command).
>>
>> The license checksum change is due to trivial changes on the license
>> text ("https" instead of "http" and whitespace changes).
>>
>> This new version now DEPENDs on "libopusenc" and "opusfile" too.
>>
> Thanks for this patch, it brings up a YP compatibility issue to front see
> https://autobuilder.yoctoproject.org/typhoon/#/builders/88/builds/1455
>
> I think it would be better to move this recipe to meta-multimedia
> which should fix it.


I'll be happy to.
However, what's really the difference between meta-oe/recipes-multimedia
and meta-multimedia/recipes-multimedia/? Why two different directories
in the same repository?

Thanks again,
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [oe] [meta-oe][PATCH] opus-tools: update to 0.2 and fix license
  2021-08-11 18:12   ` Michael Opdenacker
@ 2021-08-11 18:15     ` Khem Raj
  2021-08-12 17:13       ` Michael Opdenacker
  0 siblings, 1 reply; 6+ messages in thread
From: Khem Raj @ 2021-08-11 18:15 UTC (permalink / raw)
  To: Michael Opdenacker; +Cc: openembeded-devel

On Wed, Aug 11, 2021 at 11:12 AM Michael Opdenacker
<michael.opdenacker@bootlin.com> wrote:
>
> Hi Khem,
>
> Thanks for the review and checking the test report!
>
> On 8/11/21 7:23 PM, Khem Raj wrote:
> > On Tue, Aug 10, 2021 at 6:18 AM Michael Opdenacker
> > <michael.opdenacker@bootlin.com> wrote:
> >> The license in version 0.1.8 was already BSD-2-Clause and GPLv2
> >> (for the "opusinfo" command).
> >>
> >> The license checksum change is due to trivial changes on the license
> >> text ("https" instead of "http" and whitespace changes).
> >>
> >> This new version now DEPENDs on "libopusenc" and "opusfile" too.
> >>
> > Thanks for this patch, it brings up a YP compatibility issue to front see
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/88/builds/1455
> >
> > I think it would be better to move this recipe to meta-multimedia
> > which should fix it.
>
>
> I'll be happy to.
> However, what's really the difference between meta-oe/recipes-multimedia
> and meta-multimedia/recipes-multimedia/? Why two different directories
> in the same repository?

these are two different layers, someone may not use meta-multimedia if
its not in bblayers.conf
and thusly not see the dir under meta-multimedia, so tools/packages
which are media related
but more or less generic go into meta-oe/recipe-multimedia, which this
upgrade now depends
on packages in meta-multimedia so its better to put it in meta-multimedia now

>
> Thanks again,
> Michael.
>
> --
> Michael Opdenacker, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [meta-oe][PATCH v2] opus-tools: update to 0.2, move to meta-multimedia and fix license
  2021-08-11 17:23 ` [oe] " Khem Raj
  2021-08-11 18:12   ` Michael Opdenacker
@ 2021-08-12 17:04   ` Michael Opdenacker
  1 sibling, 0 replies; 6+ messages in thread
From: Michael Opdenacker @ 2021-08-12 17:04 UTC (permalink / raw)
  To: openembedded-devel; +Cc: Michael Opdenacker

The license in version 0.1.8 was already BSD-2-Clause and GPLv2
(for the "opusinfo" command).

The license checksum change is due to trivial changes on the license
text ("https" instead of "http" and whitespace changes).

This new version now DEPENDs on "libopusenc" and "opusfile" too,
but this required to move the recipe to meta-multimedia instead.

Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
---
 .../opus-tools/opus-tools_0.2.bb                  | 15 +++++++++++++++
 .../packagegroups/packagegroup-meta-multimedia.bb |  1 +
 .../packagegroups/packagegroup-meta-oe.bb         |  1 -
 .../opus-tools/opus-tools_0.1.8.bb                | 15 ---------------
 4 files changed, 16 insertions(+), 16 deletions(-)
 create mode 100644 meta-multimedia/recipes-multimedia/opus-tools/opus-tools_0.2.bb
 delete mode 100644 meta-oe/recipes-multimedia/opus-tools/opus-tools_0.1.8.bb

diff --git a/meta-multimedia/recipes-multimedia/opus-tools/opus-tools_0.2.bb b/meta-multimedia/recipes-multimedia/opus-tools/opus-tools_0.2.bb
new file mode 100644
index 000000000..b5e6ed947
--- /dev/null
+++ b/meta-multimedia/recipes-multimedia/opus-tools/opus-tools_0.2.bb
@@ -0,0 +1,15 @@
+SUMMARY = "Opus Audio Tools"
+HOMEPAGE = "http://www.opus-codec.org/"
+
+LICENSE = "BSD-2-Clause & GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=79f6fc2a6239fbe5f6e52f20ac76698c"
+
+SRC_URI = "http://downloads.xiph.org/releases/opus/opus-tools-${PV}.tar.gz"
+SRC_URI[md5sum] = "ff2d0536e960cabbfb8ca7c8c1759b6c"
+SRC_URI[sha256sum] = "b4e56cb00d3e509acfba9a9b627ffd8273b876b4e2408642259f6da28fa0ff86"
+
+S = "${WORKDIR}/opus-tools-${PV}"
+
+DEPENDS = "libopus libopusenc flac opusfile"
+
+inherit autotools pkgconfig
diff --git a/meta-multimedia/recipes-multimedia/packagegroups/packagegroup-meta-multimedia.bb b/meta-multimedia/recipes-multimedia/packagegroups/packagegroup-meta-multimedia.bb
index 9e0c319c3..5522731a2 100644
--- a/meta-multimedia/recipes-multimedia/packagegroups/packagegroup-meta-multimedia.bb
+++ b/meta-multimedia/recipes-multimedia/packagegroups/packagegroup-meta-multimedia.bb
@@ -66,6 +66,7 @@ RDEPENDS:packagegroup-meta-multimedia = "\
     mycroft \
     openal-soft \
     opusfile \
+    opus-tools \
     libdvdcss \
     ${@bb.utils.contains("LICENSE_FLAGS_WHITELIST", "commercial", bb.utils.contains("DISTRO_FEATURES", "x11", "vlc", "", d), "", d)} \
     ${@bb.utils.contains("LICENSE_FLAGS_WHITELIST", "commercial", "sox streamripper", "", d)} \
diff --git a/meta-oe/recipes-core/packagegroups/packagegroup-meta-oe.bb b/meta-oe/recipes-core/packagegroups/packagegroup-meta-oe.bb
index 47ee3099a..b03525de3 100644
--- a/meta-oe/recipes-core/packagegroups/packagegroup-meta-oe.bb
+++ b/meta-oe/recipes-core/packagegroups/packagegroup-meta-oe.bb
@@ -668,7 +668,6 @@ RDEPENDS:packagegroup-meta-oe-multimedia ="\
     live555-examples \
     live555-mediaserver \
     libmikmod \
-    opus-tools \
     libmodplug \
     sound-theme-freedesktop \
     yavta \
diff --git a/meta-oe/recipes-multimedia/opus-tools/opus-tools_0.1.8.bb b/meta-oe/recipes-multimedia/opus-tools/opus-tools_0.1.8.bb
deleted file mode 100644
index a84f2bf07..000000000
--- a/meta-oe/recipes-multimedia/opus-tools/opus-tools_0.1.8.bb
+++ /dev/null
@@ -1,15 +0,0 @@
-SUMMARY = "Opus Audio Tools"
-HOMEPAGE = "http://www.opus-codec.org/"
-
-LICENSE = "BSD-2-Clause"
-LIC_FILES_CHKSUM = "file://COPYING;md5=843a066da9f1facfcc6ea6f616ffecb1"
-
-SRC_URI = "http://downloads.xiph.org/releases/opus/opus-tools-${PV}.tar.gz"
-SRC_URI[md5sum] = "b424790eda9357a4df394e2d7ca19eac"
-SRC_URI[sha256sum] = "e4e188579ea1c4e4d5066460d4a7214a7eafe3539e9a4466fdc98af41ba4a2f6"
-
-S = "${WORKDIR}/opus-tools-${PV}"
-
-DEPENDS = "libopus flac"
-
-inherit autotools pkgconfig
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [oe] [meta-oe][PATCH] opus-tools: update to 0.2 and fix license
  2021-08-11 18:15     ` Khem Raj
@ 2021-08-12 17:13       ` Michael Opdenacker
  0 siblings, 0 replies; 6+ messages in thread
From: Michael Opdenacker @ 2021-08-12 17:13 UTC (permalink / raw)
  To: Khem Raj; +Cc: openembeded-devel

Hi Khem,

On 8/11/21 8:15 PM, Khem Raj wrote:
> On Wed, Aug 11, 2021 at 11:12 AM Michael Opdenacker
> <michael.opdenacker@bootlin.com> wrote:
>>
>> I'll be happy to.
>> However, what's really the difference between meta-oe/recipes-multimedia
>> and meta-multimedia/recipes-multimedia/? Why two different directories
>> in the same repository?
> these are two different layers, someone may not use meta-multimedia if
> its not in bblayers.conf
> and thusly not see the dir under meta-multimedia, so tools/packages
> which are media related
> but more or less generic go into meta-oe/recipe-multimedia, which this
> upgrade now depends
> on packages in meta-multimedia so its better to put it in meta-multimedia now


Thank you for the clarification. Now I understand that "meta-oe" is
rather for generic packages (outside of oe-core, of course), and the
other layers are for more specific purposes.

Cheers,
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-08-12 17:13 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-10 13:18 [meta-oe][PATCH] opus-tools: update to 0.2 and fix license Michael Opdenacker
2021-08-11 17:23 ` [oe] " Khem Raj
2021-08-11 18:12   ` Michael Opdenacker
2021-08-11 18:15     ` Khem Raj
2021-08-12 17:13       ` Michael Opdenacker
2021-08-12 17:04   ` [meta-oe][PATCH v2] opus-tools: update to 0.2, move to meta-multimedia " Michael Opdenacker

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.