From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A4A2C4338F for ; Tue, 10 Aug 2021 13:21:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3226560F38 for ; Tue, 10 Aug 2021 13:21:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240846AbhHJNWR (ORCPT ); Tue, 10 Aug 2021 09:22:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:43524 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241248AbhHJNVv (ORCPT ); Tue, 10 Aug 2021 09:21:51 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 57CE260F38; Tue, 10 Aug 2021 13:21:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628601690; bh=jqyHZ175J/Gvvs023uqRUmo52RsbbfMGvn++lpbF66s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I+a4GHR4h1dHtT1sJaTfvsu8J2/xAVbb8xQvxOWtAZkgpn26IlUZ/GFV/gaQYEbGV lPxKHhT2GkVeHO6Xwvno6jh1lBza6SRE8pvMIqH/Rh3wl/+LCzNUK1nQLQxcfO7Bba OId6prpx1+pskLJVHqM3W0VaZjMdN8WDujnwOd3kKK1QTuEpqYAuV6pbX9s1+MQicX 6re4qQcHFaRDpWO4wq6WRcP7bMmn/hi7L5k3sc+yZ107nm1nFUWIC4C12AEM3i4um6 q3JD/05M7BgrMyMwt5l72dUcXFqH1rrruzEzn0A08IFety7rDlp8ODT2jTXG7z6MLr PoAnqpxa3E6pw== Date: Tue, 10 Aug 2021 14:21:24 +0100 From: Will Deacon To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] KVM: arm64: Drop init_common_resources() Message-ID: <20210810132123.GB2946@willie-the-truck> References: <1628578961-29097-1-git-send-email-anshuman.khandual@arm.com> <1628578961-29097-3-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1628578961-29097-3-git-send-email-anshuman.khandual@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 10, 2021 at 12:32:38PM +0530, Anshuman Khandual wrote: > Could do without this additional indirection via init_common_resources() by > just calling kvm_set_ipa_limit() directly instead. This change saves memory > and cycles. Does it? Really? Will > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > index e9a2b8f27792..19560e457c11 100644 > --- a/arch/arm64/kvm/arm.c > +++ b/arch/arm64/kvm/arm.c > @@ -1696,11 +1696,6 @@ static bool init_psci_relay(void) > return true; > } > > -static int init_common_resources(void) > -{ > - return kvm_set_ipa_limit(); > -} > - > static int init_subsystems(void) > { > int err = 0; > @@ -2102,7 +2097,7 @@ int kvm_arch_init(void *opaque) > } > } > > - err = init_common_resources(); > + err = kvm_set_ipa_limit(); > if (err) > return err; > > -- > 2.20.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F35AC4338F for ; Tue, 10 Aug 2021 13:21:40 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id B327361008 for ; Tue, 10 Aug 2021 13:21:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B327361008 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 370CC4A483; Tue, 10 Aug 2021 09:21:39 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ONY8D4ker6EW; Tue, 10 Aug 2021 09:21:33 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id CCFB54A3A3; Tue, 10 Aug 2021 09:21:33 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 03D474A3A3 for ; Tue, 10 Aug 2021 09:21:32 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h6vIpnCpy0Ot for ; Tue, 10 Aug 2021 09:21:31 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 2002C4A19F for ; Tue, 10 Aug 2021 09:21:31 -0400 (EDT) Received: by mail.kernel.org (Postfix) with ESMTPSA id 57CE260F38; Tue, 10 Aug 2021 13:21:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628601690; bh=jqyHZ175J/Gvvs023uqRUmo52RsbbfMGvn++lpbF66s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I+a4GHR4h1dHtT1sJaTfvsu8J2/xAVbb8xQvxOWtAZkgpn26IlUZ/GFV/gaQYEbGV lPxKHhT2GkVeHO6Xwvno6jh1lBza6SRE8pvMIqH/Rh3wl/+LCzNUK1nQLQxcfO7Bba OId6prpx1+pskLJVHqM3W0VaZjMdN8WDujnwOd3kKK1QTuEpqYAuV6pbX9s1+MQicX 6re4qQcHFaRDpWO4wq6WRcP7bMmn/hi7L5k3sc+yZ107nm1nFUWIC4C12AEM3i4um6 q3JD/05M7BgrMyMwt5l72dUcXFqH1rrruzEzn0A08IFety7rDlp8ODT2jTXG7z6MLr PoAnqpxa3E6pw== Date: Tue, 10 Aug 2021 14:21:24 +0100 From: Will Deacon To: Anshuman Khandual Subject: Re: [PATCH 2/5] KVM: arm64: Drop init_common_resources() Message-ID: <20210810132123.GB2946@willie-the-truck> References: <1628578961-29097-1-git-send-email-anshuman.khandual@arm.com> <1628578961-29097-3-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1628578961-29097-3-git-send-email-anshuman.khandual@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Marc Zyngier , linux-kernel@vger.kernel.org, Catalin Marinas , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Tue, Aug 10, 2021 at 12:32:38PM +0530, Anshuman Khandual wrote: > Could do without this additional indirection via init_common_resources() by > just calling kvm_set_ipa_limit() directly instead. This change saves memory > and cycles. Does it? Really? Will > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > index e9a2b8f27792..19560e457c11 100644 > --- a/arch/arm64/kvm/arm.c > +++ b/arch/arm64/kvm/arm.c > @@ -1696,11 +1696,6 @@ static bool init_psci_relay(void) > return true; > } > > -static int init_common_resources(void) > -{ > - return kvm_set_ipa_limit(); > -} > - > static int init_subsystems(void) > { > int err = 0; > @@ -2102,7 +2097,7 @@ int kvm_arch_init(void *opaque) > } > } > > - err = init_common_resources(); > + err = kvm_set_ipa_limit(); > if (err) > return err; > > -- > 2.20.1 > _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5BFBC432BE for ; Tue, 10 Aug 2021 13:25:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AEF4761008 for ; Tue, 10 Aug 2021 13:25:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AEF4761008 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NzyHrfqwp/dK5XMWCAXqHTS+DMJfjnpsa9AOvrJxTTk=; b=mwv9dh8l+EBZQK KQo69xTk86sb53Aub2hZNzvPhhy+qh5TBTUfH/yovvLSnFAWbscp7ktXppezRCS+ob23e+5upTiCj x6RIAED1J+sJKEy9Yusp2zUyiNIs2EaJRASybUDGq7FX33QPOISr4sj/k7fdQ18RDtPcJlPsMXRcj ztv40zk71K+YlFSD7q12wRi6JjDU92uzL/QBVyGwc4DJ9H2r7Oq5JY/QfJbOmrSE9/8a/abTsIWvr kClJQ9b8EzZ7cXvL1a7TtCsFEbFPfKa7bPoStOFBtPrblE3XW2rLxV4dA1foncHdxszXvHpQH/JQW 3Lq6Hl6DzDDIMbrueUOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDRhH-003w7l-2g; Tue, 10 Aug 2021 13:21:35 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDRhC-003w6D-9s for linux-arm-kernel@lists.infradead.org; Tue, 10 Aug 2021 13:21:32 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 57CE260F38; Tue, 10 Aug 2021 13:21:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628601690; bh=jqyHZ175J/Gvvs023uqRUmo52RsbbfMGvn++lpbF66s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I+a4GHR4h1dHtT1sJaTfvsu8J2/xAVbb8xQvxOWtAZkgpn26IlUZ/GFV/gaQYEbGV lPxKHhT2GkVeHO6Xwvno6jh1lBza6SRE8pvMIqH/Rh3wl/+LCzNUK1nQLQxcfO7Bba OId6prpx1+pskLJVHqM3W0VaZjMdN8WDujnwOd3kKK1QTuEpqYAuV6pbX9s1+MQicX 6re4qQcHFaRDpWO4wq6WRcP7bMmn/hi7L5k3sc+yZ107nm1nFUWIC4C12AEM3i4um6 q3JD/05M7BgrMyMwt5l72dUcXFqH1rrruzEzn0A08IFety7rDlp8ODT2jTXG7z6MLr PoAnqpxa3E6pw== Date: Tue, 10 Aug 2021 14:21:24 +0100 From: Will Deacon To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] KVM: arm64: Drop init_common_resources() Message-ID: <20210810132123.GB2946@willie-the-truck> References: <1628578961-29097-1-git-send-email-anshuman.khandual@arm.com> <1628578961-29097-3-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1628578961-29097-3-git-send-email-anshuman.khandual@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210810_062130_418665_20857F5E X-CRM114-Status: GOOD ( 11.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 10, 2021 at 12:32:38PM +0530, Anshuman Khandual wrote: > Could do without this additional indirection via init_common_resources() by > just calling kvm_set_ipa_limit() directly instead. This change saves memory > and cycles. Does it? Really? Will > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > index e9a2b8f27792..19560e457c11 100644 > --- a/arch/arm64/kvm/arm.c > +++ b/arch/arm64/kvm/arm.c > @@ -1696,11 +1696,6 @@ static bool init_psci_relay(void) > return true; > } > > -static int init_common_resources(void) > -{ > - return kvm_set_ipa_limit(); > -} > - > static int init_subsystems(void) > { > int err = 0; > @@ -2102,7 +2097,7 @@ int kvm_arch_init(void *opaque) > } > } > > - err = init_common_resources(); > + err = kvm_set_ipa_limit(); > if (err) > return err; > > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel