From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49F89C4338F for ; Tue, 10 Aug 2021 16:39:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1CD9660F41 for ; Tue, 10 Aug 2021 16:39:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235455AbhHJQjr (ORCPT ); Tue, 10 Aug 2021 12:39:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:52086 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230410AbhHJQjr (ORCPT ); Tue, 10 Aug 2021 12:39:47 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 08A1060041; Tue, 10 Aug 2021 16:39:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628613564; bh=pt+PGt+C0GTfdvz8hMl07lVk7abqx9GVd6wHBkWheks=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JR/2Y3bxYSVRYUtQwOGCrm/2nlqFhjOtGgKu/oL1OUrPgIb4GpT/TzgjqiSBiH5gf O6HvlD+IvCE918VV8+kVv+9HsHIAtWXJ1jMpvZ0duFderkNjsQaCwiHq2mVJ2nKZ3M qgHT4+HnWSEFHg5iV2zOKrTzBOeX6esNG6gNCMSlUQtiZB29f8a4kHLWFi8sOXQ2W0 euOXF0shsKmLG68AEwdXyRLZLEzcKm+SJvfPfFPy6BL5g0Kl7fGCl3zPCJPeuQAr0I nFeIDzZZblpxjoSwbtUhxF2293qXaZZm0yBUPxFJRGeotRA0iBBUYEpgWk8rBztOHJ uK2z8jHKPdv4w== Date: Tue, 10 Aug 2021 18:39:14 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Ian Pilcher Cc: Greg KH , axboe@kernel.dk, kernelnewbies@kernelnewbies.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, pavel@ucw.cz, pali@kernel.org, hch@lst.de, linux-leds@vger.kernel.org Subject: Re: [RFC PATCH v2 00/10] Add configurable block device LED triggers Message-ID: <20210810183914.47727056@thinkpad> In-Reply-To: References: <20210809033217.1113444-1-arequipeno@gmail.com> <20210809205633.4300bbea@thinkpad> <81c128a1-c1b8-0f1e-a77b-6704bade26c0@gmail.com> <20210810004331.0f0094a5@thinkpad> <7b5f3509-5bcd-388b-8d3b-4ea95a9483ad@gmail.com> <20210810153840.42419d06@thinkpad> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Tue, 10 Aug 2021 18:24:12 +0200 Greg KH wrote: > > Sounds good. I'll work something up. (I'm actually thinking that > > class_find_device() may be the best way to go, as it grabs a reference > > to the device.) > > There should not be anything "odd" about block devices here, just do > whatever all other LED drivers do when referencing a device. Ian, look at ledtrig-tty and maybe get inspiration from there :) Marek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92287C4338F for ; Tue, 10 Aug 2021 16:39:48 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1EC1C60F41 for ; Tue, 10 Aug 2021 16:39:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1EC1C60F41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.94.2) (envelope-from ) id 1mDUmp-0005n5-C8; Tue, 10 Aug 2021 12:39:31 -0400 Received: from mail.kernel.org ([198.145.29.99]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mDUmn-0005mm-5c for kernelnewbies@kernelnewbies.org; Tue, 10 Aug 2021 12:39:29 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 08A1060041; Tue, 10 Aug 2021 16:39:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628613564; bh=pt+PGt+C0GTfdvz8hMl07lVk7abqx9GVd6wHBkWheks=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JR/2Y3bxYSVRYUtQwOGCrm/2nlqFhjOtGgKu/oL1OUrPgIb4GpT/TzgjqiSBiH5gf O6HvlD+IvCE918VV8+kVv+9HsHIAtWXJ1jMpvZ0duFderkNjsQaCwiHq2mVJ2nKZ3M qgHT4+HnWSEFHg5iV2zOKrTzBOeX6esNG6gNCMSlUQtiZB29f8a4kHLWFi8sOXQ2W0 euOXF0shsKmLG68AEwdXyRLZLEzcKm+SJvfPfFPy6BL5g0Kl7fGCl3zPCJPeuQAr0I nFeIDzZZblpxjoSwbtUhxF2293qXaZZm0yBUPxFJRGeotRA0iBBUYEpgWk8rBztOHJ uK2z8jHKPdv4w== Date: Tue, 10 Aug 2021 18:39:14 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Ian Pilcher Subject: Re: [RFC PATCH v2 00/10] Add configurable block device LED triggers Message-ID: <20210810183914.47727056@thinkpad> In-Reply-To: References: <20210809033217.1113444-1-arequipeno@gmail.com> <20210809205633.4300bbea@thinkpad> <81c128a1-c1b8-0f1e-a77b-6704bade26c0@gmail.com> <20210810004331.0f0094a5@thinkpad> <7b5f3509-5bcd-388b-8d3b-4ea95a9483ad@gmail.com> <20210810153840.42419d06@thinkpad> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Cc: axboe@kernel.dk, kernelnewbies@kernelnewbies.org, Greg KH , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, pavel@ucw.cz, pali@kernel.org, hch@lst.de, linux-leds@vger.kernel.org X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kernelnewbies-bounces@kernelnewbies.org On Tue, 10 Aug 2021 18:24:12 +0200 Greg KH wrote: > > Sounds good. I'll work something up. (I'm actually thinking that > > class_find_device() may be the best way to go, as it grabs a reference > > to the device.) > > There should not be anything "odd" about block devices here, just do > whatever all other LED drivers do when referencing a device. Ian, look at ledtrig-tty and maybe get inspiration from there :) Marek _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies