From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EC5FC4338F for ; Tue, 10 Aug 2021 18:56:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 07F5160F13 for ; Tue, 10 Aug 2021 18:56:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231753AbhHJS5K (ORCPT ); Tue, 10 Aug 2021 14:57:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:53003 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230351AbhHJS5J (ORCPT ); Tue, 10 Aug 2021 14:57:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628621807; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v76VOxsokd0mSV5ZPY9TpeuYqmlLz6EMYRsxAWqLLcU=; b=HbL27tbZvT2z+WrHy1wqEX5o9y5DnLlPo5zBgSELPNH9BHoGBWmvJCoFQ4D0jPVihMH34+ qX71j2EuZs/2NOb0xsmrBVd9LoTuEpdlOYgcWJhZZhoTHN6dcDbwJvJg66CL/YixClRYta aAjom0VmkKWY9VANx2wYnq9OA3FqXrw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-294-94J7-OEHPA2mCk-0TaMo4Q-1; Tue, 10 Aug 2021 14:56:46 -0400 X-MC-Unique: 94J7-OEHPA2mCk-0TaMo4Q-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id ECA95100E422; Tue, 10 Aug 2021 18:56:44 +0000 (UTC) Received: from localhost (unknown [10.22.32.20]) by smtp.corp.redhat.com (Postfix) with ESMTP id AF06A60BF1; Tue, 10 Aug 2021 18:56:44 +0000 (UTC) Date: Tue, 10 Aug 2021 14:56:44 -0400 From: Eduardo Habkost To: Markus Armbruster Cc: Valeriy Vdovin , qemu-devel@nongnu.org, Marcel Apfelbaum , Eric Blake , Paolo Bonzini , Marcelo Tosatti , Richard Henderson , Thomas Huth , Laurent Vivier , kvm@vger.kernel.org, Denis Lunev , Vladimir Sementsov-Ogievskiy Subject: Re: [PATCH v12] qapi: introduce 'query-x86-cpuid' QMP command. Message-ID: <20210810185644.iyqt3iao2qdqd5jk@habkost.net> References: <20210728125402.2496-1-valeriy.vdovin@virtuozzo.com> <87eeb59vwt.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87eeb59vwt.fsf@dusky.pond.sub.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Sat, Aug 07, 2021 at 04:22:42PM +0200, Markus Armbruster wrote: > Is this intended to be a stable interface? Interfaces intended just for > debugging usually aren't. I don't think we need to make it a stable interface, but I won't mind if we declare it stable. > > Eduardo, what's your take on this version? > I sent my comments as reply to v14: https://lore.kernel.org/qemu-devel/20210810185245.kivvmrmvew6e5xtr@habkost.net/ -- Eduardo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D181C4338F for ; Tue, 10 Aug 2021 18:58:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2AE760F38 for ; Tue, 10 Aug 2021 18:57:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E2AE760F38 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:43840 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDWwo-0005Qe-Q0 for qemu-devel@archiver.kernel.org; Tue, 10 Aug 2021 14:57:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33288) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDWvh-0004iC-GB for qemu-devel@nongnu.org; Tue, 10 Aug 2021 14:56:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:59422) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDWvf-0007LE-VV for qemu-devel@nongnu.org; Tue, 10 Aug 2021 14:56:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628621807; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v76VOxsokd0mSV5ZPY9TpeuYqmlLz6EMYRsxAWqLLcU=; b=HbL27tbZvT2z+WrHy1wqEX5o9y5DnLlPo5zBgSELPNH9BHoGBWmvJCoFQ4D0jPVihMH34+ qX71j2EuZs/2NOb0xsmrBVd9LoTuEpdlOYgcWJhZZhoTHN6dcDbwJvJg66CL/YixClRYta aAjom0VmkKWY9VANx2wYnq9OA3FqXrw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-294-94J7-OEHPA2mCk-0TaMo4Q-1; Tue, 10 Aug 2021 14:56:46 -0400 X-MC-Unique: 94J7-OEHPA2mCk-0TaMo4Q-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id ECA95100E422; Tue, 10 Aug 2021 18:56:44 +0000 (UTC) Received: from localhost (unknown [10.22.32.20]) by smtp.corp.redhat.com (Postfix) with ESMTP id AF06A60BF1; Tue, 10 Aug 2021 18:56:44 +0000 (UTC) Date: Tue, 10 Aug 2021 14:56:44 -0400 From: Eduardo Habkost To: Markus Armbruster Subject: Re: [PATCH v12] qapi: introduce 'query-x86-cpuid' QMP command. Message-ID: <20210810185644.iyqt3iao2qdqd5jk@habkost.net> References: <20210728125402.2496-1-valeriy.vdovin@virtuozzo.com> <87eeb59vwt.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87eeb59vwt.fsf@dusky.pond.sub.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Received-SPF: pass client-ip=170.10.133.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.704, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Vladimir Sementsov-Ogievskiy , kvm@vger.kernel.org, Marcelo Tosatti , Richard Henderson , qemu-devel@nongnu.org, Valeriy Vdovin , Denis Lunev , Paolo Bonzini , Eric Blake Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sat, Aug 07, 2021 at 04:22:42PM +0200, Markus Armbruster wrote: > Is this intended to be a stable interface? Interfaces intended just for > debugging usually aren't. I don't think we need to make it a stable interface, but I won't mind if we declare it stable. > > Eduardo, what's your take on this version? > I sent my comments as reply to v14: https://lore.kernel.org/qemu-devel/20210810185245.kivvmrmvew6e5xtr@habkost.net/ -- Eduardo