From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EE01C4338F for ; Tue, 10 Aug 2021 19:11:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C7B161008 for ; Tue, 10 Aug 2021 19:11:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230351AbhHJTLy (ORCPT ); Tue, 10 Aug 2021 15:11:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:38250 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230295AbhHJTLx (ORCPT ); Tue, 10 Aug 2021 15:11:53 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6818860FC4; Tue, 10 Aug 2021 19:11:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628622691; bh=CSSjXc+ias6km71bXVLyaS8iBHWrBpJbYfwzxVj4v5E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HgoGvl3DD1zbWIMPTvKGMH6PoCQW3JBAk5w1MzhLWXgKsXa9by624ZGYeAICJsyC4 qPH9zdX+1+dt3KvbBdH8G+Egks7nrxpZLv7inqkUM9t37cINJZ+Plu9DTmrWo+kCR2 xJNOXke3AdQIG00NAzZI3Pd1Nvq7PNtp56az2KFGQKKbs2qOXZ9VtHyxXd85dIXJ9n Svl5i1L2ED7sSsC6FyHAdHY02/NVBzBq2MgZvkDfdZBApftoieb6hX4Opu02HJKa8a /Uk8ebogLP4KrRqBKRXe9K0jGibkZILNmoBcDQApYFuzdjpvRDR1l+IS8u0tVLcFQa oxLbXGNPTf3uw== Received: by pali.im (Postfix) id 2336F82D; Tue, 10 Aug 2021 21:11:29 +0200 (CEST) Date: Tue, 10 Aug 2021 21:11:28 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: "Michael Kerrisk (man-pages)" Cc: Alejandro Colomar , linux-man@vger.kernel.org Subject: Re: [PATCH 13/23] ioctl_tty.2: Document ioctls: TCGETS2, TCSETS2, TCSETSW2, TCSETSF2 Message-ID: <20210810191128.qcn552brlrjdrqus@pali> References: <20210808084133.734274-1-alx.manpages@gmail.com> <20210808084133.734274-14-alx.manpages@gmail.com> <7a378d4c-36a5-be42-79fb-aeb1c160984c@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7a378d4c-36a5-be42-79fb-aeb1c160984c@gmail.com> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-man@vger.kernel.org On Sunday 08 August 2021 22:56:55 Michael Kerrisk (man-pages) wrote: > Hello Pali and Alex, > > On 8/8/21 10:41 AM, Alejandro Colomar wrote: > > From: Pali Rohár > > > > Signed-off-by: Pali Rohár > > Signed-off-by: Alejandro Colomar > > --- > > man2/ioctl_tty.2 | 29 +++++++++++++++++++++++++++++ > > 1 file changed, 29 insertions(+) > > > > diff --git a/man2/ioctl_tty.2 b/man2/ioctl_tty.2 > > index 46294e63f..967b5c4c7 100644 > > --- a/man2/ioctl_tty.2 > > +++ b/man2/ioctl_tty.2 > > @@ -77,6 +77,35 @@ The following four ioctls are just like > > .BR TCSETSW , > > .BR TCSETSF , > > except that they take a > > +.I "struct termios2\ *" > > +instead of a > > +.IR "struct termios\ *" . > > +If struct member > > +.B c_cflag > > +contains > > +.B BOTHER > > +then baudrate is stored in struct members > > +.B c_ispeed > > +and > > +.B c_ospeed > > +as integer values. > > +These ioctls are not supported on all architectures. > > +.RS > > +.TS > > +lb l. > > +TCGETS2 \fBstruct termios2 *\fPargp > > +TCSETS2 \fBconst struct termios2 *\fPargp > > +TCSETSW2 \fBconst struct termios2 *\fPargp > > +TCSETSF2 \fBconst struct termios2 *\fPargp > > +.TE > > +.RE > > +.PP > > +The following four ioctls are just like > > +.BR TCGETS , > > +.BR TCSETS , > > +.BR TCSETSW , > > +.BR TCSETSF , > > +except that they take a > > .I "struct termio\ *" > > instead of a > > .IR "struct termios\ *" . > > The Linux man-pages generally try to maintain historical and > version info (at least back as far as 2.6.0), so I applied > the patch below. > > Thanks, > > Michael > > commit 48a486dddefa20cddbc83610cf582acecf23e2b3 (HEAD -> master) > Author: Michael Kerrisk > Date: Sun Aug 8 22:54:29 2021 +0200 > > ioctl_tty.2: Note kernel version that added TCGETS2, TCSETS2, TCSETSW2, and TCSETSF2 > > Signed-off-by: Michael Kerrisk > > diff --git a/man2/ioctl_tty.2 b/man2/ioctl_tty.2 > index 9854cfd3f..1d9a6dee1 100644 > --- a/man2/ioctl_tty.2 > +++ b/man2/ioctl_tty.2 > @@ -71,7 +71,10 @@ Equivalent to > Allow the output buffer to drain, discard pending input, and > set the current serial port settings. > .PP > -The following four ioctls are just like > +The following four ioctls, added in Linux 2.6.20, > +.\" commit 64bb6c5e1ddcd47c951740485026ef08975ee2e6 > +.\" commit 592ee3a5e5e2a981ef2829a0380093006d045661 > +are just like > .BR TCGETS , > .BR TCSETS , > .BR TCSETSW , Hello Michael! Seems that you applied patches to your tree incorrectly. Now ioctl TCGETS2 is documented two times, looks like you have applied my commit two times. Open 'man ./man2/ioctl_tty.2' and search for TCGETS2.