From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3D7CC432BE for ; Wed, 11 Aug 2021 03:37:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A784360F11 for ; Wed, 11 Aug 2021 03:37:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233408AbhHKDhe (ORCPT ); Tue, 10 Aug 2021 23:37:34 -0400 Received: from esa6.hgst.iphmx.com ([216.71.154.45]:34648 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233066AbhHKDha (ORCPT ); Tue, 10 Aug 2021 23:37:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1628653027; x=1660189027; h=from:to:subject:date:message-id:mime-version: content-transfer-encoding; bh=TWCAljC1dx1YD2EZP0iY2/a0tIzDQsxuj/cNzvYBxDk=; b=S4aQe5TWV0YSLNbmOJWlfcTmzTNuLdS9DVVjmuIL9xs0pmr2ybQX4Y7f QfskoDZbZDwi20/sr9T0M4g5f1lo2aqpp/oG/Rm1KhKY2QViJkqCTvQA8 NVz/7DZp/tRjrK4CHUS71WpN6CQS5MyLhlnXhxwJNTDnWKY0DTFNszxNL q+fPCvXx6H2zQXRjg/pyujbgNYXF29EiP3NSA8vXk6hZacncAc+teFZqJ JOb4Pm+OYSm8fb8bJrBWTD8A29q6K4FpSHwgGqDKF92HeZbIU4GuLuM3Y d4PgS6kQ9RxKEGrzx/qYgzMB80KQRAIxRLZb+9qUnhhoz7e+ZMnTAQrkC Q==; X-IronPort-AV: E=Sophos;i="5.84,311,1620662400"; d="scan'208";a="177454810" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 11 Aug 2021 11:37:05 +0800 IronPort-SDR: eoI9uDyeSIUFN5Igx5kyyAWTB0+Ig6i82nVD7ND6fuxhPPXZqUrB/7YxxYMuOeXyQ5FSuKyCMZ SDID/uphZbxKuPNJ1/3CC68JBIfnFK2pMXJJoLr5EueHRHlJu+2XnPaPLqG+zArSRnNrA3lefL diMGh45uBWvZyS3/7i+SSAXF+NmGu2B0fa9ScfrM8i2lGet2trblxkdOqJ1GEfHyrvuk0VgBPw JAxZ4MsvhxNYhTk82npo+rsW4WBBuVkDAREXijsKJuBPCYKLvBF/C4AC3UqG6jbkDd9VO1iXom EgjUlN8mwOtyTH+6KFeqI26r Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2021 20:14:25 -0700 IronPort-SDR: qWpNUjsACDhWC0msNjVZw2DqXZyL+GyC++rO9ZylPLgNjE1KBjvCC62fAc32e19T3FsN+ZCZsu Pr48HgqwZDP4ZYVne5Nuca5zS16ItAZ8fqKM65JdcrAVTi4H7KV0BtsNDaBU7w6ZyS+r/WWbvZ LrycWVM9okuAhx5b33/B8rggnCgOpoD0xT20orIZGlCyA9aNFx8u80j82BvqIrfLZzlr1ayPPu S+W6WGje+933Bu4FDeEhV7q+VxkfS5do7VnmhFjTdnnDF5TduzOjvQmPuSGqrDcAklhwJcdFPK vzY= WDCIronportException: Internal Received: from washi.fujisawa.hgst.com ([10.149.53.254]) by uls-op-cesaip02.wdc.com with ESMTP; 10 Aug 2021 20:37:03 -0700 From: Damien Le Moal To: Jens Axboe , linux-block@vger.kernel.org, Paolo Valente , linux-f2fs-devel@lists.sourceforge.net, Jaegeuk Kim , Chao Yu Subject: [PATCH v4 0/6] IO priority fixes and improvements Date: Wed, 11 Aug 2021 12:36:56 +0900 Message-Id: <20210811033702.368488-1-damien.lemoal@wdc.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org This series fixes problems with IO priority values handling and cleans up several macro names and code for clarity. Changes from v3: * Split former patch 2 into patches 2, 3 and 4 to facilitate review and have more descriptive commit titles. * In patch 5, keep IOPRIO_BE_NR as an alias for the new IOPRIO_NR_LEVELS macro. Change this patch title and commit message accordingly. * In patch 6, define IOPRIO_BE_NORM as an alias of IOPRIO_NORM. Changes from v2: * Fixed typo in a comment in patch 3 * Added reviewed-by tags Changes from v1: * Added patch 4 to unify the default priority value used in various places. * Fixed patch 2 as suggested by Bart: remove extra parenthesis and move ioprio_valid() from the uapi header to the kernel header. * In patch 2, add priority value masking. Damien Le Moal (6): block: bfq: fix bfq_set_next_ioprio_data() block: improve ioprio class description comment block: change ioprio_valid() to an inline function block: fix IOPRIO_PRIO_CLASS() and IOPRIO_PRIO_VALUE() macros block: Introduce IOPRIO_NR_LEVELS block: fix default IO priority handling block/bfq-iosched.c | 10 +++++----- block/bfq-iosched.h | 4 ++-- block/bfq-wf2q.c | 6 +++--- block/ioprio.c | 9 ++++----- drivers/nvme/host/lightnvm.c | 2 +- fs/f2fs/sysfs.c | 2 +- include/linux/ioprio.h | 17 ++++++++++++++++- include/uapi/linux/ioprio.h | 34 ++++++++++++++++++++-------------- 8 files changed, 52 insertions(+), 32 deletions(-) -- 2.31.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF517C4320A for ; Wed, 11 Aug 2021 03:47:02 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 851FF60F22; Wed, 11 Aug 2021 03:47:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 851FF60F22 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=wdc.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.92.3) (envelope-from ) id 1mDfCo-0003wm-6U; Wed, 11 Aug 2021 03:47:02 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) (envelope-from ) id 1mDf3Q-0003g2-QW for linux-f2fs-devel@lists.sourceforge.net; Wed, 11 Aug 2021 03:37:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=iO2KLmW0AKdZBbf0VK15dXKGD5RQUMXf+w2bYuc++yU=; b=KN+D2CnN3tpQlbS49PYJKJJapy ltpNjZ/jrAkTaB7VDqP/hYAjcM1v8eE8972J9Nq84WMNeVG3MEl8jKolVURoov0mV16I3/7oP4NzM ikwSUBZSEV3p8+L8htzvw1iFmKp0mKFzMHQEchKEawNlm5bf/ongxzGmAQ80AMvywWB4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=iO2KLmW0AKdZBbf0VK15dXKGD5RQUMXf+w2bYuc++yU=; b=n QfOuUughzlGKSlRoeTShHuYz3Yge47QqFqEdC5GqMnu04KO0Pgk2fJqIfQeNEqRoI1Z1L8ZFEd5Vu s+3cpUpYsQGMnAX9aXLEz089UsrYY0nzgIktkaxN9CuDJEUTmQ8W3x7faikop8h0umeRvKwLHjpCB +u0BYMs++uuTQtAs=; Received: from esa5.hgst.iphmx.com ([216.71.153.144]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1mDf3L-0002eF-T8 for linux-f2fs-devel@lists.sourceforge.net; Wed, 11 Aug 2021 03:37:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1628653035; x=1660189035; h=from:to:subject:date:message-id:mime-version: content-transfer-encoding; bh=TWCAljC1dx1YD2EZP0iY2/a0tIzDQsxuj/cNzvYBxDk=; b=Q4SNC+DKYNUfwr+L8IncY36zn8OHk6DACJRyumWMPIl0V3P1MHGJE61K tElznKhrbWi5+AaBJ0LPHvvFVtIh03RznJF9ze5hIciYwOKgrX/Ss5HtV zmuDZoysoO9TZL6C2FhuNLMhITJ9iXhL5/d5JqxQSl7eZ/1B4L0OjWhw7 yUZ4Hucw3Y1bM1yYw+Z5o/fuA3JpWYta30FQ6Hq2gluwBcYaxYRcHjqYK 1a2bBns6pVAbkwUTaibcZXShkxI8JJ4ZtsnzP4C3dM1I9uNf+NbNDKvJw PoRvqnnnMYl/Or9b8bbHaAQbU2lVYPVnOc0kVCOZREq0C3U09qkO+pUgr w==; X-IronPort-AV: E=Sophos;i="5.84,311,1620662400"; d="scan'208";a="176890892" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 11 Aug 2021 11:37:04 +0800 IronPort-SDR: iGssvDEPwreAIeQa9I3lPvQeSV2ZX40gIy7cbX4+Lpv+jD1IV1xKxUP4fObaJ53n6HZhEAztEY 3uweGcetr3bBGhgA4vKmwD7WA/pRb6AuaTdjPRlTpZQxW2lhCF9wQtyk8sRHrAV+uv+atGujWL yCpovRXFRlDQOeSk8w/k9ff64xnN8pdnlHF6sF7ZVANmlGRqsziFjwPT06Jwi7rO4PGrD5tux2 2Er1SEOBe4/ZwrWdUf2dNsdFMtfzkMitl7ZKmVLD7CuInsYrjkQV8GTm8E7o9mibI8U1/+i40U Ry+R4YVWweq0NukW+v42VeEO Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2021 20:12:35 -0700 IronPort-SDR: qWpNUjsACDhWC0msNjVZw2DqXZyL+GyC++rO9ZylPLgNjE1KBjvCC62fAc32e19T3FsN+ZCZsu Pr48HgqwZDP4ZYVne5Nuca5zS16ItAZ8fqKM65JdcrAVTi4H7KV0BtsNDaBU7w6ZyS+r/WWbvZ LrycWVM9okuAhx5b33/B8rggnCgOpoD0xT20orIZGlCyA9aNFx8u80j82BvqIrfLZzlr1ayPPu S+W6WGje+933Bu4FDeEhV7q+VxkfS5do7VnmhFjTdnnDF5TduzOjvQmPuSGqrDcAklhwJcdFPK vzY= WDCIronportException: Internal Received: from washi.fujisawa.hgst.com ([10.149.53.254]) by uls-op-cesaip02.wdc.com with ESMTP; 10 Aug 2021 20:37:03 -0700 From: Damien Le Moal To: Jens Axboe , linux-block@vger.kernel.org, Paolo Valente , linux-f2fs-devel@lists.sourceforge.net, Jaegeuk Kim , Chao Yu Date: Wed, 11 Aug 2021 12:36:56 +0900 Message-Id: <20210811033702.368488-1-damien.lemoal@wdc.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Headers-End: 1mDf3L-0002eF-T8 Subject: [f2fs-dev] [PATCH v4 0/6] IO priority fixes and improvements X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net This series fixes problems with IO priority values handling and cleans up several macro names and code for clarity. Changes from v3: * Split former patch 2 into patches 2, 3 and 4 to facilitate review and have more descriptive commit titles. * In patch 5, keep IOPRIO_BE_NR as an alias for the new IOPRIO_NR_LEVELS macro. Change this patch title and commit message accordingly. * In patch 6, define IOPRIO_BE_NORM as an alias of IOPRIO_NORM. Changes from v2: * Fixed typo in a comment in patch 3 * Added reviewed-by tags Changes from v1: * Added patch 4 to unify the default priority value used in various places. * Fixed patch 2 as suggested by Bart: remove extra parenthesis and move ioprio_valid() from the uapi header to the kernel header. * In patch 2, add priority value masking. Damien Le Moal (6): block: bfq: fix bfq_set_next_ioprio_data() block: improve ioprio class description comment block: change ioprio_valid() to an inline function block: fix IOPRIO_PRIO_CLASS() and IOPRIO_PRIO_VALUE() macros block: Introduce IOPRIO_NR_LEVELS block: fix default IO priority handling block/bfq-iosched.c | 10 +++++----- block/bfq-iosched.h | 4 ++-- block/bfq-wf2q.c | 6 +++--- block/ioprio.c | 9 ++++----- drivers/nvme/host/lightnvm.c | 2 +- fs/f2fs/sysfs.c | 2 +- include/linux/ioprio.h | 17 ++++++++++++++++- include/uapi/linux/ioprio.h | 34 ++++++++++++++++++++-------------- 8 files changed, 52 insertions(+), 32 deletions(-) -- 2.31.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel