From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9EFFC4320A for ; Wed, 11 Aug 2021 05:34:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9118D6056C for ; Wed, 11 Aug 2021 05:34:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234386AbhHKFed (ORCPT ); Wed, 11 Aug 2021 01:34:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234330AbhHKFed (ORCPT ); Wed, 11 Aug 2021 01:34:33 -0400 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1C2CC061798 for ; Tue, 10 Aug 2021 22:34:09 -0700 (PDT) Received: by mail-pl1-x62a.google.com with SMTP id d1so1232653pll.1 for ; Tue, 10 Aug 2021 22:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ScSbxJofNLIiJut+toTZ7USozFNrpn/9FRU/yhxl+AE=; b=eb6WOqa/iiW+lVxPN/WwlN1ktVPrT2bUzlrRfDrYo41IvDzG4/ln5yWs6uXhICalPc 8R0u5AzW7yMU6cYgS+wfVr1wFhPcTBbZD2Xyd4b7nHZ3hafixxLtxxbPGwpJLDHfRGdI zsU9bV0uTcH4s9YjyKyk3RwVbO/HStRc+oKgUx5B2+8G9pO8KCbN0SSodCkkTKH5OwCj NkEi8tGAip3xqqCWY5Cd5cCb4jacmdKEE4+LxGNZA+sGwQu085Zzb25vTOg1ndLK0z5V r4ejQRIY4GkBb+GZRhHuNkrSOOBP5ZQyuytbggBbhP7/xyVm24hsXA8Zo39boZpUz10E Ygng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ScSbxJofNLIiJut+toTZ7USozFNrpn/9FRU/yhxl+AE=; b=kUL4FpzEmER42hNtHv8jLM7wuE6ETbbCRcl4LVffPf6hai7kAAkfJstDrHJ/q7Sbr0 TRlSdfcRLmxwgmw9YjkSsGT5PH3T7AhrN7SiqlClOIXH2xc6PxXfsxIbK4C62WgR3s7O xNX4uH7dM5oQiPBPCFsId4giAXTrfHF/jwtEanhY77nI9ofKNpnRiDQV+cccfBXRkiJE ktVtG37ghhO4KNmbLrcHSjQvRDBaCA+v48HiYEPpUJELGq1MFWzVjFvTh2zSdLW5Tdmt iuQcWCv0B+thgpw8XVap/5BbKTinK2EOmZ6RhPK8ngB65C1D9lihoHa3XRcIX0wh3XKF hiDg== X-Gm-Message-State: AOAM532HpmKTKu8l7r9c1VUSEVddezW0bUPGmVZaVulbg0o0FwBCCqmY PSHoCSd89J/7kZxvxNwgZpT/Ow== X-Google-Smtp-Source: ABdhPJyJHzEP2u8Lqj/aaTrSt5nOj9C159L82xQKicF/GaJrGfuVo5tn/qTlGn31FvoW9cEaqP30pg== X-Received: by 2002:a17:902:8507:b029:12b:533e:5e9d with SMTP id bj7-20020a1709028507b029012b533e5e9dmr28394940plb.53.1628660049321; Tue, 10 Aug 2021 22:34:09 -0700 (PDT) Received: from localhost ([122.172.201.85]) by smtp.gmail.com with ESMTPSA id q4sm6443106pga.48.2021.08.10.22.34.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Aug 2021 22:34:08 -0700 (PDT) Date: Wed, 11 Aug 2021 11:04:06 +0530 From: Viresh Kumar To: Quentin Perret Cc: Rafael Wysocki , Vincent Donnefort , lukasz.luba@arm.com, Andy Gross , Bjorn Andersson , Cristian Marussi , Fabio Estevam , Kevin Hilman , Matthias Brugger , NXP Linux Team , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , Sudeep Holla , linux-pm@vger.kernel.org, Vincent Guittot , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-omap@vger.kernel.org Subject: Re: [PATCH 0/8] cpufreq: Auto-register with energy model Message-ID: <20210811053406.jqwextgtnxhgsjd2@vireshk-i7> References: <20210811051859.ihjzhvrnuct2knvy@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210811051859.ihjzhvrnuct2knvy@vireshk-i7> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 11-08-21, 10:48, Viresh Kumar wrote: > On 10-08-21, 13:35, Quentin Perret wrote: > > This series adds more code than it removes, > > Sadly yes :( > > > and the unregistration is > > not a fix as we don't ever remove the EM tables by design, so not sure > > either of these points are valid arguments. > > I think that design needs to be looked over again, it looks broken to > me everytime I land onto this code. I wonder why we don't unregister > stuff. Coming back to this series. We have two options, based on what I proposed here: https://lore.kernel.org/linux-pm/20210811050327.3yxrk4kqxjjwaztx@vireshk-i7/ 1. Let cpufreq core register with EM on behalf of cpufreq drivers. 2. Update drivers to use ->ready() callback to do this stuff. I am fine with both :) -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F30BC4338F for ; Wed, 11 Aug 2021 05:34:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE6BC60FA0 for ; Wed, 11 Aug 2021 05:34:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AE6BC60FA0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9MOeGI+W2NGVp/bqDdIIt9x8e+TZxYi0Bfq/PmbWO/I=; b=12/1JXptRZVXOy PbUKl4q3tVEnPWJPO1mZfqGwFcuhMpvgVzFehnfrNXLpaFKkTCFAOmlc+zUbbSuNnCUPo4iC68EoK VGj6uj4fnMhRAfEGyztBP+IJDdr98VXuHJzQ4l+1lP9ypM1wgphm8v+13GY8SKt9Ig/0Kx2LuRPK9 MCCojo6aMjCJG63FCq53lQ5fxlZDMpTeU5f2FhJMET225OggWSNHFrchtQDTUgKEZKh5Avn7KyenB bPZ05VBqNQPjinlJ+zr7U4nr9lsa2nIY4Wlc0v/kk7f6bH1tNmNo7bb+9XB6vecLNJriobin64s4r k5U50fktN968HyQjKBBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDgsZ-005e3I-IF; Wed, 11 Aug 2021 05:34:15 +0000 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDgsU-005e21-7Y for linux-mediatek@lists.infradead.org; Wed, 11 Aug 2021 05:34:14 +0000 Received: by mail-pj1-x1029.google.com with SMTP id mq2-20020a17090b3802b0290178911d298bso2883903pjb.1 for ; Tue, 10 Aug 2021 22:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ScSbxJofNLIiJut+toTZ7USozFNrpn/9FRU/yhxl+AE=; b=eb6WOqa/iiW+lVxPN/WwlN1ktVPrT2bUzlrRfDrYo41IvDzG4/ln5yWs6uXhICalPc 8R0u5AzW7yMU6cYgS+wfVr1wFhPcTBbZD2Xyd4b7nHZ3hafixxLtxxbPGwpJLDHfRGdI zsU9bV0uTcH4s9YjyKyk3RwVbO/HStRc+oKgUx5B2+8G9pO8KCbN0SSodCkkTKH5OwCj NkEi8tGAip3xqqCWY5Cd5cCb4jacmdKEE4+LxGNZA+sGwQu085Zzb25vTOg1ndLK0z5V r4ejQRIY4GkBb+GZRhHuNkrSOOBP5ZQyuytbggBbhP7/xyVm24hsXA8Zo39boZpUz10E Ygng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ScSbxJofNLIiJut+toTZ7USozFNrpn/9FRU/yhxl+AE=; b=H7q7eKlIC0AWBjewCIqFjLsXvU7X7AD932bE//YsovoCEAB909+iDgJKj44S89qPkl D3g6L3C8Qf5IU3K7MqhwNR3M0F1yt6AhxZ2kZk6woQ7ZX/1xj8c/sus+VfXtRAdymoj6 itHMifNeYc0udFezBzsh4SXCbWXjsGdKghhCBNR2OG594vsREzCKx+dW6CR2vQ8kBdbE rlRZeiczGWcdIxWGuLQqE77a00d2LCQhLOO3KvIY10p3h3cg5yi4YrvXcJPkLUza5LMJ 8EqLUfhHfqZVR1GC0QTbrmfgfVa6eHTSTLD4Thn7IvYSK7Aluur9okD6joosR4N7YPH3 dzOw== X-Gm-Message-State: AOAM532mNSH/ICQ/BcanAgo7jP0mu24YwPtZnkula2kZ5G8fLNwPpG0G +YlaznMmKl94nAsyVBGFU9X4Ww== X-Google-Smtp-Source: ABdhPJyJHzEP2u8Lqj/aaTrSt5nOj9C159L82xQKicF/GaJrGfuVo5tn/qTlGn31FvoW9cEaqP30pg== X-Received: by 2002:a17:902:8507:b029:12b:533e:5e9d with SMTP id bj7-20020a1709028507b029012b533e5e9dmr28394940plb.53.1628660049321; Tue, 10 Aug 2021 22:34:09 -0700 (PDT) Received: from localhost ([122.172.201.85]) by smtp.gmail.com with ESMTPSA id q4sm6443106pga.48.2021.08.10.22.34.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Aug 2021 22:34:08 -0700 (PDT) Date: Wed, 11 Aug 2021 11:04:06 +0530 From: Viresh Kumar To: Quentin Perret Cc: Rafael Wysocki , Vincent Donnefort , lukasz.luba@arm.com, Andy Gross , Bjorn Andersson , Cristian Marussi , Fabio Estevam , Kevin Hilman , Matthias Brugger , NXP Linux Team , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , Sudeep Holla , linux-pm@vger.kernel.org, Vincent Guittot , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-omap@vger.kernel.org Subject: Re: [PATCH 0/8] cpufreq: Auto-register with energy model Message-ID: <20210811053406.jqwextgtnxhgsjd2@vireshk-i7> References: <20210811051859.ihjzhvrnuct2knvy@vireshk-i7> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210811051859.ihjzhvrnuct2knvy@vireshk-i7> User-Agent: NeoMutt/20180716-391-311a52 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210810_223410_443615_7227545E X-CRM114-Status: GOOD ( 14.98 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 11-08-21, 10:48, Viresh Kumar wrote: > On 10-08-21, 13:35, Quentin Perret wrote: > > This series adds more code than it removes, > > Sadly yes :( > > > and the unregistration is > > not a fix as we don't ever remove the EM tables by design, so not sure > > either of these points are valid arguments. > > I think that design needs to be looked over again, it looks broken to > me everytime I land onto this code. I wonder why we don't unregister > stuff. Coming back to this series. We have two options, based on what I proposed here: https://lore.kernel.org/linux-pm/20210811050327.3yxrk4kqxjjwaztx@vireshk-i7/ 1. Let cpufreq core register with EM on behalf of cpufreq drivers. 2. Update drivers to use ->ready() callback to do this stuff. I am fine with both :) -- viresh _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A83B8C4338F for ; Wed, 11 Aug 2021 05:36:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F5A06056C for ; Wed, 11 Aug 2021 05:36:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6F5A06056C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LGvI2DXhMopKD+B+lMKyaIXFbOFKBT7/eNQrnJkxt5g=; b=erF3ct0QDwxE1V 0cKkzR2vBOfnhLQXATlg+q1Ra5MKXrPZTtkr6GDrgiY9kBwIzNIzT72xc8frQjomgbl1ADJXw7yix toDspuPVc6SXSQljdE7iNL7aArfkn+fv79IEFVXKyLHKWIu0CSQOqEdPJvyy2biYKf4Ow+5dLRPoc iXWdgNMbp9D5XW25qdNOlVOLtxjQHBNFEZf0zPXQGP7FphKvGQ/GFBT4+PnZdz/xG05hp5YGkdYkd EhzuxPY6mOVHlgJPAhBrPeTU5WlFR+NuBqhwBZzJHTuJQTP+b4CCw1lbJUiGUAbxO1pe45v27x9Td iv1MaLySP/aGqnRnc0cA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDgsb-005e3U-ET; Wed, 11 Aug 2021 05:34:17 +0000 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDgsU-005e22-7W for linux-arm-kernel@lists.infradead.org; Wed, 11 Aug 2021 05:34:14 +0000 Received: by mail-pj1-x102d.google.com with SMTP id gz13-20020a17090b0ecdb0290178c0e0ce8bso4934745pjb.1 for ; Tue, 10 Aug 2021 22:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ScSbxJofNLIiJut+toTZ7USozFNrpn/9FRU/yhxl+AE=; b=eb6WOqa/iiW+lVxPN/WwlN1ktVPrT2bUzlrRfDrYo41IvDzG4/ln5yWs6uXhICalPc 8R0u5AzW7yMU6cYgS+wfVr1wFhPcTBbZD2Xyd4b7nHZ3hafixxLtxxbPGwpJLDHfRGdI zsU9bV0uTcH4s9YjyKyk3RwVbO/HStRc+oKgUx5B2+8G9pO8KCbN0SSodCkkTKH5OwCj NkEi8tGAip3xqqCWY5Cd5cCb4jacmdKEE4+LxGNZA+sGwQu085Zzb25vTOg1ndLK0z5V r4ejQRIY4GkBb+GZRhHuNkrSOOBP5ZQyuytbggBbhP7/xyVm24hsXA8Zo39boZpUz10E Ygng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ScSbxJofNLIiJut+toTZ7USozFNrpn/9FRU/yhxl+AE=; b=eoCkj4gK+GWrUlGFHqWdjWCutItO9GV4mnyhfy5yrzAm1d8mCylbbO7o3Oty6nZy4A hl1IYnLz5shJs8Rq6a2dNuJM0uJv+XXFy93ANKzwdNcZPaoVCh/wwygMiahxQAdtHgt2 FyPL6s1wdA6VjspjUExWHHjiaJRsCuOfo3GLQbArkvQR1TTS+jzLcL0y41V2mhARsurN gjgvXaq22u5F0xAMn3Qil0mod1M3J1nDkYmjLzefkVZXCN12ezI8yt0ScTv3tWm1BuHf 7PHCmU6ETJe6ONO63voA93u6pNjlKBXL3WiW38lciYDAwiWu9CPjXNGpE38FjHXj6B2A 9AaA== X-Gm-Message-State: AOAM533kTbK7JXsyhByBbyCYxzB/ki9z63JqHLHPDeqqad0kbPIoJJ55 Ef93u4vjlm2i/w3TUoPZkrhzSg== X-Google-Smtp-Source: ABdhPJyJHzEP2u8Lqj/aaTrSt5nOj9C159L82xQKicF/GaJrGfuVo5tn/qTlGn31FvoW9cEaqP30pg== X-Received: by 2002:a17:902:8507:b029:12b:533e:5e9d with SMTP id bj7-20020a1709028507b029012b533e5e9dmr28394940plb.53.1628660049321; Tue, 10 Aug 2021 22:34:09 -0700 (PDT) Received: from localhost ([122.172.201.85]) by smtp.gmail.com with ESMTPSA id q4sm6443106pga.48.2021.08.10.22.34.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Aug 2021 22:34:08 -0700 (PDT) Date: Wed, 11 Aug 2021 11:04:06 +0530 From: Viresh Kumar To: Quentin Perret Cc: Rafael Wysocki , Vincent Donnefort , lukasz.luba@arm.com, Andy Gross , Bjorn Andersson , Cristian Marussi , Fabio Estevam , Kevin Hilman , Matthias Brugger , NXP Linux Team , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , Sudeep Holla , linux-pm@vger.kernel.org, Vincent Guittot , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-omap@vger.kernel.org Subject: Re: [PATCH 0/8] cpufreq: Auto-register with energy model Message-ID: <20210811053406.jqwextgtnxhgsjd2@vireshk-i7> References: <20210811051859.ihjzhvrnuct2knvy@vireshk-i7> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210811051859.ihjzhvrnuct2knvy@vireshk-i7> User-Agent: NeoMutt/20180716-391-311a52 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210810_223410_443604_D15D6C04 X-CRM114-Status: GOOD ( 16.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11-08-21, 10:48, Viresh Kumar wrote: > On 10-08-21, 13:35, Quentin Perret wrote: > > This series adds more code than it removes, > > Sadly yes :( > > > and the unregistration is > > not a fix as we don't ever remove the EM tables by design, so not sure > > either of these points are valid arguments. > > I think that design needs to be looked over again, it looks broken to > me everytime I land onto this code. I wonder why we don't unregister > stuff. Coming back to this series. We have two options, based on what I proposed here: https://lore.kernel.org/linux-pm/20210811050327.3yxrk4kqxjjwaztx@vireshk-i7/ 1. Let cpufreq core register with EM on behalf of cpufreq drivers. 2. Update drivers to use ->ready() callback to do this stuff. I am fine with both :) -- viresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel