From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83293C4338F for ; Wed, 11 Aug 2021 14:35:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 581A760F55 for ; Wed, 11 Aug 2021 14:35:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232386AbhHKOft (ORCPT ); Wed, 11 Aug 2021 10:35:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:52776 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232298AbhHKOfs (ORCPT ); Wed, 11 Aug 2021 10:35:48 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4F227604AC; Wed, 11 Aug 2021 14:35:24 +0000 (UTC) Date: Wed, 11 Aug 2021 10:35:22 -0400 From: Steven Rostedt To: LKML Cc: Ingo Molnar , Andrew Morton , Tom Zanussi , Masami Hiramatsu Subject: Re: [PATCH] tracing / histogram: Fix NULL pointer dereference on strcmp() on NULL event name Message-ID: <20210811103522.0cac5f1a@oasis.local.home> In-Reply-To: <20210808003011.4037f8d0@oasis.local.home> References: <20210808003011.4037f8d0@oasis.local.home> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 8 Aug 2021 00:30:11 -0400 Steven Rostedt wrote: > diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c > index 949ef09dc537..a48aa2a2875b 100644 > --- a/kernel/trace/trace_events_hist.c > +++ b/kernel/trace/trace_events_hist.c > @@ -3430,6 +3430,8 @@ trace_action_create_field_var(struct hist_trigger_data *hist_data, > event = data->match_data.event; > } > > + if (!event) > + goto free; > /* > * At this point, we're looking at a field on another > * event. Because we can't modify a hist trigger on > -- Tom, Is this OK? I'm going to start running this through my tests and when it's done, I'm going to send it off to Linus. -- Steve