From: Gal Pressman <galpress@amazon.com> To: Jason Gunthorpe <jgg@nvidia.com>, Doug Ledford <dledford@redhat.com> Cc: <linux-rdma@vger.kernel.org>, Alexander Matushevsky <matua@amazon.com>, Gal Pressman <galpress@amazon.com>, Firas JahJah <firasj@amazon.com>, Yossi Leybovich <sleybo@amazon.com> Subject: [PATCH for-next 3/4] RDMA/efa: Rename vector field in efa_irq struct to irqn Date: Wed, 11 Aug 2021 18:11:30 +0300 [thread overview] Message-ID: <20210811151131.39138-4-galpress@amazon.com> (raw) In-Reply-To: <20210811151131.39138-1-galpress@amazon.com> The vector field naming is quite confusing, it is better referred to as irqn. Reviewed-by: Firas JahJah <firasj@amazon.com> Reviewed-by: Yossi Leybovich <sleybo@amazon.com> Signed-off-by: Gal Pressman <galpress@amazon.com> --- drivers/infiniband/hw/efa/efa.h | 2 +- drivers/infiniband/hw/efa/efa_main.c | 18 ++++++++---------- 2 files changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/infiniband/hw/efa/efa.h b/drivers/infiniband/hw/efa/efa.h index 1148b308d3f6..87b1dadeb7fe 100644 --- a/drivers/infiniband/hw/efa/efa.h +++ b/drivers/infiniband/hw/efa/efa.h @@ -27,7 +27,7 @@ struct efa_irq { irq_handler_t handler; void *data; - u32 vector; + u32 irqn; cpumask_t affinity_hint_mask; char name[EFA_IRQNAME_SIZE]; }; diff --git a/drivers/infiniband/hw/efa/efa_main.c b/drivers/infiniband/hw/efa/efa_main.c index 5b2fcfe9be20..417dea5f90cf 100644 --- a/drivers/infiniband/hw/efa/efa_main.c +++ b/drivers/infiniband/hw/efa/efa_main.c @@ -83,8 +83,7 @@ static int efa_request_mgmnt_irq(struct efa_dev *dev) int err; irq = &dev->admin_irq; - err = request_irq(irq->vector, irq->handler, 0, irq->name, - irq->data); + err = request_irq(irq->irqn, irq->handler, 0, irq->name, irq->data); if (err) { dev_err(&dev->pdev->dev, "Failed to request admin irq (%d)\n", err); @@ -92,8 +91,8 @@ static int efa_request_mgmnt_irq(struct efa_dev *dev) } dev_dbg(&dev->pdev->dev, "Set affinity hint of mgmnt irq to %*pbl (irq vector: %d)\n", - nr_cpumask_bits, &irq->affinity_hint_mask, irq->vector); - irq_set_affinity_hint(irq->vector, &irq->affinity_hint_mask); + nr_cpumask_bits, &irq->affinity_hint_mask, irq->irqn); + irq_set_affinity_hint(irq->irqn, &irq->affinity_hint_mask); return 0; } @@ -106,14 +105,13 @@ static void efa_setup_mgmnt_irq(struct efa_dev *dev) "efa-mgmnt@pci:%s", pci_name(dev->pdev)); dev->admin_irq.handler = efa_intr_msix_mgmnt; dev->admin_irq.data = dev; - dev->admin_irq.vector = + dev->admin_irq.irqn = pci_irq_vector(dev->pdev, dev->admin_msix_vector_idx); cpu = cpumask_first(cpu_online_mask); cpumask_set_cpu(cpu, &dev->admin_irq.affinity_hint_mask); - dev_info(&dev->pdev->dev, "Setup irq:0x%p vector:%d name:%s\n", - &dev->admin_irq, - dev->admin_irq.vector, + dev_info(&dev->pdev->dev, "Setup irq:%d name:%s\n", + dev->admin_irq.irqn, dev->admin_irq.name); } @@ -122,8 +120,8 @@ static void efa_free_mgmnt_irq(struct efa_dev *dev) struct efa_irq *irq; irq = &dev->admin_irq; - irq_set_affinity_hint(irq->vector, NULL); - free_irq(irq->vector, irq->data); + irq_set_affinity_hint(irq->irqn, NULL); + free_irq(irq->irqn, irq->data); } static int efa_set_mgmnt_irq(struct efa_dev *dev) -- 2.32.0
next prev parent reply other threads:[~2021-08-11 15:12 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-11 15:11 [PATCH for-next 0/4] EFA CQ notifications Gal Pressman 2021-08-11 15:11 ` [PATCH for-next 1/4] RDMA/efa: Free IRQ vectors on error flow Gal Pressman 2021-08-20 18:34 ` Jason Gunthorpe 2021-08-11 15:11 ` [PATCH for-next 2/4] RDMA/efa: Remove unused cpu field from irq struct Gal Pressman 2021-08-11 15:11 ` Gal Pressman [this message] 2021-08-11 15:11 ` [PATCH for-next 4/4] RDMA/efa: CQ notifications Gal Pressman 2021-08-20 18:27 ` Jason Gunthorpe 2021-09-01 11:50 ` Gal Pressman 2021-09-01 11:57 ` Jason Gunthorpe 2021-09-01 14:24 ` Gal Pressman 2021-09-01 15:36 ` Jason Gunthorpe 2021-09-02 7:03 ` Gal Pressman 2021-09-02 13:02 ` Jason Gunthorpe 2021-09-02 15:09 ` Gal Pressman 2021-09-02 15:10 ` Jason Gunthorpe 2021-09-02 15:17 ` Gal Pressman 2021-09-02 15:41 ` Jason Gunthorpe 2021-09-05 7:25 ` Gal Pressman 2021-09-05 7:59 ` Leon Romanovsky 2021-09-05 10:45 ` Gal Pressman 2021-09-05 10:54 ` Leon Romanovsky 2021-09-05 11:05 ` Gal Pressman 2021-09-05 13:14 ` Leon Romanovsky 2021-09-05 14:36 ` Gal Pressman 2021-09-07 11:31 ` Jason Gunthorpe 2021-09-09 11:00 ` Gal Pressman 2021-08-20 18:36 ` [PATCH for-next 0/4] EFA " Jason Gunthorpe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210811151131.39138-4-galpress@amazon.com \ --to=galpress@amazon.com \ --cc=dledford@redhat.com \ --cc=firasj@amazon.com \ --cc=jgg@nvidia.com \ --cc=linux-rdma@vger.kernel.org \ --cc=matua@amazon.com \ --cc=sleybo@amazon.com \ --subject='Re: [PATCH for-next 3/4] RDMA/efa: Rename vector field in efa_irq struct to irqn' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.