All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC PATCH v2 net-next 3/8] net: dsa: remove the "dsa_to_port in a loop" antipattern from drivers
Date: Wed, 11 Aug 2021 16:57:10 +0800	[thread overview]
Message-ID: <202108111624.MPXlwM1K-lkp@intel.com> (raw)
In-Reply-To: <20210810161448.1879192-4-vladimir.oltean@nxp.com>

[-- Attachment #1: Type: text/plain, Size: 4367 bytes --]

Hi Vladimir,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Vladimir-Oltean/Remove-the-dsa_to_port-in-a-loop-antipattern/20210811-002035
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 4ef3960ea19c3b2bced37405b251f05fd4b35545
config: x86_64-randconfig-a016-20210810 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project d39ebdae674c8efc84ebe8dc32716ec353220530)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/ed3baa791b1827372c9df651fca62a9152f2c852
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Vladimir-Oltean/Remove-the-dsa_to_port-in-a-loop-antipattern/20210811-002035
        git checkout ed3baa791b1827372c9df651fca62a9152f2c852
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/dsa/mv88e6xxx/chip.c:2009:44: warning: variable 'port' is uninitialized when used here [-Wuninitialized]
                   err = mv88e6xxx_port_add_broadcast(chip, port, vid);
                                                            ^~~~
   drivers/net/dsa/mv88e6xxx/chip.c:1996:10: note: initialize the variable 'port' to silence this warning
           int port;
                   ^
                    = 0
   1 warning generated.
--
>> drivers/net/dsa/sja1105/sja1105_main.c:394:37: warning: variable 'port' is uninitialized when used here [-Wuninitialized]
                   default_l2_lookup_params.maxaddrp[port] = max_fdb_entries;
                                                     ^~~~
   drivers/net/dsa/sja1105/sja1105_main.c:383:10: note: initialize the variable 'port' to silence this warning
           int port, num_used_ports = 0;
                   ^
                    = 0
   1 warning generated.


vim +/port +2009 drivers/net/dsa/mv88e6xxx/chip.c

87fa886e1fb7d0 Andrew Lunn       2017-11-09  1991  
87fa886e1fb7d0 Andrew Lunn       2017-11-09  1992  static int mv88e6xxx_broadcast_setup(struct mv88e6xxx_chip *chip, u16 vid)
87fa886e1fb7d0 Andrew Lunn       2017-11-09  1993  {
ed3baa791b1827 Vladimir Oltean   2021-08-10  1994  	struct dsa_switch *ds = chip->ds;
ed3baa791b1827 Vladimir Oltean   2021-08-10  1995  	struct dsa_port *dp;
87fa886e1fb7d0 Andrew Lunn       2017-11-09  1996  	int port;
87fa886e1fb7d0 Andrew Lunn       2017-11-09  1997  	int err;
87fa886e1fb7d0 Andrew Lunn       2017-11-09  1998  
ed3baa791b1827 Vladimir Oltean   2021-08-10  1999  	dsa_switch_for_each_available_port(dp, ds) {
8d1d8298eb0075 Tobias Waldekranz 2021-03-18  2000  		struct net_device *brport;
8d1d8298eb0075 Tobias Waldekranz 2021-03-18  2001  
8d1d8298eb0075 Tobias Waldekranz 2021-03-18  2002  		brport = dsa_port_to_bridge_port(dp);
8d1d8298eb0075 Tobias Waldekranz 2021-03-18  2003  		if (brport && !br_port_flag_is_set(brport, BR_BCAST_FLOOD))
8d1d8298eb0075 Tobias Waldekranz 2021-03-18  2004  			/* Skip bridged user ports where broadcast
8d1d8298eb0075 Tobias Waldekranz 2021-03-18  2005  			 * flooding is disabled.
8d1d8298eb0075 Tobias Waldekranz 2021-03-18  2006  			 */
8d1d8298eb0075 Tobias Waldekranz 2021-03-18  2007  			continue;
8d1d8298eb0075 Tobias Waldekranz 2021-03-18  2008  
87fa886e1fb7d0 Andrew Lunn       2017-11-09 @2009  		err = mv88e6xxx_port_add_broadcast(chip, port, vid);
87fa886e1fb7d0 Andrew Lunn       2017-11-09  2010  		if (err)
87fa886e1fb7d0 Andrew Lunn       2017-11-09  2011  			return err;
87fa886e1fb7d0 Andrew Lunn       2017-11-09  2012  	}
87fa886e1fb7d0 Andrew Lunn       2017-11-09  2013  
87fa886e1fb7d0 Andrew Lunn       2017-11-09  2014  	return 0;
87fa886e1fb7d0 Andrew Lunn       2017-11-09  2015  }
87fa886e1fb7d0 Andrew Lunn       2017-11-09  2016  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 37724 bytes --]

  reply	other threads:[~2021-08-11  8:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-10 16:14 [RFC PATCH v2 net-next 0/8] Remove the "dsa_to_port in a loop" antipattern Vladimir Oltean
2021-08-10 16:14 ` [RFC PATCH v2 net-next 1/8] net: dsa: introduce a dsa_port_is_unused helper Vladimir Oltean
2021-08-10 16:14 ` [RFC PATCH v2 net-next 2/8] net: dsa: remove the "dsa_to_port in a loop" antipattern from the core Vladimir Oltean
2021-08-10 16:14 ` [RFC PATCH v2 net-next 3/8] net: dsa: remove the "dsa_to_port in a loop" antipattern from drivers Vladimir Oltean
2021-08-11  8:57   ` kernel test robot [this message]
2021-08-10 16:14 ` [RFC PATCH v2 net-next 4/8] net: dsa: b53: express b53_for_each_port in terms of dsa_switch_for_each_port Vladimir Oltean
2021-08-11  8:40   ` Florian Fainelli
2021-08-10 16:14 ` [RFC PATCH v2 net-next 5/8] net: dsa: finish conversion to dsa_switch_for_each_port Vladimir Oltean
2021-08-10 16:14 ` [RFC PATCH v2 net-next 6/8] net: dsa: remove gratuitous use of dsa_is_{user,dsa,cpu}_port Vladimir Oltean
2021-08-10 16:14 ` [RFC PATCH v2 net-next 7/8] net: dsa: convert cross-chip notifiers to iterate using dp Vladimir Oltean
2021-08-10 16:14 ` [RFC PATCH v2 net-next 8/8] net: dsa: tag_8021q: finish conversion to dsa_switch_for_each_port Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202108111624.MPXlwM1K-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.