* [PATCH] KVM: arm64: Return -EPERM from __pkvm_host_share_hyp()
@ 2021-08-11 17:36 ` Quentin Perret
0 siblings, 0 replies; 6+ messages in thread
From: Quentin Perret @ 2021-08-11 17:36 UTC (permalink / raw)
To: Marc Zyngier, James Morse, Alexandru Elisei, Suzuki K Poulose,
Catalin Marinas, Will Deacon, Quentin Perret, Fuad Tabba,
linux-arm-kernel, kvmarm, linux-kernel
Fix the error code returned by __pkvm_host_share_hyp() when the
host attempts to share with EL2 a page that has already been shared with
another entity.
Reported-by: Will Deacon <will@kernel.org>
Signed-off-by: Quentin Perret <qperret@google.com>
---
This patch fixes a bug introduced in the stage-2 ownership series which
is already queued in kvmarm/next:
https://lore.kernel.org/lkml/20210809152448.1810400-1-qperret@google.com/
I've starred at this code for hours, but that clearly was not enough. Oh
well ...
---
arch/arm64/kvm/hyp/nvhe/mem_protect.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kvm/hyp/nvhe/mem_protect.c b/arch/arm64/kvm/hyp/nvhe/mem_protect.c
index 8165390d3ec9..6ec695311498 100644
--- a/arch/arm64/kvm/hyp/nvhe/mem_protect.c
+++ b/arch/arm64/kvm/hyp/nvhe/mem_protect.c
@@ -404,7 +404,7 @@ int __pkvm_host_share_hyp(u64 pfn)
cur = kvm_pgtable_hyp_pte_prot(pte);
prot = pkvm_mkstate(PAGE_HYP, PKVM_PAGE_SHARED_BORROWED);
if (!check_prot(cur, prot, ~prot))
- ret = EPERM;
+ ret = -EPERM;
goto unlock;
map_shared:
--
2.32.0.605.g8dce9f2422-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] KVM: arm64: Return -EPERM from __pkvm_host_share_hyp()
@ 2021-08-11 17:36 ` Quentin Perret
0 siblings, 0 replies; 6+ messages in thread
From: Quentin Perret @ 2021-08-11 17:36 UTC (permalink / raw)
To: Marc Zyngier, James Morse, Alexandru Elisei, Suzuki K Poulose,
Catalin Marinas, Will Deacon, Quentin Perret, Fuad Tabba,
linux-arm-kernel, kvmarm, linux-kernel
Fix the error code returned by __pkvm_host_share_hyp() when the
host attempts to share with EL2 a page that has already been shared with
another entity.
Reported-by: Will Deacon <will@kernel.org>
Signed-off-by: Quentin Perret <qperret@google.com>
---
This patch fixes a bug introduced in the stage-2 ownership series which
is already queued in kvmarm/next:
https://lore.kernel.org/lkml/20210809152448.1810400-1-qperret@google.com/
I've starred at this code for hours, but that clearly was not enough. Oh
well ...
---
arch/arm64/kvm/hyp/nvhe/mem_protect.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kvm/hyp/nvhe/mem_protect.c b/arch/arm64/kvm/hyp/nvhe/mem_protect.c
index 8165390d3ec9..6ec695311498 100644
--- a/arch/arm64/kvm/hyp/nvhe/mem_protect.c
+++ b/arch/arm64/kvm/hyp/nvhe/mem_protect.c
@@ -404,7 +404,7 @@ int __pkvm_host_share_hyp(u64 pfn)
cur = kvm_pgtable_hyp_pte_prot(pte);
prot = pkvm_mkstate(PAGE_HYP, PKVM_PAGE_SHARED_BORROWED);
if (!check_prot(cur, prot, ~prot))
- ret = EPERM;
+ ret = -EPERM;
goto unlock;
map_shared:
--
2.32.0.605.g8dce9f2422-goog
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] KVM: arm64: Return -EPERM from __pkvm_host_share_hyp()
@ 2021-08-11 17:36 ` Quentin Perret
0 siblings, 0 replies; 6+ messages in thread
From: Quentin Perret @ 2021-08-11 17:36 UTC (permalink / raw)
To: Marc Zyngier, James Morse, Alexandru Elisei, Suzuki K Poulose,
Catalin Marinas, Will Deacon, Quentin Perret, Fuad Tabba,
linux-arm-kernel, kvmarm, linux-kernel
Fix the error code returned by __pkvm_host_share_hyp() when the
host attempts to share with EL2 a page that has already been shared with
another entity.
Reported-by: Will Deacon <will@kernel.org>
Signed-off-by: Quentin Perret <qperret@google.com>
---
This patch fixes a bug introduced in the stage-2 ownership series which
is already queued in kvmarm/next:
https://lore.kernel.org/lkml/20210809152448.1810400-1-qperret@google.com/
I've starred at this code for hours, but that clearly was not enough. Oh
well ...
---
arch/arm64/kvm/hyp/nvhe/mem_protect.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kvm/hyp/nvhe/mem_protect.c b/arch/arm64/kvm/hyp/nvhe/mem_protect.c
index 8165390d3ec9..6ec695311498 100644
--- a/arch/arm64/kvm/hyp/nvhe/mem_protect.c
+++ b/arch/arm64/kvm/hyp/nvhe/mem_protect.c
@@ -404,7 +404,7 @@ int __pkvm_host_share_hyp(u64 pfn)
cur = kvm_pgtable_hyp_pte_prot(pte);
prot = pkvm_mkstate(PAGE_HYP, PKVM_PAGE_SHARED_BORROWED);
if (!check_prot(cur, prot, ~prot))
- ret = EPERM;
+ ret = -EPERM;
goto unlock;
map_shared:
--
2.32.0.605.g8dce9f2422-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] KVM: arm64: Return -EPERM from __pkvm_host_share_hyp()
2021-08-11 17:36 ` Quentin Perret
(?)
@ 2021-08-11 18:43 ` Marc Zyngier
-1 siblings, 0 replies; 6+ messages in thread
From: Marc Zyngier @ 2021-08-11 18:43 UTC (permalink / raw)
To: linux-kernel, James Morse, kvmarm, Alexandru Elisei,
Catalin Marinas, Quentin Perret, Suzuki K Poulose,
linux-arm-kernel, Will Deacon, Fuad Tabba
On Wed, 11 Aug 2021 18:36:25 +0100, Quentin Perret wrote:
> Fix the error code returned by __pkvm_host_share_hyp() when the
> host attempts to share with EL2 a page that has already been shared with
> another entity.
Applied to next, thanks!
[1/1] KVM: arm64: Return -EPERM from __pkvm_host_share_hyp()
commit: 12593568d7319c34c72038ea799ab1bd0f0eb01c
Cheers,
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] KVM: arm64: Return -EPERM from __pkvm_host_share_hyp()
@ 2021-08-11 18:43 ` Marc Zyngier
0 siblings, 0 replies; 6+ messages in thread
From: Marc Zyngier @ 2021-08-11 18:43 UTC (permalink / raw)
To: linux-kernel, James Morse, kvmarm, Alexandru Elisei,
Catalin Marinas, Quentin Perret, Suzuki K Poulose,
linux-arm-kernel, Will Deacon, Fuad Tabba
On Wed, 11 Aug 2021 18:36:25 +0100, Quentin Perret wrote:
> Fix the error code returned by __pkvm_host_share_hyp() when the
> host attempts to share with EL2 a page that has already been shared with
> another entity.
Applied to next, thanks!
[1/1] KVM: arm64: Return -EPERM from __pkvm_host_share_hyp()
commit: 12593568d7319c34c72038ea799ab1bd0f0eb01c
Cheers,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] KVM: arm64: Return -EPERM from __pkvm_host_share_hyp()
@ 2021-08-11 18:43 ` Marc Zyngier
0 siblings, 0 replies; 6+ messages in thread
From: Marc Zyngier @ 2021-08-11 18:43 UTC (permalink / raw)
To: linux-kernel, James Morse, kvmarm, Alexandru Elisei,
Catalin Marinas, Quentin Perret, Suzuki K Poulose,
linux-arm-kernel, Will Deacon, Fuad Tabba
On Wed, 11 Aug 2021 18:36:25 +0100, Quentin Perret wrote:
> Fix the error code returned by __pkvm_host_share_hyp() when the
> host attempts to share with EL2 a page that has already been shared with
> another entity.
Applied to next, thanks!
[1/1] KVM: arm64: Return -EPERM from __pkvm_host_share_hyp()
commit: 12593568d7319c34c72038ea799ab1bd0f0eb01c
Cheers,
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-08-11 18:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-11 17:36 [PATCH] KVM: arm64: Return -EPERM from __pkvm_host_share_hyp() Quentin Perret
2021-08-11 17:36 ` Quentin Perret
2021-08-11 17:36 ` Quentin Perret
2021-08-11 18:43 ` Marc Zyngier
2021-08-11 18:43 ` Marc Zyngier
2021-08-11 18:43 ` Marc Zyngier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.