From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D889372 for ; Thu, 12 Aug 2021 06:49:24 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 39FE567373; Thu, 12 Aug 2021 08:49:15 +0200 (CEST) Date: Thu, 12 Aug 2021 08:49:14 +0200 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , Dan Williams , Matthew Wilcox , Andreas Gruenbacher , Shiyang Ruan , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, nvdimm@lists.linux.dev, cluster-devel@redhat.com Subject: Re: [PATCH 11/30] iomap: add the new iomap_iter model Message-ID: <20210812064914.GA27145@lst.de> References: <20210809061244.1196573-1-hch@lst.de> <20210809061244.1196573-12-hch@lst.de> <20210811003118.GT3601466@magnolia> <20210811053856.GA1934@lst.de> <20210811191708.GF3601443@magnolia> Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210811191708.GF3601443@magnolia> User-Agent: Mutt/1.5.17 (2007-11-01) On Wed, Aug 11, 2021 at 12:17:08PM -0700, Darrick J. Wong wrote: > > iter.c is also my preference, but in the end I don't care too much. > > Ok. My plan for this is to change this patch to add the new iter code > to apply.c, and change patch 24 to remove iomap_apply. I'll add a patch > on the end to rename apply.c to iter.c, which will avoid breaking the > history. What history? There is no shared code, so no shared history and. > > I'll send the updated patches as replies to this series to avoid > spamming the list, since I also have a patchset of bugfixes to send out > and don't want to overwhelm everyone. Just as a clear statement: I think this dance is obsfucation and doesn't help in any way. But if that's what it takes.. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Thu, 12 Aug 2021 08:49:14 +0200 Subject: [Cluster-devel] [PATCH 11/30] iomap: add the new iomap_iter model In-Reply-To: <20210811191708.GF3601443@magnolia> References: <20210809061244.1196573-1-hch@lst.de> <20210809061244.1196573-12-hch@lst.de> <20210811003118.GT3601466@magnolia> <20210811053856.GA1934@lst.de> <20210811191708.GF3601443@magnolia> Message-ID: <20210812064914.GA27145@lst.de> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Aug 11, 2021 at 12:17:08PM -0700, Darrick J. Wong wrote: > > iter.c is also my preference, but in the end I don't care too much. > > Ok. My plan for this is to change this patch to add the new iter code > to apply.c, and change patch 24 to remove iomap_apply. I'll add a patch > on the end to rename apply.c to iter.c, which will avoid breaking the > history. What history? There is no shared code, so no shared history and. > > I'll send the updated patches as replies to this series to avoid > spamming the list, since I also have a patchset of bugfixes to send out > and don't want to overwhelm everyone. Just as a clear statement: I think this dance is obsfucation and doesn't help in any way. But if that's what it takes..