From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB619C4320E for ; Thu, 12 Aug 2021 08:59:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 876106109D for ; Thu, 12 Aug 2021 08:59:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235529AbhHLI7u (ORCPT ); Thu, 12 Aug 2021 04:59:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:37778 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235234AbhHLI7u (ORCPT ); Thu, 12 Aug 2021 04:59:50 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0776160C3F; Thu, 12 Aug 2021 08:59:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628758765; bh=sjxnnAcFFQeU/Bm517XhrtWUqgRGPZPYbSW/yVHWY5s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZQj4RBz6e9t5QGtKRgT4K70zwQlVrLhg48IywHQcySOSt6rJBWxiPe3UmtVIY9fat NH6mS5vhBqHsLmQ6tKD5IqSs51Onmw2/6dpdutEG8H/+l2ze6O/epbNnQERnjeGXI9 x4t/2R52K3AH0iszsA1xjxDa3mPF28Dd9ZskGnTnCP0L7L6kcScsp8DsxeJ8SZ1RsM dlnFyiFf6Ya4QsEQXaNIgr/CCPxGaO1DhmeJFqi6dlc5c4/03lj+FSrAPV7mRpCDxe aFBNoK42mSG49sj9MSQRNKSjdN1qxzMtyUwVW6UH+i4eS82mClXtG54n8dyYNiAaHz 7mqlx7Y6mygDg== Date: Thu, 12 Aug 2021 09:59:20 +0100 From: Will Deacon To: Fuad Tabba Cc: kvmarm@lists.cs.columbia.edu, maz@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, mark.rutland@arm.com, christoffer.dall@arm.com, pbonzini@redhat.com, drjones@redhat.com, qperret@google.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-team@android.com Subject: Re: [PATCH v3 05/15] KVM: arm64: Refactor sys_regs.h,c for nVHE reuse Message-ID: <20210812085919.GD5912@willie-the-truck> References: <20210719160346.609914-1-tabba@google.com> <20210719160346.609914-6-tabba@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210719160346.609914-6-tabba@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Jul 19, 2021 at 05:03:36PM +0100, Fuad Tabba wrote: > Refactor sys_regs.h and sys_regs.c to make it easier to reuse > common code. It will be used in nVHE in a later patch. > > Note that the refactored code uses __inline_bsearch for find_reg > instead of bsearch to avoid copying the bsearch code for nVHE. > > No functional change intended. > > Signed-off-by: Fuad Tabba > --- > arch/arm64/include/asm/sysreg.h | 3 +++ > arch/arm64/kvm/sys_regs.c | 30 +----------------------------- > arch/arm64/kvm/sys_regs.h | 31 +++++++++++++++++++++++++++++++ > 3 files changed, 35 insertions(+), 29 deletions(-) With the naming change suggested by Drew: Acked-by: Will Deacon X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 965D5C4338F for ; Thu, 12 Aug 2021 08:59:34 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 0145B61058 for ; Thu, 12 Aug 2021 08:59:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0145B61058 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 9663E4A198; Thu, 12 Aug 2021 04:59:32 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dBzcvucbqaO7; Thu, 12 Aug 2021 04:59:28 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 0F2524A19E; Thu, 12 Aug 2021 04:59:28 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id F32E249E93 for ; Thu, 12 Aug 2021 04:59:26 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id J0kSVoE6eB6i for ; Thu, 12 Aug 2021 04:59:26 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 1F84A40839 for ; Thu, 12 Aug 2021 04:59:26 -0400 (EDT) Received: by mail.kernel.org (Postfix) with ESMTPSA id 0776160C3F; Thu, 12 Aug 2021 08:59:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628758765; bh=sjxnnAcFFQeU/Bm517XhrtWUqgRGPZPYbSW/yVHWY5s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZQj4RBz6e9t5QGtKRgT4K70zwQlVrLhg48IywHQcySOSt6rJBWxiPe3UmtVIY9fat NH6mS5vhBqHsLmQ6tKD5IqSs51Onmw2/6dpdutEG8H/+l2ze6O/epbNnQERnjeGXI9 x4t/2R52K3AH0iszsA1xjxDa3mPF28Dd9ZskGnTnCP0L7L6kcScsp8DsxeJ8SZ1RsM dlnFyiFf6Ya4QsEQXaNIgr/CCPxGaO1DhmeJFqi6dlc5c4/03lj+FSrAPV7mRpCDxe aFBNoK42mSG49sj9MSQRNKSjdN1qxzMtyUwVW6UH+i4eS82mClXtG54n8dyYNiAaHz 7mqlx7Y6mygDg== Date: Thu, 12 Aug 2021 09:59:20 +0100 From: Will Deacon To: Fuad Tabba Subject: Re: [PATCH v3 05/15] KVM: arm64: Refactor sys_regs.h, c for nVHE reuse Message-ID: <20210812085919.GD5912@willie-the-truck> References: <20210719160346.609914-1-tabba@google.com> <20210719160346.609914-6-tabba@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210719160346.609914-6-tabba@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: kernel-team@android.com, kvm@vger.kernel.org, maz@kernel.org, pbonzini@redhat.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Mon, Jul 19, 2021 at 05:03:36PM +0100, Fuad Tabba wrote: > Refactor sys_regs.h and sys_regs.c to make it easier to reuse > common code. It will be used in nVHE in a later patch. > > Note that the refactored code uses __inline_bsearch for find_reg > instead of bsearch to avoid copying the bsearch code for nVHE. > > No functional change intended. > > Signed-off-by: Fuad Tabba > --- > arch/arm64/include/asm/sysreg.h | 3 +++ > arch/arm64/kvm/sys_regs.c | 30 +----------------------------- > arch/arm64/kvm/sys_regs.h | 31 +++++++++++++++++++++++++++++++ > 3 files changed, 35 insertions(+), 29 deletions(-) With the naming change suggested by Drew: Acked-by: Will Deacon X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB547C4338F for ; Thu, 12 Aug 2021 09:02:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D765603E7 for ; Thu, 12 Aug 2021 09:02:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8D765603E7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sdD+e6SZDe/akZqlwh1AEFvpWvh6EtbP3xAN4atmRxs=; b=AEG8N8+W8Jo1Jj CoRVtvLmbuRX6Y0sNwjWdFvlLjWiYY/hsgsJuioHPTwjcc6x8PxVMFjyL0EaIC/ei0UFtCpyX/ltO vR7NjnQd7ucY0CL4uxBO9i79IdXLjTtvIdh7RndMMHNaGxkvKx1kv0GlrijA4U7BU1bzUOqBooUnD f+bmgfBc4TfuXW2JUPcXbgmNJSZH21rkao2DISbSe9YBciF2J5rxILg+Zyz1PvzkvqkAS5cXR7Bo1 Qe0QF6tZ8IS9DuwXh61J+rDPXMTIxrnVWaJ6porFLhz4AeyZxZCKRuyDu4UowHEyKctbPBKCn0I5v 2hgghh780P1p/pbC5ghg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mE6Yj-009Exg-QF; Thu, 12 Aug 2021 08:59:29 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mE6Yf-009Ex1-I1 for linux-arm-kernel@lists.infradead.org; Thu, 12 Aug 2021 08:59:26 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0776160C3F; Thu, 12 Aug 2021 08:59:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628758765; bh=sjxnnAcFFQeU/Bm517XhrtWUqgRGPZPYbSW/yVHWY5s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZQj4RBz6e9t5QGtKRgT4K70zwQlVrLhg48IywHQcySOSt6rJBWxiPe3UmtVIY9fat NH6mS5vhBqHsLmQ6tKD5IqSs51Onmw2/6dpdutEG8H/+l2ze6O/epbNnQERnjeGXI9 x4t/2R52K3AH0iszsA1xjxDa3mPF28Dd9ZskGnTnCP0L7L6kcScsp8DsxeJ8SZ1RsM dlnFyiFf6Ya4QsEQXaNIgr/CCPxGaO1DhmeJFqi6dlc5c4/03lj+FSrAPV7mRpCDxe aFBNoK42mSG49sj9MSQRNKSjdN1qxzMtyUwVW6UH+i4eS82mClXtG54n8dyYNiAaHz 7mqlx7Y6mygDg== Date: Thu, 12 Aug 2021 09:59:20 +0100 From: Will Deacon To: Fuad Tabba Cc: kvmarm@lists.cs.columbia.edu, maz@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, mark.rutland@arm.com, christoffer.dall@arm.com, pbonzini@redhat.com, drjones@redhat.com, qperret@google.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-team@android.com Subject: Re: [PATCH v3 05/15] KVM: arm64: Refactor sys_regs.h, c for nVHE reuse Message-ID: <20210812085919.GD5912@willie-the-truck> References: <20210719160346.609914-1-tabba@google.com> <20210719160346.609914-6-tabba@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210719160346.609914-6-tabba@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210812_015925_655932_69A2045F X-CRM114-Status: GOOD ( 12.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 19, 2021 at 05:03:36PM +0100, Fuad Tabba wrote: > Refactor sys_regs.h and sys_regs.c to make it easier to reuse > common code. It will be used in nVHE in a later patch. > > Note that the refactored code uses __inline_bsearch for find_reg > instead of bsearch to avoid copying the bsearch code for nVHE. > > No functional change intended. > > Signed-off-by: Fuad Tabba > --- > arch/arm64/include/asm/sysreg.h | 3 +++ > arch/arm64/kvm/sys_regs.c | 30 +----------------------------- > arch/arm64/kvm/sys_regs.h | 31 +++++++++++++++++++++++++++++++ > 3 files changed, 35 insertions(+), 29 deletions(-) With the naming change suggested by Drew: Acked-by: Will Deacon