From: Alex Williamson <alex.williamson@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Diana Craciun <diana.craciun@oss.nxp.com>,
Cornelia Huck <cohuck@redhat.com>,
Kirti Wankhede <kwankhede@nvidia.com>,
Eric Auger <eric.auger@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
kvm@vger.kernel.org
Subject: Re: [PATCH 05/14] vfio: refactor noiommu group creation
Date: Thu, 12 Aug 2021 09:56:14 -0600 [thread overview]
Message-ID: <20210812095614.3299d7ab.alex.williamson@redhat.com> (raw)
In-Reply-To: <20210812072617.GA28507@lst.de>
On Thu, 12 Aug 2021 09:26:17 +0200
Christoph Hellwig <hch@lst.de> wrote:
> On Wed, Aug 11, 2021 at 04:03:41PM -0600, Alex Williamson wrote:
> > > + dev_warn(dev, "Adding kernel taint for vfio-noiommu group on device\n");
> > > + return vfio_noiommu_group_alloc(dev);
> >
> > Nit, we taint regardless of the success of this function, should we
> > move the tainting back into the function (using the flags to skip for
> > mdev in subsequent patches) or swap the order to check the return value
> > before tainting? Thanks,
>
> Does it really matter to have the extra thread if a memory allocation
> failed when going down this route?
Extra thread? In practice this is unlikely to ever fail, but if we've
chosen the point at which we have a no-iommu group as where we taint,
then let's at least be consistent and not move that back to the point
where we tried to make a no-iommu group, regardless of whether it was
successful. Thanks,
Alex
next prev parent reply other threads:[~2021-08-12 15:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 15:14 cleanup vfio iommu_group creation Christoph Hellwig
2021-08-11 15:14 ` [PATCH 01/14] vfio: Move vfio_iommu_group_get() to vfio_register_group_dev() Christoph Hellwig
2021-08-11 15:14 ` [PATCH 02/14] vfio: factor out a vfio_iommu_driver_allowed helper Christoph Hellwig
2021-08-11 15:14 ` [PATCH 03/14] vfio: remove the iommudata check in vfio_noiommu_attach_group Christoph Hellwig
2021-08-11 15:14 ` [PATCH 04/14] vfio: factor out a vfio_group_find_or_alloc helper Christoph Hellwig
2021-08-11 15:14 ` [PATCH 05/14] vfio: refactor noiommu group creation Christoph Hellwig
2021-08-11 22:03 ` Alex Williamson
2021-08-12 7:26 ` Christoph Hellwig
2021-08-12 15:56 ` Alex Williamson [this message]
2021-08-12 16:14 ` Christoph Hellwig
2021-08-15 15:48 ` Christoph Hellwig
2021-08-18 23:32 ` Jason Gunthorpe
2021-08-11 15:14 ` [PATCH 06/14] vfio: remove the iommudata hack for noiommu groups Christoph Hellwig
2021-08-11 15:14 ` [PATCH 07/14] vfio: simplify iommu group allocation for mediated devices Christoph Hellwig
2021-08-11 15:14 ` [PATCH 08/14] vfio: remove unused method from vfio_iommu_driver_ops Christoph Hellwig
2021-08-11 15:14 ` [PATCH 09/14] vfio: move the vfio_iommu_driver_ops interface out of <linux/vfio.h> Christoph Hellwig
2021-08-11 15:14 ` [PATCH 10/14] vfio: remove the unused mdev iommu hook Christoph Hellwig
2021-08-11 15:14 ` [PATCH 11/14] vfio: clean up the check for mediated device in vfio_iommu_type1 Christoph Hellwig
2021-08-11 15:14 ` [PATCH 12/14] vfio/spapr_tce: reject mediated devices Christoph Hellwig
2021-08-11 15:14 ` [PATCH 13/14] vfio/iommu_type1: remove the "external" domain Christoph Hellwig
2021-08-11 15:15 ` [PATCH 14/14] vfio/iommu_type1: remove IS_IOMMU_CAP_DOMAIN_IN_CONTAINER Christoph Hellwig
2021-08-24 14:46 cleanup vfio iommu_group creation v2 Christoph Hellwig
2021-08-24 14:46 ` [PATCH 05/14] vfio: refactor noiommu group creation Christoph Hellwig
2021-08-24 23:43 ` Jason Gunthorpe
2021-08-25 16:19 cleanup vfio iommu_group creation v3 Christoph Hellwig
2021-08-25 16:19 ` [PATCH 05/14] vfio: refactor noiommu group creation Christoph Hellwig
2021-08-26 2:20 ` Tian, Kevin
2021-08-26 13:34 cleanup vfio iommu_group creation v4 Christoph Hellwig
2021-08-26 13:34 ` [PATCH 05/14] vfio: refactor noiommu group creation Christoph Hellwig
2021-08-26 22:47 ` Alex Williamson
2021-08-27 2:08 ` Tian, Kevin
2021-09-13 7:15 cleanup vfio iommu_group creation v5 Christoph Hellwig
2021-09-13 7:15 ` [PATCH 05/14] vfio: refactor noiommu group creation Christoph Hellwig
2021-09-14 2:07 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210812095614.3299d7ab.alex.williamson@redhat.com \
--to=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=diana.craciun@oss.nxp.com \
--cc=eric.auger@redhat.com \
--cc=hch@lst.de \
--cc=jgg@ziepe.ca \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.