From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2895EC432BE for ; Thu, 12 Aug 2021 12:18:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0ADF06104F for ; Thu, 12 Aug 2021 12:18:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236165AbhHLMTD (ORCPT ); Thu, 12 Aug 2021 08:19:03 -0400 Received: from verein.lst.de ([213.95.11.211]:44062 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234942AbhHLMTC (ORCPT ); Thu, 12 Aug 2021 08:19:02 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 3603667373; Thu, 12 Aug 2021 14:18:34 +0200 (CEST) Date: Thu, 12 Aug 2021 14:18:34 +0200 From: Christoph Hellwig To: David Howells Cc: willy@infradead.org, trond.myklebust@primarydata.com, darrick.wong@oracle.com, hch@lst.de, jlayton@kernel.org, sfrench@samba.org, torvalds@linux-foundation.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] mm: Fix NFS swapfiles and use DIO read for swapfiles Message-ID: <20210812121834.GA18532@lst.de> References: <162876946134.3068428.15475611190876694695.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <162876946134.3068428.15475611190876694695.stgit@warthog.procyon.org.uk> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 12, 2021 at 12:57:41PM +0100, David Howells wrote: > > Hi Willy, Trond, > > Here's a change to make reads from the swapfile use async DIO rather than > readpage(), as requested by Willy. > > Whilst trying to make this work, I found that NFS's support for swapfiles > seems to have been non-functional since Aug 2019 (I think), so the first > patch fixes that. Question is: do we actually *want* to keep this > functionality, given that it seems that no one's tested it with an upstream > kernel in the last couple of years? Independ of the NFS use using the direct I/O code for swap seems like the right thing to do in generlal. e.g. for XFS a lookup in the extent btree will be more efficient than the weird swap extent map.