From: Jan Kara <jack@suse.cz> To: kernel test robot <lkp@intel.com> Cc: Jan Kara <jack@suse.cz>, Ted Tso <tytso@mit.edu>, kbuild-all@lists.01.org, linux-ext4@vger.kernel.org, Lukas Czerner <lczerner@redhat.com> Subject: Re: [PATCH 5/5] ext4: Improve scalability of ext4 orphan file handling Date: Thu, 12 Aug 2021 14:59:26 +0200 [thread overview] Message-ID: <20210812125926.GC14675@quack2.suse.cz> (raw) In-Reply-To: <202108120223.efg5X7VY-lkp@intel.com> On Thu 12-08-21 02:19:33, kernel test robot wrote: > Hi Jan, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on ext4/dev] > [also build test WARNING on ext3/for_next linus/master v5.14-rc5 next-20210811] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Jan-Kara/ext4-Speedup-orphan-file-handling/20210811-182113 > base: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev > config: parisc-randconfig-s032-20210810 (attached as .config) > compiler: hppa-linux-gcc (GCC) 10.3.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # apt-get install sparse > # sparse version: v0.6.3-348-gf0e6938b-dirty > # https://github.com/0day-ci/linux/commit/77029a42c6e037181b218cbf10a93561e664fb9e > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Jan-Kara/ext4-Speedup-orphan-file-handling/20210811-182113 > git checkout 77029a42c6e037181b218cbf10a93561e664fb9e > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=parisc SHELL=/bin/bash fs/ext4/ > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@intel.com> > > > sparse warnings: (new ones prefixed by >>) > >> fs/ext4/orphan.c:76:18: sparse: sparse: cast from restricted __le32 > >> fs/ext4/orphan.c:76:18: sparse: sparse: cast from restricted __le32 > >> fs/ext4/orphan.c:76:18: sparse: sparse: cast to restricted __le32 ... > > 76 } while (cmpxchg(&bdata[j], 0, cpu_to_le32(inode->i_ino)) != 0); Yeah, I didn't bother to convert 0 to little endian which is tripping up sparse. I've now added explicit casts of 0 to __le32 so silence the warning. Honza -- Jan Kara <jack@suse.com> SUSE Labs, CR
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz> To: kbuild-all@lists.01.org Subject: Re: [PATCH 5/5] ext4: Improve scalability of ext4 orphan file handling Date: Thu, 12 Aug 2021 14:59:26 +0200 [thread overview] Message-ID: <20210812125926.GC14675@quack2.suse.cz> (raw) In-Reply-To: <202108120223.efg5X7VY-lkp@intel.com> [-- Attachment #1: Type: text/plain, Size: 2252 bytes --] On Thu 12-08-21 02:19:33, kernel test robot wrote: > Hi Jan, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on ext4/dev] > [also build test WARNING on ext3/for_next linus/master v5.14-rc5 next-20210811] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Jan-Kara/ext4-Speedup-orphan-file-handling/20210811-182113 > base: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev > config: parisc-randconfig-s032-20210810 (attached as .config) > compiler: hppa-linux-gcc (GCC) 10.3.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # apt-get install sparse > # sparse version: v0.6.3-348-gf0e6938b-dirty > # https://github.com/0day-ci/linux/commit/77029a42c6e037181b218cbf10a93561e664fb9e > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Jan-Kara/ext4-Speedup-orphan-file-handling/20210811-182113 > git checkout 77029a42c6e037181b218cbf10a93561e664fb9e > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=parisc SHELL=/bin/bash fs/ext4/ > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@intel.com> > > > sparse warnings: (new ones prefixed by >>) > >> fs/ext4/orphan.c:76:18: sparse: sparse: cast from restricted __le32 > >> fs/ext4/orphan.c:76:18: sparse: sparse: cast from restricted __le32 > >> fs/ext4/orphan.c:76:18: sparse: sparse: cast to restricted __le32 ... > > 76 } while (cmpxchg(&bdata[j], 0, cpu_to_le32(inode->i_ino)) != 0); Yeah, I didn't bother to convert 0 to little endian which is tripping up sparse. I've now added explicit casts of 0 to __le32 so silence the warning. Honza -- Jan Kara <jack@suse.com> SUSE Labs, CR
next prev parent reply other threads:[~2021-08-12 12:59 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-11 10:19 [PATCH 0/5 v5] ext4: Speedup orphan file handling Jan Kara 2021-08-11 10:19 ` [PATCH 1/5] ext4: Support for checksumming from journal triggers Jan Kara 2021-08-11 10:19 ` [PATCH 2/5] ext4: Move orphan inode handling into a separate file Jan Kara 2021-08-11 10:19 ` [PATCH 3/5] ext4: Speedup ext4 orphan inode handling Jan Kara 2021-08-12 15:01 ` Theodore Ts'o 2021-08-13 12:34 ` Jan Kara 2021-08-13 15:26 ` Theodore Ts'o 2021-08-16 9:23 ` Jan Kara 2021-08-11 10:19 ` [PATCH 4/5] ext4: Orphan file documentation Jan Kara 2021-08-12 15:02 ` Theodore Ts'o 2021-08-11 10:19 ` [PATCH 5/5] ext4: Improve scalability of ext4 orphan file handling Jan Kara 2021-08-11 18:19 ` kernel test robot 2021-08-11 18:19 ` kernel test robot 2021-08-12 12:59 ` Jan Kara [this message] 2021-08-12 12:59 ` Jan Kara 2021-08-12 16:48 ` Theodore Ts'o -- strict thread matches above, loose matches on Subject: below -- 2021-08-16 9:57 [PATCH 0/5 v7] ext4: Speedup " Jan Kara 2021-08-16 9:57 ` [PATCH 5/5] ext4: Improve scalability of ext4 " Jan Kara 2021-08-16 9:22 [PATCH 0/5 v6] ext4: Speedup " Jan Kara 2021-08-16 9:23 ` [PATCH 5/5] ext4: Improve scalability of ext4 " Jan Kara 2021-07-12 15:40 [PATCH 0/5 v4] ext4: Speedup " Jan Kara 2021-07-12 15:40 ` [PATCH 5/5] ext4: Improve scalability of ext4 " Jan Kara
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210812125926.GC14675@quack2.suse.cz \ --to=jack@suse.cz \ --cc=kbuild-all@lists.01.org \ --cc=lczerner@redhat.com \ --cc=linux-ext4@vger.kernel.org \ --cc=lkp@intel.com \ --cc=tytso@mit.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.