From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 196E3C4338F for ; Thu, 12 Aug 2021 12:59:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E992861059 for ; Thu, 12 Aug 2021 12:59:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232535AbhHLM7x (ORCPT ); Thu, 12 Aug 2021 08:59:53 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:33284 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232356AbhHLM7x (ORCPT ); Thu, 12 Aug 2021 08:59:53 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 7B2E722248; Thu, 12 Aug 2021 12:59:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1628773166; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lZBoi/MAdX0le88Btu7+aNPPDknu0t9R37KAGupWIIY=; b=FTmFjgw+Yq1EhrlDxg0X/g0L2B5f6nQmxctqR5CpAyU1NFcFp1pLLA3RZxaJ8eZp8Hmm4U OU4kO9xNsw9OeQXJ6nhLzRsfPLlntjE20f/AE7apbtHi3TsHi+1gtkADuufIjWuPLROqbg bgVL8voknzrE3pnnzmng0P1fTurT+9g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1628773166; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lZBoi/MAdX0le88Btu7+aNPPDknu0t9R37KAGupWIIY=; b=CS6kisMrq/AGwbVa9xO5SUy0e6IOJBRHCW5baEScSc6FnVgstR+T1OV6mU18zpbTub3KdJ vNcAHH0XyK1oTCBg== Received: from quack2.suse.cz (unknown [10.100.224.230]) by relay2.suse.de (Postfix) with ESMTP id 61683A3EF0; Thu, 12 Aug 2021 12:59:26 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 3896E1F2AC2; Thu, 12 Aug 2021 14:59:26 +0200 (CEST) Date: Thu, 12 Aug 2021 14:59:26 +0200 From: Jan Kara To: kernel test robot Cc: Jan Kara , Ted Tso , kbuild-all@lists.01.org, linux-ext4@vger.kernel.org, Lukas Czerner Subject: Re: [PATCH 5/5] ext4: Improve scalability of ext4 orphan file handling Message-ID: <20210812125926.GC14675@quack2.suse.cz> References: <20210811101925.6973-5-jack@suse.cz> <202108120223.efg5X7VY-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202108120223.efg5X7VY-lkp@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu 12-08-21 02:19:33, kernel test robot wrote: > Hi Jan, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on ext4/dev] > [also build test WARNING on ext3/for_next linus/master v5.14-rc5 next-20210811] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Jan-Kara/ext4-Speedup-orphan-file-handling/20210811-182113 > base: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev > config: parisc-randconfig-s032-20210810 (attached as .config) > compiler: hppa-linux-gcc (GCC) 10.3.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # apt-get install sparse > # sparse version: v0.6.3-348-gf0e6938b-dirty > # https://github.com/0day-ci/linux/commit/77029a42c6e037181b218cbf10a93561e664fb9e > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Jan-Kara/ext4-Speedup-orphan-file-handling/20210811-182113 > git checkout 77029a42c6e037181b218cbf10a93561e664fb9e > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=parisc SHELL=/bin/bash fs/ext4/ > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > > sparse warnings: (new ones prefixed by >>) > >> fs/ext4/orphan.c:76:18: sparse: sparse: cast from restricted __le32 > >> fs/ext4/orphan.c:76:18: sparse: sparse: cast from restricted __le32 > >> fs/ext4/orphan.c:76:18: sparse: sparse: cast to restricted __le32 ... > > 76 } while (cmpxchg(&bdata[j], 0, cpu_to_le32(inode->i_ino)) != 0); Yeah, I didn't bother to convert 0 to little endian which is tripping up sparse. I've now added explicit casts of 0 to __le32 so silence the warning. Honza -- Jan Kara SUSE Labs, CR From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============9055871605643413119==" MIME-Version: 1.0 From: Jan Kara To: kbuild-all@lists.01.org Subject: Re: [PATCH 5/5] ext4: Improve scalability of ext4 orphan file handling Date: Thu, 12 Aug 2021 14:59:26 +0200 Message-ID: <20210812125926.GC14675@quack2.suse.cz> In-Reply-To: <202108120223.efg5X7VY-lkp@intel.com> List-Id: --===============9055871605643413119== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Thu 12-08-21 02:19:33, kernel test robot wrote: > Hi Jan, > = > I love your patch! Perhaps something to improve: > = > [auto build test WARNING on ext4/dev] > [also build test WARNING on ext3/for_next linus/master v5.14-rc5 next-202= 10811] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > = > url: https://github.com/0day-ci/linux/commits/Jan-Kara/ext4-Speedup-or= phan-file-handling/20210811-182113 > base: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev > config: parisc-randconfig-s032-20210810 (attached as .config) > compiler: hppa-linux-gcc (GCC) 10.3.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbi= n/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # apt-get install sparse > # sparse version: v0.6.3-348-gf0e6938b-dirty > # https://github.com/0day-ci/linux/commit/77029a42c6e037181b218cb= f10a93561e664fb9e > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Jan-Kara/ext4-Speedup-orphan-fil= e-handling/20210811-182113 > git checkout 77029a42c6e037181b218cbf10a93561e664fb9e > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-10.3.0 make.cro= ss C=3D1 CF=3D'-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=3Dbuild_dir ARCH= =3Dparisc SHELL=3D/bin/bash fs/ext4/ > = > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > = > = > sparse warnings: (new ones prefixed by >>) > >> fs/ext4/orphan.c:76:18: sparse: sparse: cast from restricted __le32 > >> fs/ext4/orphan.c:76:18: sparse: sparse: cast from restricted __le32 > >> fs/ext4/orphan.c:76:18: sparse: sparse: cast to restricted __le32 ... > > 76 } while (cmpxchg(&bdata[j], 0, cpu_to_le32(inode->i_ino)) !=3D 0); Yeah, I didn't bother to convert 0 to little endian which is tripping up sparse. I've now added explicit casts of 0 to __le32 so silence the warning. Honza -- = Jan Kara SUSE Labs, CR --===============9055871605643413119==--