From: "Tom Rini" <trini@konsulko.com>
To: Quentin Schulz <quentin.schulz@theobroma-systems.com>
Cc: docs@lists.yoctoproject.org
Subject: Re: [docs] [PATCH 3/3] common-tasks: Add an example of using bbappends to add a file
Date: Fri, 13 Aug 2021 11:13:35 -0400 [thread overview]
Message-ID: <20210813151335.GH858@bill-the-cat> (raw)
In-Reply-To: <20210813082740.ptt5tcfchhapfm67@fedora>
On Fri, Aug 13, 2021 at 10:27:40AM +0200, Quentin Schulz wrote:
> Hi Tom,
>
> On Thu, Aug 12, 2021 at 12:10:27PM -0400, Tom Rini wrote:
[snip]
> > + FILES:${PN}:rpi += "${sysconfdir}/X11/xorg.conf ${sysconfdir}/X11/xorg.conf.d/*"
> > +
>
> Highly suspect this is wrong. It should be FILES:${PN}:append:rpi
> instead, otherwise it's completely overriding FILES:${PN} for rpi (even
> if the operator that is following is +=).
Right, so, this is not fatally wrong, re-reading the main recipe and
building it. But it's also not a best practices example, so not what
should be put in to the documentation. I'll go and get meta-raspberrypi
fixed to follow best practices and once that's merged I'll v2 this last
part, along with the rest of the feedback.
--
Tom
next prev parent reply other threads:[~2021-08-13 15:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 16:10 [PATCH 1/3] common-tasks: Add a summary to the end of the bbappend example Tom Rini
2021-08-12 16:10 ` [PATCH 2/3] manuals: Rename the "Using .bbappend Files in Your Layer" section Tom Rini
2021-08-13 8:29 ` [docs] " Quentin Schulz
2021-08-13 9:12 ` Michael Opdenacker
2021-08-12 16:10 ` [PATCH 3/3] common-tasks: Add an example of using bbappends to add a file Tom Rini
2021-08-13 8:27 ` [docs] " Quentin Schulz
2021-08-13 9:15 ` Michael Opdenacker
2021-08-13 14:40 ` Tom Rini
2021-08-13 15:13 ` Tom Rini [this message]
2021-08-13 8:16 ` [docs] [PATCH 1/3] common-tasks: Add a summary to the end of the bbappend example Michael Opdenacker
2021-08-13 8:21 ` Quentin Schulz
2021-08-13 8:28 ` Michael Opdenacker
2021-08-13 8:31 ` Quentin Schulz
2021-08-13 8:48 ` Michael Opdenacker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210813151335.GH858@bill-the-cat \
--to=trini@konsulko.com \
--cc=docs@lists.yoctoproject.org \
--cc=quentin.schulz@theobroma-systems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.