[Buildroot] [PATCH 1/1] package/fontconfig: fix per-package build with NLS

[Buildroot] [PATCH 1/1] package/fontconfig: fix per-package build with NLS

[Fabrice Fontaine]

Add TARGET_NLS_DEPENDENCIES and host-gettext dependency to avoid the
following build failure with host-cairo raised because fontconfig
installs its ITS files in the wrong directory (i.e. outside of
gettext-tiny symlink):

mkdir -p /tmp/instance-0/output-1/per-package/host-cairo/host
rsync -a --link-dest=/tmp/instance-0/output-1/per-package/host-fontconfig/host/ /tmp/instance-0/output-1/per-package/host-fontconfig/host/ /tmp/instance-0/output-1/per-package/host-cairo/host
rsync -a --link-dest=/tmp/instance-0/output-1/per-package/host-freetype/host/ /tmp/instance-0/output-1/per-package/host-freetype/host/ /tmp/instance-0/output-1/per-package/host-cairo/host
rsync -a --link-dest=/tmp/instance-0/output-1/per-package/host-libglib2/host/ /tmp/instance-0/output-1/per-package/host-libglib2/host/ /tmp/instance-0/output-1/per-package/host-cairo/host
cannot delete non-empty directory: share/gettext
could not make way for new symlink: share/gettext

Fixes:
 - http://autobuild.buildroot.org/results/00e29958cecfffa4e994ab549637117dd8f55c30

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/fontconfig/fontconfig.mk | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/package/fontconfig/fontconfig.mk b/package/fontconfig/fontconfig.mk
index d59e893d4d..e34acde534 100644
--- a/package/fontconfig/fontconfig.mk
+++ b/package/fontconfig/fontconfig.mk
@@ -11,9 +11,11 @@ FONTCONFIG_SOURCE = fontconfig-$(FONTCONFIG_VERSION).tar.bz2
 FONTCONFIG_AUTORECONF = YES
 FONTCONFIG_INSTALL_STAGING = YES
 FONTCONFIG_DEPENDENCIES = freetype expat host-pkgconf host-gperf \
-	$(if $(BR2_PACKAGE_UTIL_LINUX_LIBS),util-linux-libs,util-linux)
+	$(if $(BR2_PACKAGE_UTIL_LINUX_LIBS),util-linux-libs,util-linux) \
+	$(TARGET_NLS_DEPENDENCIES)
 HOST_FONTCONFIG_DEPENDENCIES = \
-	host-freetype host-expat host-pkgconf host-gperf host-util-linux
+	host-freetype host-expat host-pkgconf host-gperf host-util-linux \
+	host-gettext
 FONTCONFIG_LICENSE = fontconfig license
 FONTCONFIG_LICENSE_FILES = COPYING
 FONTCONFIG_CPE_ID_VENDOR = fontconfig_project
-- 
2.30.2

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/fontconfig: fix per-package build with NLS

[Thomas Petazzoni]

On Fri, 13 Aug 2021 23:16:48 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Add TARGET_NLS_DEPENDENCIES and host-gettext dependency to avoid the
> following build failure with host-cairo raised because fontconfig
> installs its ITS files in the wrong directory (i.e. outside of
> gettext-tiny symlink):
> 
> mkdir -p /tmp/instance-0/output-1/per-package/host-cairo/host
> rsync -a --link-dest=/tmp/instance-0/output-1/per-package/host-fontconfig/host/ /tmp/instance-0/output-1/per-package/host-fontconfig/host/ /tmp/instance-0/output-1/per-package/host-cairo/host
> rsync -a --link-dest=/tmp/instance-0/output-1/per-package/host-freetype/host/ /tmp/instance-0/output-1/per-package/host-freetype/host/ /tmp/instance-0/output-1/per-package/host-cairo/host
> rsync -a --link-dest=/tmp/instance-0/output-1/per-package/host-libglib2/host/ /tmp/instance-0/output-1/per-package/host-libglib2/host/ /tmp/instance-0/output-1/per-package/host-cairo/host
> cannot delete non-empty directory: share/gettext
> could not make way for new symlink: share/gettext
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/00e29958cecfffa4e994ab549637117dd8f55c30
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/fontconfig/fontconfig.mk | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Do you have some more details as to why this is specific to per-package
builds?

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/fontconfig: fix per-package build with NLS

[Fabrice Fontaine]

Le dim. 15 août 2021 à 09:25, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> a écrit :
>
> On Fri, 13 Aug 2021 23:16:48 +0200
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > Add TARGET_NLS_DEPENDENCIES and host-gettext dependency to avoid the
> > following build failure with host-cairo raised because fontconfig
> > installs its ITS files in the wrong directory (i.e. outside of
> > gettext-tiny symlink):
> >
> > mkdir -p /tmp/instance-0/output-1/per-package/host-cairo/host
> > rsync -a --link-dest=/tmp/instance-0/output-1/per-package/host-fontconfig/host/ /tmp/instance-0/output-1/per-package/host-fontconfig/host/ /tmp/instance-0/output-1/per-package/host-cairo/host
> > rsync -a --link-dest=/tmp/instance-0/output-1/per-package/host-freetype/host/ /tmp/instance-0/output-1/per-package/host-freetype/host/ /tmp/instance-0/output-1/per-package/host-cairo/host
> > rsync -a --link-dest=/tmp/instance-0/output-1/per-package/host-libglib2/host/ /tmp/instance-0/output-1/per-package/host-libglib2/host/ /tmp/instance-0/output-1/per-package/host-cairo/host
> > cannot delete non-empty directory: share/gettext
> > could not make way for new symlink: share/gettext
> >
> > Fixes:
> >  - http://autobuild.buildroot.org/results/00e29958cecfffa4e994ab549637117dd8f55c30
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> >  package/fontconfig/fontconfig.mk | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
>
> Do you have some more details as to why this is specific to per-package
> builds?
The build failure is only raised with per-package build because
per-package-rsync function in pkg-utils.mk is not able to rsync
share/gettext as gettext is a "standard" directory for fontconfig and
a symlink for other packages (e.g. libglib2).
However, even if we don't have build failures, the missing
dependencies could probably raise unexpected runtime issues with
"normal" builds.
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,

Fabrice
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/fontconfig: fix per-package build with NLS

[Arnout Vandecappelle]

On 13/08/2021 23:16, Fabrice Fontaine wrote:
> Add TARGET_NLS_DEPENDENCIES and host-gettext dependency to avoid the
> following build failure with host-cairo raised because fontconfig
> installs its ITS files in the wrong directory (i.e. outside of
> gettext-tiny symlink):
> 
> mkdir -p /tmp/instance-0/output-1/per-package/host-cairo/host
> rsync -a --link-dest=/tmp/instance-0/output-1/per-package/host-fontconfig/host/ /tmp/instance-0/output-1/per-package/host-fontconfig/host/ /tmp/instance-0/output-1/per-package/host-cairo/host
> rsync -a --link-dest=/tmp/instance-0/output-1/per-package/host-freetype/host/ /tmp/instance-0/output-1/per-package/host-freetype/host/ /tmp/instance-0/output-1/per-package/host-cairo/host
> rsync -a --link-dest=/tmp/instance-0/output-1/per-package/host-libglib2/host/ /tmp/instance-0/output-1/per-package/host-libglib2/host/ /tmp/instance-0/output-1/per-package/host-cairo/host
> cannot delete non-empty directory: share/gettext
> could not make way for new symlink: share/gettext
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/00e29958cecfffa4e994ab549637117dd8f55c30
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

 Applied to master, thanks.

 I've extended the commit message a bit to explain why it only happens with PPD.

 Regards,
 Arnout

> ---
>  package/fontconfig/fontconfig.mk | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/package/fontconfig/fontconfig.mk b/package/fontconfig/fontconfig.mk
> index d59e893d4d..e34acde534 100644
> --- a/package/fontconfig/fontconfig.mk
> +++ b/package/fontconfig/fontconfig.mk
> @@ -11,9 +11,11 @@ FONTCONFIG_SOURCE = fontconfig-$(FONTCONFIG_VERSION).tar.bz2
>  FONTCONFIG_AUTORECONF = YES
>  FONTCONFIG_INSTALL_STAGING = YES
>  FONTCONFIG_DEPENDENCIES = freetype expat host-pkgconf host-gperf \
> -	$(if $(BR2_PACKAGE_UTIL_LINUX_LIBS),util-linux-libs,util-linux)
> +	$(if $(BR2_PACKAGE_UTIL_LINUX_LIBS),util-linux-libs,util-linux) \
> +	$(TARGET_NLS_DEPENDENCIES)
>  HOST_FONTCONFIG_DEPENDENCIES = \
> -	host-freetype host-expat host-pkgconf host-gperf host-util-linux
> +	host-freetype host-expat host-pkgconf host-gperf host-util-linux \
> +	host-gettext
>  FONTCONFIG_LICENSE = fontconfig license
>  FONTCONFIG_LICENSE_FILES = COPYING
>  FONTCONFIG_CPE_ID_VENDOR = fontconfig_project
> 
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/fontconfig: fix per-package build with NLS

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Add TARGET_NLS_DEPENDENCIES and host-gettext dependency to avoid the
 > following build failure with host-cairo raised because fontconfig
 > installs its ITS files in the wrong directory (i.e. outside of
 > gettext-tiny symlink):

 > mkdir -p /tmp/instance-0/output-1/per-package/host-cairo/host
 > rsync -a
 > --link-dest=/tmp/instance-0/output-1/per-package/host-fontconfig/host/
 > /tmp/instance-0/output-1/per-package/host-fontconfig/host/
 > /tmp/instance-0/output-1/per-package/host-cairo/host
 > rsync -a
 > --link-dest=/tmp/instance-0/output-1/per-package/host-freetype/host/
 > /tmp/instance-0/output-1/per-package/host-freetype/host/
 > /tmp/instance-0/output-1/per-package/host-cairo/host
 > rsync -a
 > --link-dest=/tmp/instance-0/output-1/per-package/host-libglib2/host/
 > /tmp/instance-0/output-1/per-package/host-libglib2/host/
 > /tmp/instance-0/output-1/per-package/host-cairo/host
 > cannot delete non-empty directory: share/gettext
 > could not make way for new symlink: share/gettext

 > Fixes:
 >  - http://autobuild.buildroot.org/results/00e29958cecfffa4e994ab549637117dd8f55c30

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2021.02.x and 2021.05.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot