From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: buildroot@buildroot.org
Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>,
Romain Naour <romain.naour@gmail.com>,
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: [Buildroot] [PATCH 2/3] toolchain/toolchain-wrapper: use Gcc bug 97208 instead of repeating it
Date: Fri, 13 Aug 2021 23:37:44 +0200 [thread overview]
Message-ID: <20210813213745.1555522-3-giulio.benetti@benettiengineering.com> (raw)
In-Reply-To: <20210813213745.1555522-1-giulio.benetti@benettiengineering.com>
Now that we have added Gcc bug 97208 we can use it instead of repeating it.
So let's substitute bug condition with bug presence. Also note that gcc bug
97208 is still present in gcc 11.1.0 so better to make comment more generic
and keep a detailed description in toolchain/Config.in
Cc: Roman Naour <romain.naour@gmail.com>
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
toolchain/toolchain-wrapper.mk | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/toolchain/toolchain-wrapper.mk b/toolchain/toolchain-wrapper.mk
index 8b551e3a18..c56ec7c054 100644
--- a/toolchain/toolchain-wrapper.mk
+++ b/toolchain/toolchain-wrapper.mk
@@ -33,11 +33,10 @@ TOOLCHAIN_WRAPPER_OPTS += -DBR_NEED_SOURCE_DATE_EPOCH
endif
endif
-# Disable -ftree-loop-distribute-patterns on microblaze to
-# workaround a compiler bug with gcc 10 and -O2, -Os or -O3.
+# Disable -ftree-loop-distribute-patterns on compiler affected by gcc bug 97208.
# https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=5879ab5fafedc8f6f9bfe95a4cf8501b0df90edd
# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97208
-ifeq ($(BR2_TOOLCHAIN_GCC_AT_LEAST_10)$(BR2_microblaze),yy)
+ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_97208),y)
TOOLCHAIN_WRAPPER_OPTS += -fno-tree-loop-distribute-patterns
endif
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-08-13 21:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 21:37 [Buildroot] [PATCH 0/3] Microblaze gcc bug 97208 Giulio Benetti
2021-08-13 21:37 ` [Buildroot] [PATCH 1/3] toolchain: introduce BR2_TOOLCHAIN_HAS_GCC_BUG_97208 Giulio Benetti
2021-08-13 23:15 ` Giulio Benetti
2021-08-14 22:11 ` Giulio Benetti
2021-08-13 21:37 ` Giulio Benetti [this message]
2021-08-14 22:11 ` [Buildroot] [PATCH 2/3] toolchain/toolchain-wrapper: use Gcc bug 97208 instead of repeating it Giulio Benetti
2021-08-13 21:37 ` [Buildroot] [PATCH 3/3] package/lmbench: fix build failure due to gcc bug 97208 Giulio Benetti
2021-08-14 13:51 ` Thomas Petazzoni
2021-08-14 21:17 ` Giulio Benetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210813213745.1555522-3-giulio.benetti@benettiengineering.com \
--to=giulio.benetti@benettiengineering.com \
--cc=buildroot@buildroot.org \
--cc=romain.naour@gmail.com \
--cc=thomas.de_schampheleire@nokia.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.