From: Gokul Sivakumar <gokulkumar792@gmail.com>
To: netdev@vger.kernel.org, David Ahern <dsahern@kernel.org>
Cc: Gokul Sivakumar <gokulkumar792@gmail.com>
Subject: [PATCH iproute2-next 0/3] bridge: fixes regarding the colorized output
Date: Sat, 14 Aug 2021 15:24:36 +0530 [thread overview]
Message-ID: <20210814095439.1736737-1-gokulkumar792@gmail.com> (raw)
For the bridge cmd, the "colorize output" cmd line option's usage and the
corresponding output does not seem to be consistent with the usage and the
output of the "ip" cmds.
Example 1: As per the "colorize output" cmd line option documented in the
man pages man/man8/ip.8 & man/man8/bridge.8, using "-c" with "ip" or the
"bridge" should colorize the output. But this is working only with the "ip"
cmd and for the "bridge" cmd, the option "-col" / "-colo" / "-color" needs
to be used instead of just "-c".
Example 2: After fixing the inconsistency mentioned in Example 1,
- Running the cmd "$ ip -c neigh", will give the following output where the
"172.16.12.250", "bridge0" & "04:d9:f5:c1:0c:74" fields are highlighted
and not the fixed keywords "dev" & "lladdr".
172.16.12.250 dev bridge0 lladdr 04:d9:f5:c1:0c:74 REACHABLE
- But running the cmd "$ bridge -c fdb", will give the following output
where "00:00:00:00:00:00", "dev", "vxlan100", "dst" & "2001:db8:2::1" are
highlighted, even though "dev" & "dst" keywords are static.
00:00:00:00:00:00 dev vxlan100 dst 2001:db8:2::1 self permanent
Also fix a typo in man/man8/bridge.8 to change "-c[lor]" into "-c[olor]".
Gokul Sivakumar (3):
bridge: reorder cmd line arg parsing to let "-c" detected as "color"
option
bridge: fdb: don't colorize the "dev" & "dst" keywords in "bridge -c
fdb"
man: bridge: fix the typo to change "-c[lor]" into "-c[olor]" in man
page
bridge/bridge.c | 2 +-
bridge/fdb.c | 13 ++++++++++---
man/man8/bridge.8 | 2 +-
3 files changed, 12 insertions(+), 5 deletions(-)
--
2.25.1
next reply other threads:[~2021-08-14 9:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-14 9:54 Gokul Sivakumar [this message]
2021-08-14 9:54 ` [PATCH iproute2-next 1/3] bridge: reorder cmd line arg parsing to let "-c" detected as "color" option Gokul Sivakumar
2021-08-14 9:54 ` [PATCH iproute2-next 2/3] bridge: fdb: don't colorize the "dev" & "dst" keywords in "bridge -c fdb" Gokul Sivakumar
2021-08-14 16:22 ` Stephen Hemminger
2021-08-14 18:46 ` Gokul Sivakumar
2021-08-14 9:54 ` [PATCH iproute2-next 3/3] man: bridge: fix the typo to change "-c[lor]" into "-c[olor]" in man page Gokul Sivakumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210814095439.1736737-1-gokulkumar792@gmail.com \
--to=gokulkumar792@gmail.com \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.