All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masami Hiramatsu <mhiramat@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	linux-kernel@vger.kernel.org, Tom Zanussi <zanussi@kernel.org>
Subject: Re: [PATCH v4 07/10] tools/bootconfig: Support per-group/all event enabling option
Date: Sat, 14 Aug 2021 12:31:32 +0900	[thread overview]
Message-ID: <20210814123132.29181525b4debbf3bc5447bb@kernel.org> (raw)
In-Reply-To: <162856127850.203126.16694505101982548237.stgit@devnote2>



On Tue, 10 Aug 2021 11:07:58 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:

> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>

Oops, I missed the changelog for this patch.

-----
Add group or all event enabling syntax support to bconf2ftrace.sh.
User can pass a bootconfig file which includes

ftrace[.instance.INSTANCE].event.enable

    and

ftrace[.instance.INSTANCE].event.GROUP.enable

correctly.
-----

Steve, should I update the patch and resend the series?

Thank you,
    


> ---
>  tools/bootconfig/scripts/bconf2ftrace.sh |   13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/tools/bootconfig/scripts/bconf2ftrace.sh b/tools/bootconfig/scripts/bconf2ftrace.sh
> index feb30c2c7881..651049c782c0 100755
> --- a/tools/bootconfig/scripts/bconf2ftrace.sh
> +++ b/tools/bootconfig/scripts/bconf2ftrace.sh
> @@ -101,6 +101,12 @@ setup_event() { # prefix group event [instance]
>  	else
>  		eventdir="$TRACEFS/events/$2/$3"
>  	fi
> +	# group enable
> +	if [ "$3" = "enable" ]; then
> +		run_cmd "echo 1 > ${eventdir}"
> +		return
> +	fi
> +
>  	case $2 in
>  	kprobes)
>  		xbc_get_val ${branch}.probes | while read line; do
> @@ -127,6 +133,13 @@ setup_events() { # prefix("ftrace" or "ftrace.instance.INSTANCE") [instance]
>  			setup_event $prefix ${grpev%.*} ${grpev#*.} $2
>  		done
>  	fi
> +	if xbc_has_branch ${1}.event.enable; then
> +		if [ "$2" ]; then
> +			run_cmd "echo 1 > $TRACEFS/instances/$2/events/enable"
> +		else
> +			run_cmd "echo 1 > $TRACEFS/events/enable"
> +		fi
> +	fi
>  }
>  
>  size2kb() { # size[KB|MB]
> 


-- 
Masami Hiramatsu <mhiramat@kernel.org>

  reply	other threads:[~2021-08-14  3:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-10  2:07 [PATCH v4 00/10] tracing/boot: Add histogram syntax support in boot-time tracing Masami Hiramatsu
2021-08-10  2:07 ` [PATCH v4 01/10] tracing/boot: Fix a hist trigger dependency for boot time tracing Masami Hiramatsu
2021-08-10  2:07 ` [PATCH v4 02/10] tracing/boot: Add per-event histogram action options Masami Hiramatsu
2021-08-10  2:07 ` [PATCH v4 03/10] tracing/boot: Support multiple handlers for per-event histogram Masami Hiramatsu
2021-08-10  2:07 ` [PATCH v4 04/10] tracing/boot: Support multiple histograms for each event Masami Hiramatsu
2021-08-10  2:07 ` [PATCH v4 05/10] tracing/boot: Show correct histogram error command Masami Hiramatsu
2021-08-10  2:07 ` [PATCH v4 06/10] Documentation: tracing: Add histogram syntax to boot-time tracing Masami Hiramatsu
2021-08-10  2:07 ` [PATCH v4 07/10] tools/bootconfig: Support per-group/all event enabling option Masami Hiramatsu
2021-08-14  3:31   ` Masami Hiramatsu [this message]
2021-08-16 15:39     ` Steven Rostedt
2021-08-10  2:08 ` [PATCH v4 08/10] tools/bootconfig: Add histogram syntax support to bconf2ftrace.sh Masami Hiramatsu
2021-08-10  2:08 ` [PATCH v4 09/10] tools/bootconfig: Use per-group/all enable option in ftrace2bconf script Masami Hiramatsu
2021-08-10  2:08 ` [PATCH v4 10/10] bootconfig/tracing/ktest: Update ktest example for boot-time tracing Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210814123132.29181525b4debbf3bc5447bb@kernel.org \
    --to=mhiramat@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=zanussi@kernel.org \
    --subject='Re: [PATCH v4 07/10] tools/bootconfig: Support per-group/all event enabling option' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.