From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D14D2C4338F for ; Sun, 15 Aug 2021 07:07:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B9D0E61038 for ; Sun, 15 Aug 2021 07:07:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235569AbhHOHIA (ORCPT ); Sun, 15 Aug 2021 03:08:00 -0400 Received: from verein.lst.de ([213.95.11.211]:51233 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235664AbhHOHH5 (ORCPT ); Sun, 15 Aug 2021 03:07:57 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 1B2986736F; Sun, 15 Aug 2021 09:07:25 +0200 (CEST) Date: Sun, 15 Aug 2021 09:07:24 +0200 From: Christoph Hellwig To: Guenter Roeck Cc: Christoph Hellwig , Jens Axboe , Mike Snitzer , linux-block@vger.kernel.org, dm-devel@redhat.com Subject: Re: [dm-devel] [PATCH 4/8] block: support delayed holder registration Message-ID: <20210815070724.GA23276@lst.de> References: <20210804094147.459763-1-hch@lst.de> <20210804094147.459763-5-hch@lst.de> <20210814211309.GA616511@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210814211309.GA616511@roeck-us.net> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Sat, Aug 14, 2021 at 02:13:09PM -0700, Guenter Roeck wrote: > On Wed, Aug 04, 2021 at 11:41:43AM +0200, Christoph Hellwig wrote: > > device mapper needs to register holders before it is ready to do I/O. > > Currently it does so by registering the disk early, which can leave > > the disk and queue in a weird half state where the queue is registered > > with the disk, except for sysfs and the elevator. And this state has > > been a bit promlematic before, and will get more so when sorting out > > the responsibilities between the queue and the disk. > > > > Support registering holders on an initialized but not registered disk > > instead by delaying the sysfs registration until the disk is registered. > > > > Signed-off-by: Christoph Hellwig > > Reviewed-by: Mike Snitzer > > This patch results in lockdep splats when booting from flash. > Reverting it fixes the proboem. Should be fixed by: https://git.kernel.dk/cgit/linux-block/commit/?h=for-5.15/drivers&id=6e4df4c6488165637b95b9701cc862a42a3836ba From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B1EFC4338F for ; Sun, 15 Aug 2021 07:11:13 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E95E660F42 for ; Sun, 15 Aug 2021 07:11:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E95E660F42 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-115-kCkdXytMPbGg5L0YhIAyCA-1; Sun, 15 Aug 2021 03:11:10 -0400 X-MC-Unique: kCkdXytMPbGg5L0YhIAyCA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8D5461008065; Sun, 15 Aug 2021 07:11:02 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D7AF43AC4; Sun, 15 Aug 2021 07:10:59 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 29B764BB7C; Sun, 15 Aug 2021 07:10:56 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 17F77WTL029973 for ; Sun, 15 Aug 2021 03:07:33 -0400 Received: by smtp.corp.redhat.com (Postfix) id 9E6A321686A9; Sun, 15 Aug 2021 07:07:32 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 99C3B21686A7 for ; Sun, 15 Aug 2021 07:07:30 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 264D5800159 for ; Sun, 15 Aug 2021 07:07:30 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-257-ZWlAYhmGMFqUenHtHVWvDQ-1; Sun, 15 Aug 2021 03:07:27 -0400 X-MC-Unique: ZWlAYhmGMFqUenHtHVWvDQ-1 Received: by verein.lst.de (Postfix, from userid 2407) id 1B2986736F; Sun, 15 Aug 2021 09:07:25 +0200 (CEST) Date: Sun, 15 Aug 2021 09:07:24 +0200 From: Christoph Hellwig To: Guenter Roeck Message-ID: <20210815070724.GA23276@lst.de> References: <20210804094147.459763-1-hch@lst.de> <20210804094147.459763-5-hch@lst.de> <20210814211309.GA616511@roeck-us.net> MIME-Version: 1.0 In-Reply-To: <20210814211309.GA616511@roeck-us.net> User-Agent: Mutt/1.5.17 (2007-11-01) X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: dm-devel@redhat.com Cc: Jens Axboe , linux-block@vger.kernel.org, dm-devel@redhat.com, Christoph Hellwig , Mike Snitzer Subject: Re: [dm-devel] [PATCH 4/8] block: support delayed holder registration X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Sat, Aug 14, 2021 at 02:13:09PM -0700, Guenter Roeck wrote: > On Wed, Aug 04, 2021 at 11:41:43AM +0200, Christoph Hellwig wrote: > > device mapper needs to register holders before it is ready to do I/O. > > Currently it does so by registering the disk early, which can leave > > the disk and queue in a weird half state where the queue is registered > > with the disk, except for sysfs and the elevator. And this state has > > been a bit promlematic before, and will get more so when sorting out > > the responsibilities between the queue and the disk. > > > > Support registering holders on an initialized but not registered disk > > instead by delaying the sysfs registration until the disk is registered. > > > > Signed-off-by: Christoph Hellwig > > Reviewed-by: Mike Snitzer > > This patch results in lockdep splats when booting from flash. > Reverting it fixes the proboem. Should be fixed by: https://git.kernel.dk/cgit/linux-block/commit/?h=for-5.15/drivers&id=6e4df4c6488165637b95b9701cc862a42a3836ba -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel