From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A034C432BE for ; Sun, 15 Aug 2021 16:55:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E147E60EE2 for ; Sun, 15 Aug 2021 16:55:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230048AbhHOQze (ORCPT ); Sun, 15 Aug 2021 12:55:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:42998 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbhHOQzd (ORCPT ); Sun, 15 Aug 2021 12:55:33 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 152A561208; Sun, 15 Aug 2021 16:54:57 +0000 (UTC) Date: Sun, 15 Aug 2021 17:57:56 +0100 From: Jonathan Cameron To: William Breathitt Gray Cc: linux-stm32@st-md-mailman.stormreply.com, kernel@pengutronix.de, a.fatoum@pengutronix.de, kamel.bouhara@bootlin.com, gwendal@chromium.org, alexandre.belloni@bootlin.com, david@lechnology.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, syednwaris@gmail.com, patrick.havelange@essensium.com, fabrice.gasnier@st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, o.rempel@pengutronix.de, jarkko.nikula@linux.intel.com, Dan Carpenter Subject: Re: [PATCH v15 09/13] counter: Implement signalZ_action_component_id sysfs attribute Message-ID: <20210815175756.5e627c3d@jic23-huawei> In-Reply-To: References: X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 9 Aug 2021 21:37:34 +0900 William Breathitt Gray wrote: > The Generic Counter chrdev interface expects users to supply component > IDs in order to select Synapses for requests. In order for users to know > what component ID belongs to which Synapse this information must be > exposed. The signalZ_action_component_id attribute provides a way for > users to discover what component ID belongs to the respective Synapse. > > Cc: Gwendal Grignou > Cc: Dan Carpenter > Reviewed-by: David Lechner > Signed-off-by: William Breathitt Gray > --- > Contact: linux-iio@vger.kernel.org > diff --git a/drivers/counter/counter-sysfs.c b/drivers/counter/counter-sysfs.c > index dbb507c9da11..11bef9f8190f 100644 > --- a/drivers/counter/counter-sysfs.c > +++ b/drivers/counter/counter-sysfs.c > @@ -393,7 +393,6 @@ static int counter_avail_attr_create(struct device *const dev, > struct counter_attribute *counter_attr; > struct device_attribute *dev_attr; > > - /* Allocate Counter attribute */ Trivial, but this is an unrelated change and shouldn't be in this patch (it's just noise). > counter_attr = devm_kzalloc(dev, sizeof(*counter_attr), GFP_KERNEL); > if (!counter_attr) > return -ENOMEM; > @@ -535,6 +534,46 @@ static int counter_name_attr_create(struct device *const dev, > return 0; > } > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9C7DC4338F for ; Sun, 15 Aug 2021 16:56:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BD6361208 for ; Sun, 15 Aug 2021 16:56:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6BD6361208 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LzeUDn/r766sf2Tyk2lXDrHYV85LM0eUdU3KSm5Dl4E=; b=LhWMtHYyTkFnZ8 H90tY05AtlJbIN9ZizVeQxJa0k/XQeMVk6sEyag/iZV19FPNn/3eDULm97XNknVlKJLkOamdcDrfq aCKI5O/2pFEnZg4nm4I0ofQ1zXmn5c89A+6ElYJWay1SK47Tob0BsY49S/Tvi1YuT4VlHj1KJlZOY XNbb3v4agOaNwCVzo9XE5OdVDX7LwYnmT2vuGgz+xfnQ3PJEcPAO001wGrspgQxqhDsv4+T8+4Lsj b40fI+IlkeuAkRmlww6py9aky8p2fRR3KR2W14y5upxirW2AkHQMpdb1v94mm7luoCEhGsgDRisDi CqMbds5HPTU/vPa+qIoA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFJPe-00FY0G-AV; Sun, 15 Aug 2021 16:55:06 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFJPb-00FXzs-MR for linux-arm-kernel@lists.infradead.org; Sun, 15 Aug 2021 16:55:04 +0000 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 152A561208; Sun, 15 Aug 2021 16:54:57 +0000 (UTC) Date: Sun, 15 Aug 2021 17:57:56 +0100 From: Jonathan Cameron To: William Breathitt Gray Cc: linux-stm32@st-md-mailman.stormreply.com, kernel@pengutronix.de, a.fatoum@pengutronix.de, kamel.bouhara@bootlin.com, gwendal@chromium.org, alexandre.belloni@bootlin.com, david@lechnology.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, syednwaris@gmail.com, patrick.havelange@essensium.com, fabrice.gasnier@st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, o.rempel@pengutronix.de, jarkko.nikula@linux.intel.com, Dan Carpenter Subject: Re: [PATCH v15 09/13] counter: Implement signalZ_action_component_id sysfs attribute Message-ID: <20210815175756.5e627c3d@jic23-huawei> In-Reply-To: References: X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210815_095503_809393_65038CF9 X-CRM114-Status: GOOD ( 16.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 9 Aug 2021 21:37:34 +0900 William Breathitt Gray wrote: > The Generic Counter chrdev interface expects users to supply component > IDs in order to select Synapses for requests. In order for users to know > what component ID belongs to which Synapse this information must be > exposed. The signalZ_action_component_id attribute provides a way for > users to discover what component ID belongs to the respective Synapse. > > Cc: Gwendal Grignou > Cc: Dan Carpenter > Reviewed-by: David Lechner > Signed-off-by: William Breathitt Gray > --- > Contact: linux-iio@vger.kernel.org > diff --git a/drivers/counter/counter-sysfs.c b/drivers/counter/counter-sysfs.c > index dbb507c9da11..11bef9f8190f 100644 > --- a/drivers/counter/counter-sysfs.c > +++ b/drivers/counter/counter-sysfs.c > @@ -393,7 +393,6 @@ static int counter_avail_attr_create(struct device *const dev, > struct counter_attribute *counter_attr; > struct device_attribute *dev_attr; > > - /* Allocate Counter attribute */ Trivial, but this is an unrelated change and shouldn't be in this patch (it's just noise). > counter_attr = devm_kzalloc(dev, sizeof(*counter_attr), GFP_KERNEL); > if (!counter_attr) > return -ENOMEM; > @@ -535,6 +534,46 @@ static int counter_name_attr_create(struct device *const dev, > return 0; > } > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel