From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E337C4338F for ; Sun, 15 Aug 2021 19:47:38 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D594361216 for ; Sun, 15 Aug 2021 19:47:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D594361216 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3EDE882BEC; Sun, 15 Aug 2021 21:47:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="dIJeONPw"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AE1FB829C3; Sun, 15 Aug 2021 21:47:30 +0200 (CEST) Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5D7F581BC8 for ; Sun, 15 Aug 2021 21:47:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82f.google.com with SMTP id y9so12716261qtv.7 for ; Sun, 15 Aug 2021 12:47:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=remPOzrORoBSecxU/pyg/aS9ZtX6qqidqWAe/HOxPYM=; b=dIJeONPwENePgreng0bCu2GquRK1xFBYLTU+urhX7v2CL9Rhu+MeNXFFNzo9+otHxj +cP8QTXpWnw0lM4pkJgNQdvRxoM91AIes3lOfE5C6dDuxOT5zWM14WUQmM9hXI1LaPYg WuL/HEezcnUgVuMOhHKVYXDZx5w0YYSiCF+90= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=remPOzrORoBSecxU/pyg/aS9ZtX6qqidqWAe/HOxPYM=; b=j0ES5JSK6ZxPSPqW2udm7iysvB2pr0SXNjsXdQtDVO+P3jVjAcyin3h99OaYRG1sdE rNRKXkputy6gR3zyPGbi6drdwRUdAvKkH45WR4jobdoTXzBtYtS1keXpMZCBNi22aSAL 9rKgK6puU+hYeZ8GOK9wKBzTsWV3ZXLYtlnZqVAJyIV3UjIDNx6N4iTk8WPP0Lb/lxI7 FNBFxQhOQPLaD/be7bgagd/V5cC2bBY3fVT1YISK8JW04p3qVYA3rpdvwAc/ZBBfMpuz 9OeoUuR0Qtr6ITd0YD4ehQmqN+NpFIYIPlg9bf30+rqXCV9d6zFwljpGk5juduXcIH1m M0Tg== X-Gm-Message-State: AOAM532U4B5F4CVuDAHzFBL27HRvfc1LlpWAtV/FaqlXhMcDbKgqoOwd Gmz+Dl52lD79EvyYKmTpqqO/AA== X-Google-Smtp-Source: ABdhPJy//A5NK4Tb9UyyMmkmARwaTt45OaWV3+XmtugzMSLk0MspwKcWJIJ9h2gJMppD07h3lrkFcA== X-Received: by 2002:ac8:7d4c:: with SMTP id h12mr11087945qtb.257.1629056844181; Sun, 15 Aug 2021 12:47:24 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-6085-4c50-20fd-dcb7.res6.spectrum.com. [2603:6081:7b01:cbda:6085:4c50:20fd:dcb7]) by smtp.gmail.com with ESMTPSA id g2sm2535554qki.42.2021.08.15.12.47.23 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 15 Aug 2021 12:47:23 -0700 (PDT) Date: Sun, 15 Aug 2021 15:47:21 -0400 From: Tom Rini To: Marek Vasut Cc: u-boot@lists.denx.de, Marek Vasut , Simon Glass , Simon Goldschmidt Subject: Re: [PATCH 02/14] lmb: Use CONFIG_LMB_*_REGIONS only if they are defined Message-ID: <20210815194721.GN858@bill-the-cat> References: <20210815181314.132330-1-marek.vasut+renesas@gmail.com> <20210815181314.132330-2-marek.vasut+renesas@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="AUxunNHdr2sGjsEi" Content-Disposition: inline In-Reply-To: <20210815181314.132330-2-marek.vasut+renesas@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --AUxunNHdr2sGjsEi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Aug 15, 2021 at 08:13:02PM +0200, Marek Vasut wrote: > The CONFIG_LMB_*_REGIONS are defined only if CONFIG_LMB is enabled, > protect access to those two config options to avoid undefined macro > errors. >=20 > Signed-off-by: Marek Vasut > Cc: Simon Glass > Cc: Simon Goldschmidt > Cc: Tom Rini > --- > include/lmb.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/include/lmb.h b/include/lmb.h > index 3c4afdf9f0..fa1474a360 100644 > --- a/include/lmb.h > +++ b/include/lmb.h > @@ -44,7 +44,7 @@ struct lmb_property { > struct lmb_region { > unsigned long cnt; > unsigned long max; > -#if IS_ENABLED(CONFIG_LMB_USE_MAX_REGIONS) > +#if IS_ENABLED(CONFIG_LMB) && IS_ENABLED(CONFIG_LMB_USE_MAX_REGIONS) > struct lmb_property region[CONFIG_LMB_MAX_REGIONS]; > #else > struct lmb_property *region; > @@ -67,7 +67,7 @@ struct lmb_region { > struct lmb { > struct lmb_region memory; > struct lmb_region reserved; > -#if !IS_ENABLED(CONFIG_LMB_USE_MAX_REGIONS) > +#if IS_ENABLED(CONFIG_LMB) && !IS_ENABLED(CONFIG_LMB_USE_MAX_REGIONS) > struct lmb_property memory_regions[CONFIG_LMB_MEMORY_REGIONS]; > struct lmb_property reserved_regions[CONFIG_LMB_RESERVED_REGIONS]; > #endif We shouldn't need this at all. LMB and LMB_USE_MAX_REGIONS are both in Kconfig and have the dependencies expressed that way. --=20 Tom --AUxunNHdr2sGjsEi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEZb0kACgkQFHw5/5Y0 tyy2SAv/YT/zFAUfZuUVujET29L158ymkDqQRRRjlvNNVmNEyU1qRJLhTGJ/E7ta yK5228d4x/xMRlgMP8i2hjn/d2ZO9Wt4e964F8160RcvxwSoBQSZNo9HX5zn9200 sDiYsUnWCgA8/aT7TIRBqD7n/JEKjZ78WtEY7IwDIFuU8Q4/ErLyuLGc4yDNYsY2 JKibwqbpZ+l8xIGM9ILtOpBCIOefxIxy3zg3gZCVxdOHPYQlj4/UbITCr8BJmB3/ woqugO1e/1vq62Wx32YsDGtmi+LTKyBvmq5yHak+1lKIhsia9Gh+YtFRe4Y78kYm 9GNZalyk3YZpiO/LibEUWWsaHJtPWh/MV2kct1yZO2paPv/piZZaTn/IVuuRhtJU oBOAR9+PdWS/XTO4As5HVFdq8YmqfbJhohh75EefL0CnxZETtEQFSuRjAPMtZPGp a44C8eYa1Ze/dTIU4DsGlPkd41BcrD8j4nnZMi0qKS4FOjaWs/UXSaxFsR/M+OSJ dBn0AsU8 =1pdO -----END PGP SIGNATURE----- --AUxunNHdr2sGjsEi--