From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5C49C4338F for ; Mon, 16 Aug 2021 10:53:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD94161BE1 for ; Mon, 16 Aug 2021 10:53:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236351AbhHPKyO (ORCPT ); Mon, 16 Aug 2021 06:54:14 -0400 Received: from mga06.intel.com ([134.134.136.31]:17780 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236242AbhHPKyC (ORCPT ); Mon, 16 Aug 2021 06:54:02 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10077"; a="276867110" X-IronPort-AV: E=Sophos;i="5.84,324,1620716400"; d="scan'208";a="276867110" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2021 03:53:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,324,1620716400"; d="scan'208";a="448502468" Received: from linux.intel.com ([10.54.29.200]) by fmsmga007.fm.intel.com with ESMTP; 16 Aug 2021 03:53:29 -0700 Received: from linux.intel.com (vwong3-iLBPG3.png.intel.com [10.88.229.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 944A85808DB; Mon, 16 Aug 2021 03:53:26 -0700 (PDT) Date: Mon, 16 Aug 2021 18:53:23 +0800 From: Wong Vee Khee To: Vijayakannan Ayyathurai Cc: peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, davem@davemloft.net, kuba@kernel.org, mcoquelin.stm32@gmail.com, vee.khee.wong@intel.com, weifeng.voon@intel.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v1 3/3] net: stmmac: add ethtool per-queue irq statistic support Message-ID: <20210816105323.GA13779@linux.intel.com> References: <5c956016465b688a2679bd02da1f751046be189c.1629092894.git.vijayakannan.ayyathurai@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5c956016465b688a2679bd02da1f751046be189c.1629092894.git.vijayakannan.ayyathurai@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 16, 2021 at 02:16:00PM +0800, Vijayakannan Ayyathurai wrote: > Adding ethtool per-queue statistics support to show number of interrupts > generated at DMA tx and DMA rx. All the counters are incremented at > dwmac4_dma_interrupt function. > Acked-by: Wong Vee Khee > Signed-off-by: Vijayakannan Ayyathurai > --- > drivers/net/ethernet/stmicro/stmmac/common.h | 2 ++ > drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c | 2 ++ > drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 2 ++ > 3 files changed, 6 insertions(+) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/common.h b/drivers/net/ethernet/stmicro/stmmac/common.h > index 79333deef2e2..b6d945ea903d 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/common.h > +++ b/drivers/net/ethernet/stmicro/stmmac/common.h > @@ -60,10 +60,12 @@ > > struct stmmac_txq_stats { > unsigned long tx_pkt_n; > + unsigned long tx_normal_irq_n; > }; > > struct stmmac_rxq_stats { > unsigned long rx_pkt_n; > + unsigned long rx_normal_irq_n; > }; > > /* Extra statistic and debug information exposed by ethtool */ > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c > index f83db62938dd..9292a1fab7d3 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c > @@ -170,10 +170,12 @@ int dwmac4_dma_interrupt(void __iomem *ioaddr, > x->normal_irq_n++; > if (likely(intr_status & DMA_CHAN_STATUS_RI)) { > x->rx_normal_irq_n++; > + x->rxq_stats[chan].rx_normal_irq_n++; > ret |= handle_rx; > } > if (likely(intr_status & DMA_CHAN_STATUS_TI)) { > x->tx_normal_irq_n++; > + x->txq_stats[chan].tx_normal_irq_n++; > ret |= handle_tx; > } > if (unlikely(intr_status & DMA_CHAN_STATUS_TBU)) > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c > index 10c0895d0b43..595c3ccdcbb7 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c > @@ -263,11 +263,13 @@ static const struct stmmac_stats stmmac_mmc[] = { > > static const char stmmac_qstats_tx_string[][ETH_GSTRING_LEN] = { > "tx_pkt_n", > + "tx_irq_n", > #define STMMAC_TXQ_STATS ARRAY_SIZE(stmmac_qstats_tx_string) > }; > > static const char stmmac_qstats_rx_string[][ETH_GSTRING_LEN] = { > "rx_pkt_n", > + "rx_irq_n", > #define STMMAC_RXQ_STATS ARRAY_SIZE(stmmac_qstats_rx_string) > }; > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 845EDC4338F for ; Mon, 16 Aug 2021 10:55:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5203561BE1 for ; Mon, 16 Aug 2021 10:55:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5203561BE1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PkpTWh+uDHOH+UNGhmuM/LQ8d+vuYapZXCg6JW3470Y=; b=LA4aNYJpo7dtQY 8Werf6UXa7bhuyfoUB+cQsQANgmB8syIw5JFFdbD0uV0YU+hQDsDmn6Gr2MWDSyzEPq3eBS2B/y7U vXIDMvEk1AdGcceNn3EVdvYYv+TvXBAILKqTRK5Mx3z+KQL/3aV2i5MQQf2lRVB7mUUtjhAPYxru9 DO+jGkVlYBLoxnFPB25zrrJ2mM6SZx/0LqWdsgHwFBDBTWkC6nqMj1Off4Azt02OPg6tJGMbLFm8/ 7r3tKbKdEMf/6H+TD1NcNkfNc+c30BwzxQg0wHgKYF/cmLuZwcpAJuPEIZnDzDr6CAb4EtCwr8rEQ fpZFDfWq1laY3K7xI12g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFaFZ-00GlBT-OY; Mon, 16 Aug 2021 10:53:49 +0000 Received: from mga14.intel.com ([192.55.52.115]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFaFH-00Gl5j-R4 for linux-arm-kernel@lists.infradead.org; Mon, 16 Aug 2021 10:53:33 +0000 X-IronPort-AV: E=McAfee;i="6200,9189,10077"; a="215565708" X-IronPort-AV: E=Sophos;i="5.84,324,1620716400"; d="scan'208";a="215565708" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2021 03:53:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,324,1620716400"; d="scan'208";a="448502468" Received: from linux.intel.com ([10.54.29.200]) by fmsmga007.fm.intel.com with ESMTP; 16 Aug 2021 03:53:29 -0700 Received: from linux.intel.com (vwong3-iLBPG3.png.intel.com [10.88.229.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 944A85808DB; Mon, 16 Aug 2021 03:53:26 -0700 (PDT) Date: Mon, 16 Aug 2021 18:53:23 +0800 From: Wong Vee Khee To: Vijayakannan Ayyathurai Cc: peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, davem@davemloft.net, kuba@kernel.org, mcoquelin.stm32@gmail.com, vee.khee.wong@intel.com, weifeng.voon@intel.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v1 3/3] net: stmmac: add ethtool per-queue irq statistic support Message-ID: <20210816105323.GA13779@linux.intel.com> References: <5c956016465b688a2679bd02da1f751046be189c.1629092894.git.vijayakannan.ayyathurai@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5c956016465b688a2679bd02da1f751046be189c.1629092894.git.vijayakannan.ayyathurai@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210816_035331_935647_E963F893 X-CRM114-Status: GOOD ( 19.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 16, 2021 at 02:16:00PM +0800, Vijayakannan Ayyathurai wrote: > Adding ethtool per-queue statistics support to show number of interrupts > generated at DMA tx and DMA rx. All the counters are incremented at > dwmac4_dma_interrupt function. > Acked-by: Wong Vee Khee > Signed-off-by: Vijayakannan Ayyathurai > --- > drivers/net/ethernet/stmicro/stmmac/common.h | 2 ++ > drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c | 2 ++ > drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 2 ++ > 3 files changed, 6 insertions(+) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/common.h b/drivers/net/ethernet/stmicro/stmmac/common.h > index 79333deef2e2..b6d945ea903d 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/common.h > +++ b/drivers/net/ethernet/stmicro/stmmac/common.h > @@ -60,10 +60,12 @@ > > struct stmmac_txq_stats { > unsigned long tx_pkt_n; > + unsigned long tx_normal_irq_n; > }; > > struct stmmac_rxq_stats { > unsigned long rx_pkt_n; > + unsigned long rx_normal_irq_n; > }; > > /* Extra statistic and debug information exposed by ethtool */ > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c > index f83db62938dd..9292a1fab7d3 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c > @@ -170,10 +170,12 @@ int dwmac4_dma_interrupt(void __iomem *ioaddr, > x->normal_irq_n++; > if (likely(intr_status & DMA_CHAN_STATUS_RI)) { > x->rx_normal_irq_n++; > + x->rxq_stats[chan].rx_normal_irq_n++; > ret |= handle_rx; > } > if (likely(intr_status & DMA_CHAN_STATUS_TI)) { > x->tx_normal_irq_n++; > + x->txq_stats[chan].tx_normal_irq_n++; > ret |= handle_tx; > } > if (unlikely(intr_status & DMA_CHAN_STATUS_TBU)) > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c > index 10c0895d0b43..595c3ccdcbb7 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c > @@ -263,11 +263,13 @@ static const struct stmmac_stats stmmac_mmc[] = { > > static const char stmmac_qstats_tx_string[][ETH_GSTRING_LEN] = { > "tx_pkt_n", > + "tx_irq_n", > #define STMMAC_TXQ_STATS ARRAY_SIZE(stmmac_qstats_tx_string) > }; > > static const char stmmac_qstats_rx_string[][ETH_GSTRING_LEN] = { > "rx_pkt_n", > + "rx_irq_n", > #define STMMAC_RXQ_STATS ARRAY_SIZE(stmmac_qstats_rx_string) > }; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel