From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EB45C4338F for ; Mon, 16 Aug 2021 12:08:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E055563247 for ; Mon, 16 Aug 2021 12:08:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235091AbhHPMJL (ORCPT ); Mon, 16 Aug 2021 08:09:11 -0400 Received: from verein.lst.de ([213.95.11.211]:54155 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230216AbhHPMJJ (ORCPT ); Mon, 16 Aug 2021 08:09:09 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 979966736F; Mon, 16 Aug 2021 14:08:36 +0200 (CEST) Date: Mon, 16 Aug 2021 14:08:36 +0200 From: Christoph Hellwig To: David Stevens Cc: Robin Murphy , Christoph Hellwig , Joerg Roedel , Will Deacon , Lu Baolu , Tom Murphy , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 5/7] dma-iommu: Check CONFIG_SWIOTLB more broadly Message-ID: <20210816120836.GD15860@lst.de> References: <20210816025755.2906695-1-stevensd@google.com> <20210816025755.2906695-6-stevensd@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210816025755.2906695-6-stevensd@google.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > - if (IS_ENABLED(CONFIG_SWIOTLB) && dev_is_untrusted(dev) && > + if (IS_ENABLED(CONFIG_SWIOTLB) && dev_use_swiotlb(dev) && > iova_offset(iovad, phys | size)) { This can drop the explicit CONFIG_SWIOTLB check now (and make the remaining conditional fit onto a single line). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8FDBC4338F for ; Mon, 16 Aug 2021 12:08:46 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A43763249 for ; Mon, 16 Aug 2021 12:08:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6A43763249 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 3AE4F834DE; Mon, 16 Aug 2021 12:08:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uzrjO_GCZQIl; Mon, 16 Aug 2021 12:08:42 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id 1158D80D96; Mon, 16 Aug 2021 12:08:42 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id DFE95C001A; Mon, 16 Aug 2021 12:08:41 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4CD8CC000E for ; Mon, 16 Aug 2021 12:08:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 2FE22834DE for ; Mon, 16 Aug 2021 12:08:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q_OkFvjrb1uO for ; Mon, 16 Aug 2021 12:08:39 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by smtp1.osuosl.org (Postfix) with ESMTPS id 9500880D96 for ; Mon, 16 Aug 2021 12:08:39 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 979966736F; Mon, 16 Aug 2021 14:08:36 +0200 (CEST) Date: Mon, 16 Aug 2021 14:08:36 +0200 From: Christoph Hellwig To: David Stevens Subject: Re: [PATCH v5 5/7] dma-iommu: Check CONFIG_SWIOTLB more broadly Message-ID: <20210816120836.GD15860@lst.de> References: <20210816025755.2906695-1-stevensd@google.com> <20210816025755.2906695-6-stevensd@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210816025755.2906695-6-stevensd@google.com> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: Robin Murphy , linux-kernel@vger.kernel.org, Tom Murphy , iommu@lists.linux-foundation.org, Will Deacon , Christoph Hellwig X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" > - if (IS_ENABLED(CONFIG_SWIOTLB) && dev_is_untrusted(dev) && > + if (IS_ENABLED(CONFIG_SWIOTLB) && dev_use_swiotlb(dev) && > iova_offset(iovad, phys | size)) { This can drop the explicit CONFIG_SWIOTLB check now (and make the remaining conditional fit onto a single line). _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu