From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1162C4338F for ; Mon, 16 Aug 2021 13:01:50 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C558863281 for ; Mon, 16 Aug 2021 13:01:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C558863281 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nic.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3463982C28; Mon, 16 Aug 2021 15:01:48 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=nic.cz header.i=@nic.cz header.b="Jn0cKQXp"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E35C282BCE; Mon, 16 Aug 2021 15:01:45 +0200 (CEST) Received: from mail.nic.cz (lists.nic.cz [IPv6:2001:1488:800:400::400]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C1CF082BCE for ; Mon, 16 Aug 2021 15:01:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=marek.behun@nic.cz Received: from dellmb (unknown [IPv6:2001:1488:fffe:6:8747:7254:5571:3010]) by mail.nic.cz (Postfix) with ESMTPSA id 669BA1405C9; Mon, 16 Aug 2021 15:01:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1629118900; bh=69qf6vfKL9AlIbErW6JYPp0Q+g7caSiA4LPxp/LBDzI=; h=Date:From:To; b=Jn0cKQXpJu84OsITQKe2Vnj4gkBrXeEPvh+1d5+YSMrqeOb0kA9mVqOzZbfJtA67C eeNQSF0ptOpQBe5ApaFyBiP4IOsTAi3ferKeN2Efv/kgxjHrpMMTO/iL8HUChOUqbh qxhBXwTBCVa0f/DFQKzx784g540wQCF3Gg81k63w= Date: Mon, 16 Aug 2021 15:01:40 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Stefan Roese Cc: u-boot@lists.denx.de, pali@kernel.org Subject: Re: [PATCH u-boot-mvebu 3/3] arm: mvebu: turris_omnia: disable MCU watchdog in SPL when booting over UART Message-ID: <20210816150140.5a622211@dellmb> In-Reply-To: <446b9f6d-70d0-04fc-ea4c-edbd876a194e@denx.de> References: <20210816122726.14506-1-marek.behun@nic.cz> <20210816122726.14506-4-marek.behun@nic.cz> <446b9f6d-70d0-04fc-ea4c-edbd876a194e@denx.de> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Mon, 16 Aug 2021 14:50:15 +0200 Stefan Roese wrote: > > - disable_mcu_watchdog(); > > + /* > > + * If not booting from UART, MCU watchdog was not disabled > > in SPL, > > + * disable it now. > > + */ > > + if (get_boot_device() != BOOT_DEVICE_UART) > > + disable_mcu_watchdog(); > > Why do you disable the MCU watchdog here in U-Boot proper? Hi Stefan, this is just where it was before. But looking at the prompt SoC: MV88F6820-A0 at 1600 MHz DRAM: 2 GiB (800 MHz, 32-bit, 2T, ECC not enabled) Disabling MCU watchdog... disabled WDT: Started with servicing (60s timeout) it looks like U-Boot's watchdog is being enabled after MCU watchdog. It would be better to enable U-Boot's WDT before disabling MCU watchdog. I will send another patch that moves it to another function, board_late_init for example. Shall I resend this series with this new patch? Marek