Re: [PATCH 1/7] btrfs: Reorder btrfs_find_item arguments

[David Sterba <dsterba@suse.cz>]

On Wed, Aug 04, 2021 at 03:48:48PM -0300, Marcos Paulo de Souza wrote:
> It's more natural do use objectid, type and offset, in this order, when
> dealing with btrfs keys.
> 
> No functional changes.
> 
> Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
> ---
>  fs/btrfs/backref.c | 9 ++++-----
>  fs/btrfs/ctree.c   | 2 +-
>  fs/btrfs/ctree.h   | 2 +-
>  3 files changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
> index f735b8798ba1..9e92faaafa02 100644
> --- a/fs/btrfs/backref.c
> +++ b/fs/btrfs/backref.c
> @@ -1691,8 +1691,8 @@ char *btrfs_ref_to_path(struct btrfs_root *fs_root, struct btrfs_path *path,
>  				btrfs_tree_read_unlock(eb);
>  			free_extent_buffer(eb);
>  		}
> -		ret = btrfs_find_item(fs_root, path, parent, 0,
> -				BTRFS_INODE_REF_KEY, &found_key);
> +		ret = btrfs_find_item(fs_root, path, parent, BTRFS_INODE_REF_KEY,
> +					0, &found_key);

Have you considered using the found_key as both input and output
parameter? As input it stores the objectid/key/offset parameters and
with no errors it's set to the found key.

All callers of the function already have a key and you add another
variable just for the one that changes in the iterations (eg. offset).