From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD916C4338F for ; Mon, 16 Aug 2021 17:55:15 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2897460F22 for ; Mon, 16 Aug 2021 17:55:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2897460F22 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 30340817D3; Mon, 16 Aug 2021 19:55:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="o+R1K3YQ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9FBD781BC8; Mon, 16 Aug 2021 19:55:11 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 110CF800D0 for ; Mon, 16 Aug 2021 19:55:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: by mail.kernel.org (Postfix) with ESMTPSA id 81DB460EB5; Mon, 16 Aug 2021 17:55:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629136504; bh=uUbdEALo8Y6Gz2ebZBUzswdWz9RViOg1+BIdeo8mZNE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=o+R1K3YQiRGeaQVOxjs7iXBOIZheUjTP4J/Q9HIGjnu3Cw11A6CYaMxujSJ5+ZvT4 kcb4/COoRL0P3qu2WIs9Wp6GSegS0oSMGE1i57KfsNzLaPdMTfgnqyOea1QEEWOlMT 9RoUEaUWHgDupoaI3lNYSRDqhPFqWxUGOXWUkYGWFiawtOPSJdOZIHyaZ3Z0UhZ6hu g92mn1V4rphnDa4GJf5tGf5/NUVLxR9RfT2xVjkHDsO8Ldps1fIvxjKGn7OtV3Urqy zeGBwBk2ns888SEXdVOOclGJIYXfdQ5+JbPojMNbtPoMXKjToLNerfvsZGSSMebR9n 5dkHhJyDglJkA== Received: by pali.im (Postfix) id 12B8A949; Mon, 16 Aug 2021 19:55:02 +0200 (CEST) Date: Mon, 16 Aug 2021 19:55:01 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Marek =?utf-8?B?QmVow7pu?= Cc: Stefan Roese , u-boot@lists.denx.de Subject: Re: [PATCH u-boot-mvebu v2 2/4] arm: mvebu: turris_omnia: don't guard by CONFIG_SPL_BUILD macro Message-ID: <20210816175501.wd7sdlujxc4jn4sr@pali> References: <20210816131940.24206-1-marek.behun@nic.cz> <20210816131940.24206-3-marek.behun@nic.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210816131940.24206-3-marek.behun@nic.cz> User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Monday 16 August 2021 15:19:38 Marek Behún wrote: > We do not need to guard code in board_init() and board_late_init() > functions with the CONFIG_SPL_BUILD macro, since these functions are not > called in SPL. > > Signed-off-by: Marek Behún Reviewed-by: Pali Rohár > --- > board/CZ.NIC/turris_omnia/turris_omnia.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b/board/CZ.NIC/turris_omnia/turris_omnia.c > index a7e5f56eed..a84a409f43 100644 > --- a/board/CZ.NIC/turris_omnia/turris_omnia.c > +++ b/board/CZ.NIC/turris_omnia/turris_omnia.c > @@ -129,7 +129,6 @@ static int omnia_mcu_read(u8 cmd, void *buf, int len) > return dm_i2c_read(chip, cmd, buf, len); > } > > -#ifndef CONFIG_SPL_BUILD > static int omnia_mcu_write(u8 cmd, const void *buf, int len) > { > struct udevice *chip; > @@ -158,7 +157,6 @@ static bool disable_mcu_watchdog(void) > > return true; > } > -#endif > > static bool omnia_detect_sata(void) > { > @@ -325,7 +323,6 @@ struct mv_ddr_topology_map *mv_ddr_topology_map_get(void) > return &board_topology_map_1g; > } > > -#ifndef CONFIG_SPL_BUILD > static int set_regdomain(void) > { > struct omnia_eeprom oep; > @@ -394,7 +391,6 @@ static void handle_reset_button(void) > } > } > } > -#endif > > int board_early_init_f(void) > { > @@ -428,19 +424,15 @@ int board_init(void) > /* address of boot parameters */ > gd->bd->bi_boot_params = mvebu_sdram_bar(0) + 0x100; > > -#ifndef CONFIG_SPL_BUILD > disable_mcu_watchdog(); > -#endif > > return 0; > } > > int board_late_init(void) > { > -#ifndef CONFIG_SPL_BUILD > set_regdomain(); > handle_reset_button(); > -#endif > pci_init(); > > return 0; > -- > 2.31.1 >