[meta-mingw] [PATCH 1/3] protobuf: static link tools when generating sdk

[meta-mingw] [PATCH 1/3] protobuf: static link tools when generating sdk

[Sinan Kaya]

Dynamically linked protoc.exe is failing as follows:

[libprotobuf ERROR google/protobuf/descriptor_database.cc:641]
File already exists in database: google/protobuf/descriptor.proto
[libprotobuf FATAL google/protobuf/descriptor.cc:1371] CHECK failed:
GeneratedDatabase()->Add(encoded_file_descriptor, size):

Switch to static linkage per upstream recommendation.

Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
 recipes-devtools/protobuf/protobuf_%.bbappend | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 recipes-devtools/protobuf/protobuf_%.bbappend

diff --git a/recipes-devtools/protobuf/protobuf_%.bbappend b/recipes-devtools/protobuf/protobuf_%.bbappend
new file mode 100644
index 0000000..7e62ff6
--- /dev/null
+++ b/recipes-devtools/protobuf/protobuf_%.bbappend
@@ -0,0 +1 @@
+EXTRA_OECONF:append:class-nativesdk = " --disable-shared"
-- 
2.17.1

[meta-mingw] [PATCH 2/3] protobuf-c: static link when generating sdk

[Sinan Kaya]

[libprotobuf ERROR google/protobuf/descriptor_database.cc:641]
File already exists in database: google/protobuf/descriptor.proto
[libprotobuf FATAL google/protobuf/descriptor.cc:1371] CHECK failed:
GeneratedDatabase()->Add(encoded_file_descriptor, size):

Switch to static linkage per upstream recommendation.

Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
 recipes-devtools/protobuf-c/protobuf-c_%.bbappend | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 recipes-devtools/protobuf-c/protobuf-c_%.bbappend

diff --git a/recipes-devtools/protobuf-c/protobuf-c_%.bbappend b/recipes-devtools/protobuf-c/protobuf-c_%.bbappend
new file mode 100644
index 0000000..7e62ff6
--- /dev/null
+++ b/recipes-devtools/protobuf-c/protobuf-c_%.bbappend
@@ -0,0 +1 @@
+EXTRA_OECONF:append:class-nativesdk = " --disable-shared"
-- 
2.17.1

[meta-mingw] [PATCH 3/3] grpc: static link tools when generating SDK

[Sinan Kaya]

[libprotobuf ERROR google/protobuf/descriptor_database.cc:641]
File already exists in database: google/protobuf/descriptor.proto
[libprotobuf FATAL google/protobuf/descriptor.cc:1371] CHECK failed:
GeneratedDatabase()->Add(encoded_file_descriptor, size):

Switch to static linkage per upstream recommendation.

Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
 recipes-devtools/grpc/grpc_%.bbappend | 2 ++
 1 file changed, 2 insertions(+)
 create mode 100644 recipes-devtools/grpc/grpc_%.bbappend

diff --git a/recipes-devtools/grpc/grpc_%.bbappend b/recipes-devtools/grpc/grpc_%.bbappend
new file mode 100644
index 0000000..cbccf74
--- /dev/null
+++ b/recipes-devtools/grpc/grpc_%.bbappend
@@ -0,0 +1,2 @@
+EXTRA_OECMAKE:remove:class-nativesdk = "-DBUILD_SHARED_LIBS=ON"
+EXTRA_OECMAKE:append:class-nativesdk = " -DBUILD_SHARED_LIBS=OFF"
-- 
2.17.1

Re: [yocto] [meta-mingw] [PATCH 1/3] protobuf: static link tools when generating sdk

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 1111 bytes --]

On Mon, Aug 16, 2021 at 6:36 PM Sinan Kaya <okaya@kernel.org> wrote:

> Dynamically linked protoc.exe is failing as follows:
>
> [libprotobuf ERROR google/protobuf/descriptor_database.cc:641]
> File already exists in database: google/protobuf/descriptor.proto
> [libprotobuf FATAL google/protobuf/descriptor.cc:1371] CHECK failed:
> GeneratedDatabase()->Add(encoded_file_descriptor, size):
>
> Switch to static linkage per upstream recommendation.
>
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> ---
>  recipes-devtools/protobuf/protobuf_%.bbappend | 1 +
>  1 file changed, 1 insertion(+)
>  create mode 100644 recipes-devtools/protobuf/protobuf_%.bbappend
>
> diff --git a/recipes-devtools/protobuf/protobuf_%.bbappend
> b/recipes-devtools/protobuf/protobuf_%.bbappend
> new file mode 100644
> index 0000000..7e62ff6
> --- /dev/null
> +++ b/recipes-devtools/protobuf/protobuf_%.bbappend
> @@ -0,0 +1 @@
> +EXTRA_OECONF:append:class-nativesdk = " --disable-shared"


This is not an inert change can it use some mingw specific override as well

>
> --
> 2.17.1
>
>
> 
>
>

[-- Attachment #2: Type: text/html, Size: 1794 bytes --]

Re: [yocto] [meta-mingw] [PATCH 1/3] protobuf: static link tools when generating sdk

[Sinan Kaya]

On 8/17/2021 6:26 AM, Khem Raj wrote:
>     +EXTRA_OECONF:append:class-nativesdk = " --disable-shared"
> 
> 
> This is not an inert change can it use some mingw specific override as well 

Change is targeting meta-mingw repository. I looked at other files
in the repo to see what the pattern is.

Re: [yocto] [meta-mingw] [PATCH 1/3] protobuf: static link tools when generating sdk

[Joshua Watt]

On 8/17/21 6:03 AM, Sinan Kaya wrote:
> On 8/17/2021 6:26 AM, Khem Raj wrote:
>>      +EXTRA_OECONF:append:class-nativesdk = " --disable-shared"
>>
>>
>> This is not an inert change can it use some mingw specific override as well
> Change is targeting meta-mingw repository. I looked at other files
> in the repo to see what the pattern is.

All of the bbappends in meta-mingw should be using the :mingw32 override 
(or sdkmingw32 if it specific to just the SDK). If you found an example 
in the current code where that is not the case, it needs to be fixed. 
Either way, you need to use that override in your patches.