* [PATCH] staging: r8188eu: Add spaces before and after logical '&'
@ 2021-08-17 2:26 Abhishek Anand Kulkarni
2021-08-17 6:54 ` Michael Straube
0 siblings, 1 reply; 2+ messages in thread
From: Abhishek Anand Kulkarni @ 2021-08-17 2:26 UTC (permalink / raw)
To: gregkh
Cc: Larry.Finger, phil, linux-staging, linux-kernel, kulkarniabhishekanand
Fix Checkpatch.pl warning to add space before and after logical '&'
operator
Signed-off-by: Abhishek Anand Kulkarni <kulkaraniabhishekanand@gmail.com>
---
drivers/staging/r8188eu/core/rtw_ioctl_set.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/r8188eu/core/rtw_ioctl_set.c b/drivers/staging/r8188eu/core/rtw_ioctl_set.c
index a7f966a..570f25f 100644
--- a/drivers/staging/r8188eu/core/rtw_ioctl_set.c
+++ b/drivers/staging/r8188eu/core/rtw_ioctl_set.c
@@ -630,7 +630,7 @@ u8 rtw_set_802_11_add_key(struct adapter *padapter, struct ndis_802_11_key *key)
struct ndis_802_11_wep *wep = &padapter->securitypriv.ndiswep;
wep->Length = len;
- keyindex = key->KeyIndex&0x7fffffff;
+ keyindex = key->KeyIndex & 0x7fffffff;
wep->KeyIndex = keyindex ;
wep->KeyLength = key->KeyLength;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: r8188eu: Add spaces before and after logical '&'
2021-08-17 2:26 [PATCH] staging: r8188eu: Add spaces before and after logical '&' Abhishek Anand Kulkarni
@ 2021-08-17 6:54 ` Michael Straube
0 siblings, 0 replies; 2+ messages in thread
From: Michael Straube @ 2021-08-17 6:54 UTC (permalink / raw)
To: Abhishek Anand Kulkarni, gregkh
Cc: Larry.Finger, phil, linux-staging, linux-kernel
On 8/17/21 4:26 AM, Abhishek Anand Kulkarni wrote:
> Fix Checkpatch.pl warning to add space before and after logical '&'
> operator
>
> Signed-off-by: Abhishek Anand Kulkarni <kulkaraniabhishekanand@gmail.com>
> ---
> drivers/staging/r8188eu/core/rtw_ioctl_set.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_ioctl_set.c b/drivers/staging/r8188eu/core/rtw_ioctl_set.c
> index a7f966a..570f25f 100644
> --- a/drivers/staging/r8188eu/core/rtw_ioctl_set.c
> +++ b/drivers/staging/r8188eu/core/rtw_ioctl_set.c
> @@ -630,7 +630,7 @@ u8 rtw_set_802_11_add_key(struct adapter *padapter, struct ndis_802_11_key *key)
> struct ndis_802_11_wep *wep = &padapter->securitypriv.ndiswep;
>
> wep->Length = len;
> - keyindex = key->KeyIndex&0x7fffffff;
> + keyindex = key->KeyIndex & 0x7fffffff;
> wep->KeyIndex = keyindex ;
> wep->KeyLength = key->KeyLength;
>
>
Hi Abhishek,
there is already a pending patch that addresses this.
https://lore.kernel.org/linux-staging/20210816155818.24005-9-straube.linux@gmail.com/T/#u
Regards,
Michael
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-17 6:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-17 2:26 [PATCH] staging: r8188eu: Add spaces before and after logical '&' Abhishek Anand Kulkarni
2021-08-17 6:54 ` Michael Straube
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.