From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92347C4338F for ; Tue, 17 Aug 2021 05:03:42 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 707B260F58 for ; Tue, 17 Aug 2021 05:03:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 707B260F58 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AA4F88296F; Tue, 17 Aug 2021 07:03:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="jlZASXMs"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 617CE82BEC; Tue, 17 Aug 2021 07:03:36 +0200 (CEST) Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 416CE801FD for ; Tue, 17 Aug 2021 07:03:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1629176605; bh=wos8JSsU2L5b/C+MHqxSSq0YhPP89ZYrjVo8xGR5iAM=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=jlZASXMs/aK2kgy9HHK+HpaqLAyqmNOKTNMMSDncK49+Bw3D+Z5trbbuTtklbdTST SPHNdnl86lajuJnAXFkjQQkcTJR2VVQ/NxzUFVGvhCkjSBm8WGyQOKVhXfx63itPn+ znM3h8Qdb9shvoSte9It58X77RRr9ZgBv5vupb5o= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from LT02.fritz.box ([88.152.144.157]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MOA3F-1mQXRc2fur-00OWuf; Tue, 17 Aug 2021 07:03:25 +0200 From: Heinrich Schuchardt To: Tom Rini Cc: =?UTF-8?q?Marek=20Beh=C3=BAn?= , =?UTF-8?q?Pali=20Roh=C3=A1r?= , Stefan Roese , Chris Packham , u-boot@lists.denx.de, Heinrich Schuchardt Subject: [PATCH 1/1] kwbimage: check fopen() return value Date: Tue, 17 Aug 2021 07:03:20 +0200 Message-Id: <20210817050320.11983-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:P80XMIcw6ylBBD/tYVCMRmrCXb7s7qq+00ioRONi6w9+Hnnyiya LiKsJmhN7TE3/UV2BYbeT3LczGoSq9hnUGj8h4StDGpPg+HE2mENxvmGEIVcKqPmaaJbdkz ccL9cEnnG6kTTgXzVYpGEyIAJy8jWCicvxSC9jC2x0iqnyWiQKds2RrZY0WKiPUUCFNcS76 AC8KxR48pIPnhJ8NgyKmA== X-UI-Out-Filterresults: notjunk:1;V03:K0:3W3tR2Gj4uI=:9m7yF/ThN+bchnZjYVOklq G98oUoB8Y8SAWT6zNrY/oPPNAAZZqjDhOkaCmYu7GpoH3xrnWr+nTBhA6tZB2X2Z1jnj14VAw px3262wIJmm3Va53uVCkybyUC7wDvWI+1C0puumduSe/5wTM5cc/3uwNnsqUqQAp5ZHOm9AFU lHshqECqH3dWHjls3h+BgqzrdEgJJjbAWMbzxpMSfBuQAN1fyhLPFY21vCw9YN6zl5WDr6QlP JXazPVfgVuA2G0BK7HItrSCf82R7IJN3mzus4gQcffnI1+bwLTX36zLUmsEWhzrpUWuoe1lhS MG2jvT6WbxEBBpKsT0TYm6/P0q7/GYzpY6H35s6W6LYqg5lP/7RYohwrmSsdlGYR380HLsydu WdwtDwouLg564pcqWgrQ+xPlE7kucKxM25YgRplySs83qnt7zz1A6bFPDEqzAQtqLEFCNhO4A MsJy/2+EWUcme4RjpBKGuL7UuPiM7QzbfmNopvk/eY2lnz6dVY77znQKKELDbKpJMbqesXS1e yPHM+oFlmPaOQTyjUZ1jQK4oRium8b4tUhOYJk3zFHPTd8meIjVYrjxVyYLL0c9z4dpbKORHB zBVAIuJTmipOteZ0KJ7tJ30dt+Am48STK7TSF+hQDe+gAFcV5Y5oc69uXLv//3xB31T89EEAq BiRz9axXNXCLr3JPZBtUo5+phKhLX1uitHpeEo3fwxUJ5AUv1F3ZSfU827ked6O+0+uRnS2PA 8Q/7rYT9+jNQNeYp/p0qgwIYIGYUe+RWLGwCpQlQ44JbLGsj40P266OxoCI3yo3j0F1wRgx06 WGgtFM0Vc8bR6bGYudqMT/1GisM0fQZGk7+skv0pDQFMYiVjsGOMkOoLmdo/0i/rcL47RfEMx 5sTRZR3C7s8o1/s1lDXBcoSoFqLkgmL6VIsja+Rq4Md63KT+pR8XboVunGO7kOmWjhOU/R7u9 z23AvEkFoOZ9CXRrDXINk5JCYuntSk7BSFJXmLcKLIdsp8CZDm266oPVaMyEfMknMms3xJIyY zFO6W9UprDkIlPVrsKRCGegvCwMrdrNOS8H0qTnwvcpEw6hq4saVL0CFJbGm7k0Y8M/J1Fehx xyhm2F671DaXtMXSWqkblrzLlZhnSRhB0UfshgoVod5gv6eymVWY1Z6dw== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Always check the return value of fopen(). This resolves Coverity CID 338491: Null pointer dereferences (NULL_RETURNS) Signed-off-by: Heinrich Schuchardt =2D-- tools/kwbimage.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/tools/kwbimage.c b/tools/kwbimage.c index 00cb338d64..2a10df773b 100644 =2D-- a/tools/kwbimage.c +++ b/tools/kwbimage.c @@ -832,6 +832,12 @@ static int kwb_dump_fuse_cmds(struct secure_hdr_v1 *s= ec_hdr) if (!strcmp(e->name, "a38x")) { FILE *out =3D fopen("kwb_fuses_a38x.txt", "w+"); + if (!out) { + fprintf(stderr, "Couldn't open eFuse settings: '%s': %s\n", + "kwb_fuses_a38x.txt", strerror(errno)); + return -ENOENT; + } + kwb_dump_fuse_cmds_38x(out, sec_hdr); fclose(out); goto done; @@ -1060,6 +1066,11 @@ int export_pub_kak_hash(RSA *kak, struct secure_hdr= _v1 *secure_hdr) int res; hashf =3D fopen("pub_kak_hash.txt", "w"); + if (!hashf) { + fprintf(stderr, "Couldn't open hash file: '%s': %s\n", + "pub_kak_hash.txt", strerror(errno)); + return 1; + } res =3D kwb_export_pubkey(kak, &secure_hdr->kak, hashf, "KAK"); =2D- 2.30.2